D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added a comment. I created a new version at https://phab.mercurial-scm.org/D6310. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6218 To: pulkit, durin42, martinvonz, #hg-reviewers Cc: indygreg, idlsoft, mercurial-devel

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit updated this revision to Diff 14870. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6218?vs=14765=14870 REVISION DETAIL https://phab.mercurial-scm.org/D6218 AFFECTED FILES

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

idlsoft added a comment. This is nitpicking, but there is a duplicate `_NARROWACL_SECTION` definition in narrowbundle2.py, I think only the one in exchange.py should remain. Btw it's still 'narrowhgacl' from the old days. REPOSITORY rHG Mercurial REVISION DETAIL

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

idlsoft added a comment. If ACL is enabled, processing this part is mandatory, yes. On clone, or pull the user doesn't specify includes, so reading this part is the only way the client can get them. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6218 To:

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

martinvonz added a comment. In https://phab.mercurial-scm.org/D6218#91121, @idlsoft wrote: > Because the current client ignores the data completely, the only way to force it to fail I think is to change the name of the part. > This would make things cleaner probably, but I'll deal

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

idlsoft added a comment. Because the current client ignores the data completely, the only way to force it to fail I think is to change the name of the part. This would make things cleaner probably, but I'll deal with whatever solution you guys settle on. REPOSITORY rHG Mercurial

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added a comment. In https://phab.mercurial-scm.org/D6218#91119, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6218#91058, @indygreg wrote: > > > This patch is backwards incompatible over the wire protocol. > > > > The problem is a new client will blindly send part

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

martinvonz added a comment. In https://phab.mercurial-scm.org/D6218#91058, @indygreg wrote: > This patch is backwards incompatible over the wire protocol. > > The problem is a new client will blindly send part data to an old server expecting part parameters. The old server won't read

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

indygreg added a comment. This patch is backwards incompatible over the wire protocol. The problem is a new client will blindly send part data to an old server expecting part parameters. The old server won't read the part data and it would be as if the includes and excludes were not

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowbundle2.py:152 > I'd drop these checks Sent https://phab.mercurial-scm.org/D6241. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6218 To: pulkit, durin42, martinvonz, #hg-reviewers Cc:

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8a37c9b6cf0a: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

martinvonz added inline comments. INLINE COMMENTS > narrowbundle2.py:152 > +inc, exc = data.split('\0') > +if inc: > +includepats |= set(inc.splitlines()) I'd drop these checks > exchange.py:2218 > +data = '' > if include: > +data +=

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit updated this revision to Diff 14711. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6218?vs=14691=14711 REVISION DETAIL https://phab.mercurial-scm.org/D6218 AFFECTED FILES hgext/narrow/narrowbundle2.py mercurial/exchange.py CHANGE DETAILS

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

martinvonz added inline comments. INLINE COMMENTS > pulkit wrote in exchange.py:2217 > I don't feel good about the fact that we are not encoding data here. Is there > exists some function which I can use to encode and decode this list of specs? You could probably reuse the function from

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added inline comments. INLINE COMMENTS > exchange.py:2217 > narrowspecpart = bundler.newpart('narrow:spec') > +data = '' > if include: I don't feel good about the fact that we are not encoding data here. Is there exists some function which I can use to encode

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, when ACL is involved, narrowspecs are send as bundle2 parameter for