durin42 added a comment.
In https://phab.mercurial-scm.org/D6258#91056, @indygreg wrote:
> In https://phab.mercurial-scm.org/D6258#91055, @durin42 wrote:
>
> > Argh. This change appears to be wrong (!) so I'm going to drop it.
>
>
> Eh? I don't see anything wrong with this.
indygreg added a comment.
In https://phab.mercurial-scm.org/D6258#91055, @durin42 wrote:
> Argh. This change appears to be wrong (!) so I'm going to drop it.
Eh? I don't see anything wrong with this. Casting a `pathlib.Path` to `str`
should just work! In fact, it is necessary for
durin42 added a comment.
Argh. This change appears to be wrong (!) so I'm going to drop it.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6258
To: durin42, #hg-reviewers, pulkit
Cc: mercurial-devel
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG69b4426d288b: packaging: coerce paths to strings (authored
by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6258?vs=14788=14790
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Experimentally passing the pathlib.Path to zipfile.ZipFile fails on at
least some Python versions. I've gotten frustrated enough I'd rather
just force them to
