This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa4f7dceb07bf: phabricator: fallback to reading metadata
from diff for phabread (authored by Kwan, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6
martinvonz added inline comments.
INLINE COMMENTS
> martinvonz wrote in phabricator.py:926
> I'm not very good at using the phabricator interface, but it seems like this
> has been addressed since this line doesn't have a `get`. Can someone confirm?
Oh, sorry, Kwan is the author is this series
martinvonz added inline comments.
INLINE COMMENTS
> Kwan wrote in phabricator.py:926
> I didn't use `get` here because "dateCreated" is set by conduit, not the
> submitted data, so should always be present and valid (but will make it `get`
> if requested).
I'm not very good at using the phabri
Kwan added inline comments.
INLINE COMMENTS
> phabricator.py:926
> +meta = {}
> +if b'date' not in meta and b'dateCreated' in diff:
> +meta[b'date'] = b'%s 0' % diff[b'dateCreated']
I didn't use `get` here because "dateCreated" is set by conduit, not the
submitted data,
Kwan updated this revision to Diff 14894.
Kwan edited the summary of this revision.
Kwan edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6301?vs=14890&id=14894
BRANCH
default
REVISION DETAIL
https://phab.mercurial-s
Kwan updated this revision to Diff 14890.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6301?vs=14889&id=14890
REVISION DETAIL
https://phab.mercurial-scm.org/D6301
AFFECTED FILES
hgext/phabricator.py
tests/test-phabricator.t
CHANGE DETAILS
diff -
Kwan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The metadata in properties can be incomplete or missing entirely, in which
case
we can fallback to retrieving some from the diff itself.
REPOSITORY
rHG Mercurial
