This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd1786c1d34fa: rust-dirstate: add rust implementation of
`parse_dirstate` and `pack_dirstate` (authored by Alphare, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
Alphare added a comment.
Thanks for review. I think I've addressed all of your points.
INLINE COMMENTS
> kevincox wrote in dirstate.rs:34
> You check for PARENT_SIZE then index by PERENT_SIZE*2. This will panic if the
> size is between the two.
Good catch, thanks!
REPOSITORY
rHG
Alphare updated this revision to Diff 15066.
Alphare marked 5 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6348?vs=15031=15066
REVISION DETAIL
https://phab.mercurial-scm.org/D6348
AFFECTED FILES
rust/hg-core/Cargo.toml
kevincox requested changes to this revision.
kevincox added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dirstate.rs:16
> +pub type DirstateVec = Vec<(Vec, DirstateTuple)>;
> +pub type CopyMap<'a> = Vec<(&'a [u8], &'a [u8])>;
> +
You have a lot of tuples
Alphare created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Working towards the goal of having a complete Rust implementation of
`hg status`, these two utils are a first step of many to be taken
to
