D6429: rust-discovery: avoid useless calls to addcommons/addmissings

2019-06-10 Thread kevincox (Kevin Cox)
kevincox requested changes to this revision. kevincox added a comment. This revision now requires changes to proceed. Wouldn't it be better to make `add_missing_revisions` work properly on empty inputs? It seems like it is too error prone to try and catch every caller. If possible I would lik

D6429: rust-discovery: avoid useless calls to addcommons/addmissings

2019-05-22 Thread gracinet (Georges Racinet)
gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Whatever the implementation in hg-core, it's simpler to test for this condition in the bindings because the core methods take `impl IntoIterat