D6429: rust-discovery: optimization of add commons/missings for empty arguments

Closed by commit rHGc5748c6969b9: rust-discovery: optimization of add commons/missings for empty arguments (authored by Georges Racinet on percheron.racinet.fr ). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it l

D6429: rust-discovery: optimization of add commons/missings for empty arguments

kevincox added a comment. kevincox accepted this revision. Thanks, looks good. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6429/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6429 To: gracinet, #hg-reviewers, kevincox Cc: durin42, kevincox,

D6429: rust-discovery: optimization of add commons/missings for empty arguments

gracinet added a comment. @kevincox, thanks for the review of this and its predecessors. I think I've addressed all your remarks and improvement suggestions. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6429/new/ REVISION DETAIL https://phab.mercu

D6429: rust-discovery: optimization of add commons/missings for empty arguments

gracinet added a comment. In D6429#94512 , @kevincox wrote: > Wouldn't it be better to make `add_missing_revisions` work properly on empty inputs? It seems like it is too error prone to try and catch every caller. If possible I would like to pu

D6429: rust-discovery: optimization of add commons/missings for empty arguments

gracinet updated this revision to Diff 15486. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6429?vs=15472&id=15486 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6429/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6429 AFFECTED FILE

D6429: rust-discovery: optimization of add commons/missings for empty arguments

gracinet edited the summary of this revision. gracinet retitled this revision from "rust-discovery: avoid useless calls to addcommons/addmissings" to "rust-discovery: optimization of add commons/missings for empty arguments". gracinet updated this revision to Diff 15472. REPOSITORY rHG Mercuri