D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

yuja added a comment. > I fixed the renames. The amended changeset is available at, bitbucket.org/octobus/mercurial-devel, rev d4bbf54624e14ac2913d452a8a7cb32823227c16. If you want me to send you the patch some other way, please tell me. Pushed as 326fdce22fb2

Re: D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

> I fixed the renames. The amended changeset is available at, > bitbucket.org/octobus/mercurial-devel, rev > d4bbf54624e14ac2913d452a8a7cb32823227c16. If you want me to send you the > patch some other way, please tell me. Pushed as 326fdce22fb2, thanks. ___

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare added a comment. In D6597#97348 , @yuja wrote: >> diff --git a/rust/hg-core/src/utils/mod.rs b/rust/hg-core/src/utils/mod.rs >> deleted file mode 100644 > > Can you rename these instead of adding new files? Last time I fixed that

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

yuja added a comment. > diff --git a/rust/hg-core/src/utils/mod.rs b/rust/hg-core/src/utils/mod.rs > deleted file mode 100644 Can you rename these instead of adding new files? Last time I fixed that manually, and I don't wanna do that again. REPOSITORY rHG Mercurial CHANGES SINCE L

Re: D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

> diff --git a/rust/hg-core/src/utils/mod.rs b/rust/hg-core/src/utils/mod.rs > deleted file mode 100644 Can you rename these instead of adding new files? Last time I fixed that manually, and I don't wanna do that again. ___ Mercurial-devel mailing list M

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Closed by commit rHG988cf9840866: rust-2018: switch hg-core and hg-cpython to rust 2018 edition (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Merc

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

durin42 added a comment. In D6597#97228 , @Alphare wrote: > In D6597#97177 , @durin42 wrote: > >> LGTM, but needs rebased (sorry for slow response) > > @durin42 I've rebased it on hg-committed,

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare added a comment. In D6597#97177 , @durin42 wrote: > LGTM, but needs rebased (sorry for slow response) @durin42 I've rebased it on hg-committed, but nothing's changed. Am I missing something? REPOSITORY rHG Mercurial CHANGES SINC

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

durin42 added a comment. LGTM, but needs rebased (sorry for slow response) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6597/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6597 To: Alphare, #hg-reviewers, kevincox Cc: pulkit, durin42, kevinc

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare updated this revision to Diff 15896. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6597?vs=15853&id=15896 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6597/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6597 AFFECTED FILES

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare edited the summary of this revision. Alphare updated this revision to Diff 15853. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6597?vs=15741&id=15853 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6597/new/ REVISION DETAIL https:/

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare added inline comments. INLINE COMMENTS > kevincox wrote in utils.rs:3 > This could really use a doc comment. I'll address those points in a separate (parent) changeset. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6597/new/ REVISION DETAIL h

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare added a comment. In D6597#96317 , @pulkit wrote: > Can you add link of mailing list thread in your commit message? Link from markmail or https://www.mercurial-scm.org/pipermail/mercurial-devel/. Sure, will amend. REPOSITORY rHG M

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare added a comment. In D6597#96881 , @kevincox wrote: > Is the SliceExt change related to the 2018 change? If not could you split the two? It is indeed related to 2018: `mod.rs` files are not needed anymore and this makes it both simp

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

kevincox added a comment. kevincox accepted this revision. Is the SliceExt change related to the 2018 change? If not could you split the two? INLINE COMMENTS > utils.rs:3 > + > +pub fn replace_slice(buf: &mut [T], from: &[T], to: &[T]) > +where This could really use a doc comment. > utils.

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. pulkit added a comment. Can you add link of mailing list thread in your commit message? Link from markmail or https://www.mercurial-scm.org/pipermail/mercurial-de

D6597: rust-2018: switch hg-core and hg-cpython to rust 2018 edition

pulkit added a comment. Can you add link of mailing list thread in your commit message? Link from markmail or https://www.mercurial-scm.org/pipermail/mercurial-devel/. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6597/new/ REVISION DETAIL https://