D6633: rust-dirstate: rust-cpython bridge for dirstatemap

2019-08-16 Thread yuja (Yuya Nishihara)
yuja added a comment. > +def getdirs(&self) -> PyResult { > +// TODO don't copy, share the reference > +self.inner(py).borrow_mut().set_dirs(); > +Dirs::from_inner( > +py, > +DirsMultiset::new( > +DirsIterable::Dirs

Re: D6633: rust-dirstate: rust-cpython bridge for dirstatemap

2019-08-16 Thread Yuya Nishihara
> +def getdirs(&self) -> PyResult { > +// TODO don't copy, share the reference > +self.inner(py).borrow_mut().set_dirs(); > +Dirs::from_inner( > +py, > +DirsMultiset::new( > +DirsIterable::Dirstate(&self.inner(py).borrow()), > +

D6633: rust-dirstate: rust-cpython bridge for dirstatemap

2019-08-14 Thread Raphaël Gomès
Closed by commit rHGe0f7ee53107e: rust-dirstate: rust-cpython bridge for dirstatemap (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHAN

D6633: rust-dirstate: rust-cpython bridge for dirstatemap

2019-07-24 Thread Raphaël Gomès
Alphare updated this revision to Diff 16052. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6633?vs=15851&id=16052 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6633/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6633 AFFECTED FILES

D6633: rust-dirstate: rust-cpython bridge for dirstatemap

2019-07-10 Thread Raphaël Gomès
Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This change also showcases the limitations of the `py_shared_ref!` macro. See the previous commit 'rust-dirstate: rust implementation of dirst