Closed by commit rHGa124b79a3a7e: phabricator: update hgmatcher to cope with
the new data format (authored by Kwan).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG Mercur
durin42 added inline comments.
INLINE COMMENTS
> Kwan wrote in phabricator.py:155-156
> These will need converting to unicode first for py3.5 (I keep forgetting
> about loads only accepting bytes from 3.6 onwards).
That might be a nudge towards dropping 3.5 support. We've already got problems
Kwan added inline comments.
INLINE COMMENTS
> phabricator.py:155-156
> +if value.startswith(b'{') and value.endswith(b'}'):
> +r1json = json.loads(value)
> +r2json = json.loads(r2params[key][0])
> +if r1json != r2json:
These will need c
Kwan added a comment.
Kwan updated this revision to Diff 17105.
I'd missed out the attrs key conversion needed on py3.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7055?vs=17085&id=17105
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.merc
Kwan added a comment.
Kwan updated this revision to Diff 17085.
Fix some test-check-code issues, and one test-check-pyflakes unused local.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7055?vs=17061&id=17085
BRANCH
default
CHANGES SINCE LAST ACTION
Kwan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The new conduit format can't be matched by the existing matcher since it
shifts
all the data into an urlencoded string of JSON, the order of which isn't
stable
be
