D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Closed by commit rHG38ac72317ba4: rust-dirstate-status: add first Rust implementation of `dirstate.status` (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17252. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17196&id=17252 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

martinvonz added inline comments. INLINE COMMENTS > status.rs:103-110 > +Err(ref e) > +if e.kind() == std::io::ErrorKind::NotFound > +|| e.raw_os_error() == Some(20) => > +{ > +// R

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17196. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17184&id=17196 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17184. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17181&id=17184 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in status.rs:24 > Do we need to borrow it mutably? We don't anymore, thanks. I'll be reworking the overly complicated match expression within the next hour. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.me

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17181. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17176&id=17181 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

martinvonz added inline comments. INLINE COMMENTS > status.rs:24 > +files: Vec, > +dmap: &mut DirstateMap, > +root_dir: P, Do we need to borrow it mutably? > status.rs:49 > +(normalized, Ok(stat)) => { > +if stat.is_file() { > +results

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

kevincox added a comment. kevincox accepted this revision. Thanks, looks good. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 To: Alphare, #hg-reviewers, kevincox Cc: yuja, martinvonz, d

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17176. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17167&id=17176 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added inline comments. Alphare marked an inline comment as done. INLINE COMMENTS > kevincox wrote in status.rs:23 > This doesn't appear to be consumed by the function so you should take a > `&[HgPathBuf]`. Or since I don't think you use the path either probably a > `&[HgPath]`. Done wi

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > Alphare wrote in status.rs:83 > Collecting into a `Result` prevents us from doing a `filter_map` during > `collect`. Implementing a `ParallelIterator` ada

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17167. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17165&id=17167 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17165. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17133&id=17165 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added a comment. In D7058#103954 , @yuja wrote: > Just quickly scanned. Not reviewed the core logic. > >> +/// Get name in the case stored in the filesystem >> +/// The name should be relative to root, and be normcase-ed for effic

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

yuja added a comment. Just quickly scanned. Not reviewed the core logic. > +/// Get name in the case stored in the filesystem > +/// The name should be relative to root, and be normcase-ed for efficiency. > +/// > +/// Note that this function is unnecessary, and should not be > +//

Re: D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Just quickly scanned. Not reviewed the core logic. > +/// Get name in the case stored in the filesystem > +/// The name should be relative to root, and be normcase-ed for efficiency. > +/// > +/// Note that this function is unnecessary, and should not be > +// called, for case-sensitive filesyste

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17133. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17132&id=17133 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17132. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17065&id=17132 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added a comment. Alphare marked 3 inline comments as done. @martinvonz First of all, thanks a lot for starting the Rust reviews, your feedback is very helpful. For most of your comments, I tried cutting out the parts of the implementation that were not needed yet but did not go f

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

martinvonz added a comment. I've slowly worked my way through `walk_explicit()` so far, but I had a few comments there, so I'll let you take a look at those first while I take a break. INLINE COMMENTS > status.rs:22 > +/// TODO subrepos > +pub fn walk_explicit>( > +files: Vec, Does this

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Note: This patch also added the rayon crate as a Cargo dependency. It will help us immensely in making Rust code parallel and easy to maintain. I