D7084: fix: make Fixer initialization more explicit for clarity

2019-10-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7084#104166 , @pulkit wrote: > Hm, IIUC this was edited in flight, not sure why. I noticed that test-check-format.t was failing last night so I fixed it up in flight. It wanted to put the procutil import on

D7084: fix: make Fixer initialization more explicit for clarity

2019-10-15 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Hm, IIUC this was edited in flight, not sure why. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7084/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7084 To: martinvonz, #hg-reviewers, pulkit Cc: mercurial-devel ___

D7084: fix: make Fixer initialization more explicit for clarity

2019-10-14 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG2e3aa8ed5bdf: fix: make Fixer initialization more explicit for clarity (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7084?vs=17129&id=1

D7084: fix: make Fixer initialization more explicit for clarity

2019-10-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I found it quite confusing that Fixer accessed fields that seemed like they didn't exist. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-