yuja added a comment.
> TBH I'm not sure what's going on there. Perhaps a bad byte/newline
sequence in the file?
It's a C89 thing. Declarations must come first.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7105/new/
REVISION DETAIL
> TBH I'm not sure what's going on there. Perhaps a bad byte/newline sequence
> in the file?
It's a C89 thing. Declarations must come first.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
indygreg added a comment.
I dropped this from committed because of discussion on this review and
because Windows was not happy with the change:
mercurial/cext/dirs.c(75) : error C2275: 'PyObject' : illegal use of this
type as an expression
> diff --git a/mercurial/cext/dirs.c b/mercurial/cext/dirs.c
> --- a/mercurial/cext/dirs.c
> +++ b/mercurial/cext/dirs.c
> @@ -52,6 +52,7 @@
> {
> const char *cpath = PyBytes_AS_STRING(path);
> Py_ssize_t pos = PyBytes_GET_SIZE(path);
> + Py_ssize_t prev_pos = -1;
> PyObject
Closed by commit rHG1f04c51d52ea: dirs: reject consecutive slashes in paths
(authored by durin42).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7105?vs=17173=17192
CHANGES SINCE
This revision is now accepted and ready to land.
indygreg added a comment.
indygreg accepted this revision.
This seems strictly correct, since the `dirs` type should be internal and
should be well-formed.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We shouldn't ever see those, and the fuzzer go really excited that if
it gives us a 65k string with 55k slashes in it we use a lot of RAM.
REPOSITORY
rHG
