This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back t
mharbison72 added a comment.
I lean towards searching the whole repo by default, for the reasons that
Jordi listed, especially consistency with other hg commands.
I almost never `hg grep` from the command line, and typically search in
TortoiseHg instead. But there, I always want it to s
durin42 added a comment.
(Note that post-5.2 is probably too late to make this tweak, so there's some
urgency in this discussion.)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7146/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7146
To: pul
durin42 added a comment.
Huh, this behavior of `git grep` surprises me, but not _that_ much.
We do already print PWD-relative paths if `tweakdefaults` is active, right?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7146/new/
REVISION DETAIL
htt
jeffpc added a comment.
I'm the instigator of the IRC discussion, so I'll summarize my reasoning here
as well.
Based on years of working on various sw projects, I've concluded that about
90% of the time I want to grep $PWD and the remaining 10% of the time I want to
grep the whole repo.
JordiGH added a comment.
I will repeat my position as stated on IRC. I am against this change because,
1. it's inconsistent with shelve, commit, addremove, status, diff and all
other operations that by default work on the entire repo
2. it's difficult to go from this proposed default to
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is motivated by a disscussion on IRC.
TODO: need to add tests, register config option and add docs.
Tests are not ran on this yet.
REPOSITORY
rHG Me
