D7219: hghave: decode black's version before passing to StrictVersion

2019-11-04 Thread Kwan (Ian Moody)
Kwan added a comment. Kwan abandoned this revision. Drop in favour of D7221 . REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7219/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7219 To: Kwan, #hg-reviewers

D7219: hghave: decode black's version before passing to StrictVersion

2019-11-04 Thread durin42 (Augie Fackler)
durin42 added a comment. This is subtlely wrong on Python 2, and I think D7221 is a correct fix. (I'd previously mailed that patch, but mail is backlogged.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7219

D7219: hghave: decode black's version before passing to StrictVersion

2019-11-04 Thread Kwan (Ian Moody)
Kwan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY StrictVersion doesn't accept bytes, so test-hghave.t was dying with "cannot use a string pattern on a bytes-like object". REPOSITORY rHG Mercurial BRANCH stable