D7252: dirs: reject consecutive slashes in paths

marmoute added a comment. In practice, this means the tests consistently fails when testing with Rust. Can we either have a quick fix of the Rust code or a temporary backout of this (until we Rust code is fixed)? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7252: dirs: reject consecutive slashes in paths

Alphare added a comment. > Oh, you mean the Rust version doesn't do the same rejection? It does not, currently. > Given that you're about to do a hash lookup, I'm a little skeptical that a `endswith('/')` check would show up meaningfully in a profiler, but I'm willing to be proven

D7252: dirs: reject consecutive slashes in paths

durin42 added a comment. In D7252#109656 , @durin42 wrote: > In D7252#109627 , @Alphare wrote: > >> Sorry to necropost, but since this broke the Rust implementation, I was wondering what the

D7252: dirs: reject consecutive slashes in paths

durin42 added a comment. In D7252#109627 , @Alphare wrote: > Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this

D7252: dirs: reject consecutive slashes in paths

Alphare added a comment. Sorry to necropost, but since this broke the Rust implementation, I was wondering what the best approach would be to replicate this behavior, and I am starting to think that this should be reverted. IIUC, currently any new path passes through the `pathauditor`

D7252: dirs: reject consecutive slashes in paths

Closed by commit rHGd14d245c78ed: dirs: reject consecutive slashes in paths (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7252?vs=17620=17709 CHANGES SINCE

D7252: dirs: reject consecutive slashes in paths

durin42 edited the summary of this revision. durin42 updated this revision to Diff 17620. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7252?vs=17619=17620 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7252/new/ REVISION DETAIL

D7252: dirs: reject consecutive slashes in paths

durin42 edited the summary of this revision. durin42 updated this revision to Diff 17619. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7252?vs=17618=17619 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7252/new/ REVISION DETAIL