Closed by commit rHG889ac87e8bfd: rust-status: improve status performance
(authored by Alphare).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG Mercurial
CHANGES SINCE
Alphare updated this revision to Diff 17739.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7254?vs=17711=17739
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7254/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7254
Alphare added a comment.
Alphare marked 7 inline comments as done.
Thanks for the review @kevincox.
INLINE COMMENTS
> kevincox wrote in status.rs:64
> I would create a helper function.
>
> fn mod_compare(a: i32, b: impl Into) -> bool {
> let b = b.into();
> a != b && a != b &
Alphare updated this revision to Diff 17711.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7254?vs=17622=17711
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7254/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7254
kevincox added inline comments.
kevincox accepted this revision.
INLINE COMMENTS
> status.rs:41
> +last_normal_time: i64,
> +) -> (HgPathBuf, Dispatch) {
> +let filename = filename.as_ref();
Every exit path is just `filename.to_owned()`. It would be better to just let
the caller do
Alphare created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This change does more things in the parallel loop, refactors the file-level
logic into two functions for added clarity.
This bit of Rust
