mbolin added inline comments.
INLINE COMMENTS
> dirstate.py:320
>
> def parents(self):
> return [self._validate(p) for p in self._pl]
Can/should `parents()`, `p1()`, and `p2()` here all be updated to go through
`map.parents()`? We should be moving in the direction of removing `_
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5fabba9b3d9c: dirstate: move parents source of truth to
dirstatemap (authored by durham, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D759?vs=208
durham updated this revision to Diff 2083.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D759?vs=1954&id=2083
REVISION DETAIL
https://phab.mercurial-scm.org/D759
AFFECTED FILES
mercurial/dirstate.py
CHANGE DETAILS
diff --git a/mercurial/dirstate.py
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
The logic here isn't readable enough that IMO we should fix it in flight.
INLINE COMMENTS
> dirstate.py:1382-1383
> +raise
> +if not self._pare
durham created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As part of moving dirstate storage to its own class, let's move the source of
truth for the dirstate parents to dirstatemap. This requires that dirstate._pl
no lo
