Closed by commit rHGe52401a95b94: rust-nodemap: NodeMap trait with simplest
implementation (authored by gracinet).
gracinet marked 2 inline comments as done.
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state
martinvonz added inline comments.
INLINE COMMENTS
> gracinet wrote in nodemap.rs:153
> Perhaps a better name would be better than this `has_` that indeed feels
> boolean?
>
> `check_prefix`? `confirm` ?
>
> Previous naming was `validate_candidate`, but that very same name is used at
> the
gracinet added inline comments.
gracinet marked 3 inline comments as done.
INLINE COMMENTS
> kevincox wrote in nodemap.rs:37
> Can you please add doc-comments for this? I find that documenting trait
> methods is especially important.
Sure, indeed it's more important than with the `impl`.
>
gracinet retitled this revision from "rust-nodemap: NodeMap trait with simplest
implementor" to "rust-nodemap: NodeMap trait with simplest implementation".
gracinet updated this revision to Diff 19631.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
