D7910: rust-re2: add wrapper for calling Re2 from Rust

Closed by commit rHGcdf3e49a0572: rust-re2: add wrapper for calling Re2 from Rust (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare updated this revision to Diff 20040. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7910?vs=19938=20040 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7910

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare updated this revision to Diff 19938. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7910?vs=19546=19938 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7910

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare updated this revision to Diff 19546. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7910?vs=19399=19546 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7910

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare updated this revision to Diff 19399. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7910?vs=19386=19399 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7910

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare marked an inline comment as done. Alphare updated this revision to Diff 19386. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7910?vs=19360=19386 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION

D7910: rust-re2: add wrapper for calling Re2 from Rust

kevincox added a comment. While I think the rust regex crate is heavily inspired by RE2 and uses a fairly compatible syntax I don't think there is a goal to be 100% compatible and I would be surprised if there weren't any differences. What I am trying to say is that if we are going to

D7910: rust-re2: add wrapper for calling Re2 from Rust

durin42 added a comment. In D7910#116208 , @kevincox wrote: > Does mercurial currently use RE2? If not then can you explain why we don't just use the rust `regex` crate? We have support for using re2 iff the correct Python bindings are

D7910: rust-re2: add wrapper for calling Re2 from Rust

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > rust_re2.cpp:22 > + > + return new RE2(StringPiece(data, len), o); > + } This is never freed. Should we add a `Drop` implementation in

D7910: rust-re2: add wrapper for calling Re2 from Rust

kevincox added a comment. kevincox accepted this revision. Does mercurial currently use RE2? If not then can you explain why we don't just use the rust `regex` crate? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION DETAIL

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare created this revision. Herald added subscribers: mercurial-devel, mjpieters, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This assumes that Re2 is installed following Google's guide. I am not sure how we want to integrate it in the project, but I think a