D7921: rust-dirs-multiset: improve temporary error message

2020-02-07 Thread Raphaël Gomès
Closed by commit rHGa5c7d6cdaa2e: rust-dirs-multiset: improve temporary error message (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHA

D7921: rust-dirs-multiset: improve temporary error message

2020-01-24 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. It seems this one doesn't apply cleanly REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7921/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7921 To: Alphare, #hg-reviewers, kevincox Cc: martinvonz, durin42, kevincox,

D7921: rust-dirs-multiset: improve temporary error message

2020-01-24 Thread Raphaël Gomès
Alphare updated this revision to Diff 19548. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7921?vs=19400&id=19548 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7921/new/ REVISION DETAIL https://phab.mercurial-scm.org/D79

D7921: rust-dirs-multiset: improve temporary error message

2020-01-24 Thread kevincox (Kevin Cox)
This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > dirs_multiset.rs:86 > +subpath.as_bytes(), > +); > +let second_slash_index = offset.unwrap() + subpath.

D7921: rust-dirs-multiset: improve temporary error message

2020-01-17 Thread Raphaël Gomès
Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While we wait on a future patch that could verify that the paths passed to `DirsMultiset` have been audited, we still need to handle this error.