Alphare created this revision.
Herald added subscribers: mercurial-devel, kevincox.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Performance of `hg update` was significantly worse since the introduction of
the Rust `dirstatemap`. This regression was noticed by Valentin Gatien-Baron
marmoute added a comment.
marmoute accepted this revision.
As you warned, this is not pretty. However that seems failry straightforward
and does the job.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8048/new/
REVISION DETAIL
https://phab.mercurial
Closed by commit rHG83b2b829c94e: rust-dirstatemap: cache non normal and other
parent set (authored by Alphare).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG Mercurial
Alphare updated this revision to Diff 20060.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8048?vs=20059&id=20060
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8048/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D80
kevincox added inline comments.
INLINE COMMENTS
> dirstate_map.rs:251
> +self.set_non_normal_other_parent_entries(false);
> +(&mut self.non_normal_set, &mut self.other_parent_set)
> +}
If we have just set the fields to `Some(..)` in the previous line can't we do
the unwrap h
