Closed by commit rHGbbb170f9396d: phabricator: add a `phabimport` command
(authored by mharbison72).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8136?vs=20554&id=20785
CHANGES SI
mharbison72 edited the summary of this revision.
mharbison72 updated this revision to Diff 20554.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8136?vs=20512&id=20554
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8136/new/
mharbison72 added inline comments.
INLINE COMMENTS
> pulkit wrote in phabricator.py:1722
> I think if you raise `error.Abort()`, it should be rolled back automatically
> but not sure.
That's what I thought too, but not what I saw when raising `error.Abort()`. I
can't reproduce that now though
pulkit added inline comments.
INLINE COMMENTS
> mharbison72 wrote in phabricator.py:1722
> When the `bypass` option is provided to `tryimportone()`, it looks like you
> can't get rejects and PatchErrors are converted to abort[1]. I'll clarify
> the commit message.
>
> Is there some graceful t
mharbison72 updated this revision to Diff 20512.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8136?vs=20450&id=20512
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8136/new/
REVISION DETAIL
https://phab.mercurial-scm.org
mharbison72 added inline comments.
INLINE COMMENTS
> durin42 wrote in phabricator.py:1693
> > Are you looking to skip some initial patches (which --stack doesn't allow,
> > but maybe - would), and apply the rest? Or are you trying to grab separate
> > series all at once?
>
> My typical workflo
durin42 added inline comments.
INLINE COMMENTS
> mharbison72 wrote in phabricator.py:1693
> I'm not quite sure the context. I didn't realize this until recently, but
> apparently `+` is a valid operator like with revsets. That said, I strung
> together two heads with common ancestors, `+`, and
mharbison72 added inline comments.
INLINE COMMENTS
> durin42 wrote in phabricator.py:1693
> Would it be reasonable to accept revspec*s* here so I could type a series of
> patch IDs and have them all land?
I'm not quite sure the context. I didn't realize this until recently, but
apparently `+`
durin42 added a comment.
durin42 accepted this revision as: durin42.
I like this, but have a question about a pony I kind of want as a follow-up.
Will let someone else queue...
INLINE COMMENTS
> phabricator.py:1693
> +[(b'', b'stack', False, _(b'import dependencies as well'))],
> +_(
mharbison72 edited the summary of this revision.
mharbison72 updated this revision to Diff 20450.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8136?vs=20426&id=20450
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8136/new/
mharbison72 added inline comments.
INLINE COMMENTS
> pulkit wrote in phabricator.py:1722
> I think we should abort if there are any rejects.
When the `bypass` option is provided to `tryimportone()`, it looks like you
can't get rejects and PatchErrors are converted to abort[1]. I'll clarify the
pulkit added inline comments.
INLINE COMMENTS
> phabricator.py:1722
> +with patch.extract(ui, pycompat.bytesio(contents)) as
> patchdata:
> +msg, node, rej = cmdutil.tryimportone(
> +ui,
I think we should abort if there are any rejects
mharbison72 updated this revision to Diff 20426.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8136?vs=20260&id=20426
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8136/new/
REVISION DETAIL
https://phab.mercurial-scm.org
mharbison72 created this revision.
Herald added subscribers: mercurial-devel, Kwan, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I've had `alias.phabimport = $hg phabread --stack $1 | $hg import --bypass -`
for a while now, and I suspect others do too. That's limited tho
14 matches
Mail list logo
