D8190: nodemap: test that concurrent process don't see the pending transaction

2020-04-01 Thread marmoute (Pierre-Yves David)
Closed by commit rHGdd5b47fb0860: nodemap: test that concurrent process don't see the pending transaction (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D8190: nodemap: test that concurrent process don't see the pending transaction

2020-03-24 Thread durin42 (Augie Fackler)
durin42 added a comment. I think I'm coming around on this. I've poked a few reviewers in private to look at the first three patches in this series to see how they feel, but if I don't hear back in a day or two I think I'll just push the whole stack... REPOSITORY rHG Mercurial CHANGES SIN

D8190: nodemap: test that concurrent process don't see the pending transaction

2020-03-20 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D8190#124147 , @durin42 wrote: > In D8190#124146 , @marmoute wrote: > >> In D8190#124141 , @martinvonz wrote: >> >>>

D8190: nodemap: test that concurrent process don't see the pending transaction

2020-03-20 Thread durin42 (Augie Fackler)
durin42 added a comment. In D8190#124146 , @marmoute wrote: > In D8190#124141 , @martinvonz wrote: > >> > > This new patch works, but I don't like the idea of not testing two fully indepen

D8190: nodemap: test that concurrent process don't see the pending transaction

2020-03-20 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In D8190#124141 , @martinvonz wrote: > The parent patch (D8189 ) was a bit controversial. We don't need that patch if we apply the following patch on top of this one (making this

D8190: nodemap: test that concurrent process don't see the pending transaction

2020-03-20 Thread durin42 (Augie Fackler)
durin42 added a comment. In D8190#124141 , @martinvonz wrote: > @durin42, what do you think? That's *inspired* and looks like an awesome solution to me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.or

D8190: nodemap: test that concurrent process don't see the pending transaction

2020-03-20 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. martinvonz added subscribers: durin42, martinvonz. The parent patch (D8189 ) was a bit controversial. We don't need that patch if we apply the following patch on top of this one (making this test sleep-free): diff --git

D8190: nodemap: test that concurrent process don't see the pending transaction

2020-02-28 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We don't want other client to read uncommitted data, until the transaction is really committed. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL h