This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcb0a1764050c: fsmonitor: warn when fsmonitor could be used
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D894?vs=2998=2999
indygreg updated this revision to Diff 2998.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D894?vs=2315=2998
REVISION DETAIL
https://phab.mercurial-scm.org/D894
AFFECTED FILES
hgext/fsmonitor/__init__.py
mercurial/configitems.py
durin42 requested changes to this revision.
durin42 added inline comments.
INLINE COMMENTS
> krbullock wrote in merge.py:1739-1743
> It's been our style basically forever to use parens instead of backslashes.
> I'm honestly shocked we don't have a check-code rule for this.
Yes, definitely use
quark added inline comments.
INLINE COMMENTS
> krbullock wrote in test-fsmonitor-warning.t:9
> We can't squeeze these into a test that's already set up? Brand-new test
> cases are discouraged, since so much time in our test suite is already burned
> on initializing repos.
There was no
krbullock requested changes to this revision.
krbullock added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> mbthomas wrote in merge.py:1739-1743
> I'm not sure if we're planning to work towards PEP8, but it (and I) prefer
> using parentheses to break long if
mbthomas accepted this revision.
mbthomas added a comment.
LGTM
INLINE COMMENTS
> merge.py:1739-1743
> +if fsmonitorwarning \
> +and not fsmonitorenabled \
> +and p1.node() == nullid \
> +and len(actions['g']) >= fsmonitorthreshold \
>
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
fsmonitor can significantly speed up operations on large working
directories. But fsmonitor isn't enabled by default, so naive users
may not realize there is a
