pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds a new function named showchanges() which will output the
changes
like hashchanges, wdir change, movement of bookmarks etc. after a command.
This
pulkit added subscribers: yuja, quark.
pulkit added a comment.
@quark I was unable to make 'hashchanges' resolved by templater. I took help
from Yuya and he was bit confused on how you want it to be done. (adding @yuja)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.
dlax added a comment.
> diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
>
> - a/mercurial/scmutil.py +++ b/mercurial/scmutil.py @@ -685,6 +685,18 @@ if
tostrip: repair.delayedstrip(repo.ui, repo, tostrip, operation)
>
> +def showchanges(replacements, fm): +""" output t
pulkit planned changes to this revision.
pulkit added a comment.
In https://phab.mercurial-scm.org/D933#15594, @dlax wrote:
> > diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
> >
> > - a/mercurial/scmutil.py +++ b/mercurial/scmutil.py @@ -685,6 +685,18 @@
if tostrip: repair
pulkit updated this revision to Diff 2418.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D933?vs=2414&id=2418
REVISION DETAIL
https://phab.mercurial-scm.org/D933
AFFECTED FILES
mercurial/scmutil.py
CHANGE D
dlax added inline comments.
INLINE COMMENTS
> scmutil.py:695
> +fm.formatdict(nodesdict, fmt='%r --> %r', sep='\n'))
> +
> def addremove(repo, matcher, prefix, opts=None, dry_run=None,
> similarity=None):
Indentation still weird (though no longer wrong).
Could you align
pulkit updated this revision to Diff 2420.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D933?vs=2418&id=2420
REVISION DETAIL
https://phab.mercurial-scm.org/D933
AFFECTED FILES
mercurial/scmutil.py
CHANGE DETAILS
diff --git a/mercurial/scmutil.py b/
dlax requested changes to this revision.
dlax added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dlax wrote in scmutil.py:695
> Indentation still weird (though no longer wrong).
> Could you align continuation lines with the opening delimiter (`{` for
> `noded
pulkit updated this revision to Diff 2427.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D933?vs=2420&id=2427
REVISION DETAIL
https://phab.mercurial-scm.org/D933
AFFECTED FILES
mercurial/scmutil.py
CHANGE DETAILS
diff --git a/mercurial/scmutil.py b/
dlax added inline comments.
INLINE COMMENTS
> dlax wrote in scmutil.py:695
> A "correct" indentation would be:
>
> nodesdict = {short(pred): [short(s) for s in succs]
>for pred, succs in replacements.iteritems()}
> fm.write('hashchanges', '%s\n',
>fm.formatdict(n
pulkit updated this revision to Diff 2458.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D933?vs=2427&id=2458
REVISION DETAIL
https://phab.mercurial-scm.org/D933
AFFECTED FILES
mercurial/scmutil.py
CHANGE DETAILS
diff --git a/mercurial/scmutil.py b/
dlax accepted this revision.
dlax added a comment.
This patch looks good to me. But I have no idea if the overall idea in the
series is good or not.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D933
To: pulkit, #hg-reviewers, dlax
Cc: dlax, quark, yuja, mercur
pulkit abandoned this revision.
pulkit added a comment.
Abandoning in favor of https://phab.mercurial-scm.org/D1173.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D933
To: pulkit, #hg-reviewers, dlax
Cc: dlax, quark, yuja, mercurial-devel
___
13 matches
Mail list logo
