ryanmce accepted this revision as: ryanmce.
ryanmce added a comment.
I like this overall; but I don't feel I can queue a new flag to bisect
without input from the rest of the community.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D950
To: quark,
ryanmce added inline comments.
INLINE COMMENTS
> quark wrote in run-tests.py:2124-2153
> During the meeting deciding to experiment with Phabricator, I think we agreed
> that with Phabricator's ability to diff with whitespaces ignored
>
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in run-tests.py:2124-2153
> For readability, please add the try/finally (with the finally block being
> just `pass` for now) in a separate patch.
During the meeting deciding to experiment with Phabricator, I think we agreed
that
ryanmce requested changes to this revision.
ryanmce added a comment.
This revision now requires changes to proceed.
I'm +1 on this series and the rest looks fine but I think this one needs some
improvements before landing.
INLINE COMMENTS
> run-tests.py:2115-2116
> return data
