durin42 added a comment.
I also popped https://phab.mercurial-scm.org/D964 out of the stack until I
can address review feedback. :)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D965
To: durin42, #hg-reviewers, pulkit, indygreg, yuja
Cc: yuja, indygreg,
indygreg added a comment.
Bleh. I missed yuya's comment before doing a delayed push. Feel free to drop
this from hg-committed or address as a follow-up.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D965
To: durin42, #hg-reviewers, pulkit, indygreg, yuja
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4296bbb19410: templatefilters: be sure we always feed
cgi.escape a str (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
sysstr -> sysbytes can't be round-trip if non-ascii characters are involved.
Perhaps we can just vendor cgi.escape() and add b'' to every string.
REPOSITORY
rHG Mercurial
pulkit accepted this revision.
pulkit added a comment.
Checked docs and made sure `cgi.escape` on Python 3 accepts str only.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D965
To: durin42, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D965
AFFECTED FILES
mercurial/templatefilters.py
CHANGE DETAILS
diff --git
