This revision was automatically updated to reflect the committed changes.
Closed by commit rHG021607b4ef49: dispatch: when --pager=no is passed, also
disable pager on req.repo.ui (authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
lothiraldan accepted this revision.
lothiraldan added a comment.
LGTM, I was wondering if lui was special and if we should disable its pager
or not.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D990
To: quark, #hg-reviewers, lothiraldan
Cc: lothiraldan,
quark updated this revision to Diff 2572.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D990?vs=2535=2572
REVISION DETAIL
https://phab.mercurial-scm.org/D990
AFFECTED FILES
mercurial/dispatch.py
CHANGE DETAILS
diff --git a/mercurial/dispatch.py
lothiraldan added inline comments.
INLINE COMMENTS
> dispatch.py:869
> +if req.repo is not None:
> +req.repo.ui.disablepager()
>
Why not using the `uis` set to iterate like for other options above?
`repo.repo.ui` is already added to the set at line 771
REPOSITORY
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
With a future chg change, `req.repo` could be set and currently it is
unaffected by `--pager=on`. This patch makes it so.
This could make one of the test cases
