Re: [PATCH] extensions: move wrapfilecache function from fsmonitor

2017-06-09 Thread Yuya Nishihara
On Thu, 8 Jun 2017 23:49:27 +0100, Pierre-Yves David wrote: > On 06/08/2017 05:47 PM, Augie Fackler wrote: > >> On Jun 8, 2017, at 11:53, Yuya Nishihara wrote: > >> On Thu, 08 Jun 2017 10:51:38 -0400, Augie Fackler wrote: > >>> # HG changeset patch > >>> # User Augie Fackler > >>> # Date 14969330

Re: [PATCH] extensions: move wrapfilecache function from fsmonitor

2017-06-09 Thread Yuya Nishihara
On Thu, 8 Jun 2017 15:32:46 -0700, Jun Wu wrote: > Excerpts from Yuya Nishihara's message of 2017-06-09 00:53:19 +0900: > > IIRC, Jun had a bad time with this. Is this a good pattern to reliably > > wrap filecache? > > I think it's good to have it in core despite the implementation looks hacky. >

Re: [PATCH] extensions: move wrapfilecache function from fsmonitor

2017-06-08 Thread Pierre-Yves David
On 06/08/2017 05:47 PM, Augie Fackler wrote: On Jun 8, 2017, at 11:53, Yuya Nishihara wrote: On Thu, 08 Jun 2017 10:51:38 -0400, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1496933093 14400 # Thu Jun 08 10:44:53 2017 -0400 # Node ID ff739458783d32b8b0ce97a67

Re: [PATCH] extensions: move wrapfilecache function from fsmonitor

2017-06-08 Thread Jun Wu
Excerpts from Yuya Nishihara's message of 2017-06-09 00:53:19 +0900: > IIRC, Jun had a bad time with this. Is this a good pattern to reliably > wrap filecache? I think it's good to have it in core despite the implementation looks hacky. This enables journal to work with fsmonitor better. _

Re: [PATCH] extensions: move wrapfilecache function from fsmonitor

2017-06-08 Thread Augie Fackler
> On Jun 8, 2017, at 11:53, Yuya Nishihara wrote: > > On Thu, 08 Jun 2017 10:51:38 -0400, Augie Fackler wrote: >> # HG changeset patch >> # User Augie Fackler >> # Date 1496933093 14400 >> # Thu Jun 08 10:44:53 2017 -0400 >> # Node ID ff739458783d32b8b0ce97a6771513caf280c09b >> # Parent 0

Re: [PATCH] extensions: move wrapfilecache function from fsmonitor

2017-06-08 Thread Yuya Nishihara
On Thu, 08 Jun 2017 10:51:38 -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1496933093 14400 > # Thu Jun 08 10:44:53 2017 -0400 > # Node ID ff739458783d32b8b0ce97a6771513caf280c09b > # Parent 04c19c8082410049465e2cdc510e24801530c94b > extensions: move wrap