Re: D8337: pycompat: change argv conversion semantics

2020-03-31 Thread Yuya Nishihara
> > On Windows, my assumption was os.fsencode() == .encode("mbcs") if > > sys._enablelegacywindowsfsencoding(). So this looks good to me. > > Perhaps, the "ignore" error mode would match the legacy Windows behavior. > > Does this mean it could be a problem running from source on Windows?

Re: D8337: pycompat: change argv conversion semantics

2020-03-29 Thread Yuya Nishihara
> -# Since Python 3 converts argv to wchar_t type by Py_DecodeLocale() on > Unix, > -# we can use os.fsencode() to get back bytes argv. > -# > -# https://hg.python.org/cpython/file/v3.5.1/Programs/python.c#l55 > -# > -# On Windows, the native argv is unicode and is converte