Module: Mesa
Branch: master
Commit: ba452d43e0f5ee6ceec5da031f55904f8144472c
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ba452d43e0f5ee6ceec5da031f55904f8144472c
Author: Rob Clark <robcl...@freedesktop.org>
Date: Thu Jun 2 10:33:08 2016 -0400
freedreno: fix dereference before null check
ptr can actually never be null so just drop the check.
CID 1362464 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking ptr suggests that it may be null,
but it has already been dereferenced on all paths leading to the check.
Signed-off-by: Rob Clark <robcl...@freedesktop.org>
---
src/gallium/drivers/freedreno/freedreno_query_hw.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/freedreno/freedreno_query_hw.h
b/src/gallium/drivers/freedreno/freedreno_query_hw.h
index 8a5d114..095140e 100644
--- a/src/gallium/drivers/freedreno/freedreno_query_hw.h
+++ b/src/gallium/drivers/freedreno/freedreno_query_hw.h
@@ -163,8 +163,7 @@ fd_hw_sample_reference(struct fd_context *ctx,
if (pipe_reference(&(*ptr)->reference, &samp->reference))
__fd_hw_sample_destroy(ctx, old_samp);
- if (ptr)
- *ptr = samp;
+ *ptr = samp;
}
#endif /* FREEDRENO_QUERY_HW_H_ */
_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit
