Module: Mesa
Branch: master
Commit: c24d82696867da13360f23abecf130e839da8b0f
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c24d82696867da13360f23abecf130e839da8b0f
Author: Mathieu Bridon <boche...@daitauha.fr>
Date: Tue Jun 26 08:52:08 2018 +0200
python: Open file in binary mode
The XML parser wants byte strings, not unicode strings.
In both Python 2 and 3, opening a file without specifying the mode will
open it for reading in text mode ('r').
On Python 2, the read() method of the file object will return byte
strings, while on Python 3 it will return unicode strings.
Explicitly specifying the binary mode ('rb') makes the behaviour
identical in both Python 2 and 3, returning what the XML parser
expects.
Signed-off-by: Mathieu Bridon <boche...@daitauha.fr>
Reviewed-by: Eric Engestrom <eric.engest...@intel.com>
Reviewed-by: Dylan Baker <dy...@pnwbakers.com>
---
src/intel/genxml/gen_bits_header.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/genxml/gen_bits_header.py
b/src/intel/genxml/gen_bits_header.py
index e31e9ff103..dcd6ccb7d9 100644
--- a/src/intel/genxml/gen_bits_header.py
+++ b/src/intel/genxml/gen_bits_header.py
@@ -282,7 +282,7 @@ class XmlParser(object):
self.container = None
def parse(self, filename):
- with open(filename) as f:
+ with open(filename, 'rb') as f:
self.parser.ParseFile(f)
def start_element(self, name, attrs):
_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit
