Re: [Mesa-dev] r600g on rv635 and broken mipmaps

2011-05-03 Thread Dave Airlie
On Wed, May 4, 2011 at 5:05 AM, Fredrik Höglund wrote: > On Monday 02 May 2011, Alex Deucher wrote: >> One thing to double check is that rv6xx_context_surface_base_update() >> gets emitted properly every time a base address is emitted.  Right now >> I think we only call it once per command buffer,

Re: [Mesa-dev] [PATCH 09/11] mesa: add yet more context fields for GL_ARB_debug_output

2011-05-03 Thread Brian Paul
On 05/02/2011 05:01 PM, nobled wrote: --- src/mesa/main/mtypes.h | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 41f6470..d381719 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3194,6

Re: [Mesa-dev] [PATCH 06/11] mesa: add some GL_ARB_debug_output functions

2011-05-03 Thread Brian Paul
On 05/02/2011 05:00 PM, nobled wrote: They're not actually exported yet. --- src/mesa/main/api_exec.c | 12 ++- src/mesa/main/errors.c | 262 ++ src/mesa/main/errors.h |4 + 3 files changed, 274 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 05/11] mesa: add infrastructure for GL_ARB_debug_output

2011-05-03 Thread Brian Paul
On 05/02/2011 05:00 PM, nobled wrote: --- src/mesa/main/context.c|1 + src/mesa/main/enable.c |5 + src/mesa/main/errors.c | 10 ++ src/mesa/main/extensions.c |1 + src/mesa/main/get.c|7 +++ src/mesa/main/getstring.c |6 ++ s

Re: [Mesa-dev] [PATCH 07/11] mesa: add message-toggle booleans for GL_ARB_debug_output

2011-05-03 Thread Brian Paul
On 05/02/2011 05:00 PM, nobled wrote: --- src/mesa/main/errors.c |2 +- src/mesa/main/mtypes.h | 32 +++- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index c953fbf..9d74a05 100644 --- a/src/m

Re: [Mesa-dev] [PATCH 08/11] mesa: add glDebugMessageControlARB

2011-05-03 Thread Brian Paul
On 05/02/2011 05:00 PM, nobled wrote: Controlling the output of client-provided messages isn't done yet. --- src/mesa/main/errors.c | 110 1 files changed, 110 insertions(+), 0 deletions(-) Please put comments on all the new functions define

Re: [Mesa-dev] [PATCH 0/11] implement GL_ARB_debug_output

2011-05-03 Thread Brian Paul
On 05/02/2011 04:59 PM, nobled wrote: git repo: https://github.com/nobled/mesa.git (branch: arb_debug_output, rebased on bd661a933b18fccd7102d05932774ee61a90ec9e) web interface: https://github.com/nobled/mesa/commits/arb_debug_output spec: http://www.opengl.org/registry/specs/ARB/debug_output.t

Re: [Mesa-dev] [PATCH 2/2] gallium: implement seamless cubemap extensions

2011-05-03 Thread Marek Olšák
On Tue, May 3, 2011 at 9:31 PM, Brian Paul wrote: > On 05/03/2011 11:55 AM, Roland Scheidegger wrote: >> >> Am 03.05.2011 15:55, schrieb Marek Olšák: >>> >>> diff --git a/src/mesa/state_tracker/st_atom_rasterizer.c >>> b/src/mesa/state_tracker/st_atom_rasterizer.c >>> index 250cbb2..ac6d76a 100644

Re: [Mesa-dev] [PATCH 1/2] mesa: implement AMD_seamless_cubemap_per_texture

2011-05-03 Thread Marek Olšák
On Tue, May 3, 2011 at 11:21 PM, Brian Paul wrote: >  On 05/03/2011 01:24 PM, Brian Paul wrote: >> >> On 05/03/2011 07:55 AM, Marek Olšák wrote: >>> >>> --- >>>  src/mesa/main/extensions.c |    1 + >>>  src/mesa/main/mtypes.h     |    2 ++ >>>  src/mesa/main/texobj.c     |    2 ++ >>>  src/mesa/ma

Re: [Mesa-dev] [PATCH 1/2] mesa: implement AMD_seamless_cubemap_per_texture

2011-05-03 Thread Brian Paul
On 05/03/2011 01:24 PM, Brian Paul wrote: On 05/03/2011 07:55 AM, Marek Olšák wrote: --- src/mesa/main/extensions.c |1 + src/mesa/main/mtypes.h |2 ++ src/mesa/main/texobj.c |2 ++ src/mesa/main/texparam.c | 32 4 files changed, 37

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 14:15:30 -0700 Keith Packard wrote: > On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes > wrote: > > > Fixed version below. > > Reviewed-by: Keith Packard > > (assuming that the GLX protocol specification gets updated to match :-) Yeah, Ian is fixing up the padding there

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Keith Packard
On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes wrote: > Fixed version below. Reviewed-by: Keith Packard (assuming that the GLX protocol specification gets updated to match :-) -- keith.pack...@intel.com pgpmw6kAybqOk.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH] dri2proto: make DRI2 swap event match GLX spec

2011-05-03 Thread Jesse Barnes
Updated with explicit padding. -- Jesse Barnes, Intel Open Source Technology Center >From 0ca3778de195a82087d0f07415a1cf8fc94f5b0a Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Tue, 3 May 2011 12:14:58 -0700 Subject: [PATCH] dri2proto: make DRI2 swap event match GLX spec We only spec a 32

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 3 May 2011 14:02:31 -0700 Jesse Barnes wrote: > On Tue, 03 May 2011 13:54:38 -0700 > Keith Packard wrote: > > > On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes > > wrote: > > > > > We only spec a 32 bit swap count, so drop the high sbc field. > > > > You're missing the explicit 16-

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 13:54:38 -0700 Keith Packard wrote: > On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes > wrote: > > > We only spec a 32 bit swap count, so drop the high sbc field. > > You're missing the explicit 16-bit padding field after 'event_type' > > The documented encoding > http:/

Re: [Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Keith Packard
On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes wrote: > We only spec a 32 bit swap count, so drop the high sbc field. You're missing the explicit 16-bit padding field after 'event_type' The documented encoding http://www.opengl.org/registry/specs/INTEL/swap_event.txt needs to be fixed to mat

Re: [Mesa-dev] [PATCH 2/2] gallium: implement seamless cubemap extensions

2011-05-03 Thread Brian Paul
On 05/03/2011 11:55 AM, Roland Scheidegger wrote: Am 03.05.2011 15:55, schrieb Marek Olšák: diff --git a/src/mesa/state_tracker/st_atom_rasterizer.c b/src/mesa/state_tracker/st_atom_rasterizer.c index 250cbb2..ac6d76a 100644 --- a/src/mesa/state_tracker/st_atom_rasterizer.c +++ b/src/mesa/state

Re: [Mesa-dev] [PATCH 1/2] mesa: implement AMD_seamless_cubemap_per_texture

2011-05-03 Thread Brian Paul
On 05/03/2011 07:55 AM, Marek Olšák wrote: --- src/mesa/main/extensions.c |1 + src/mesa/main/mtypes.h |2 ++ src/mesa/main/texobj.c |2 ++ src/mesa/main/texparam.c | 32 4 files changed, 37 insertions(+), 0 deletions(-) diff --git a

Re: [Mesa-dev] Make swap event handling match the spec

2011-05-03 Thread Jesse Barnes
On Tue, 3 May 2011 12:21:23 -0700 Jesse Barnes wrote: > Ian reminded me that we changed the spec to fit within an XEvent, but we > never updated the code to match. This set of patches (much simpler than > the last) does just that. Wrapping support can be added to Mesa if we > really want 64 bi

[Mesa-dev] [PATCH 6/6] DRI2/GLX: make swap event handling match spec

2011-05-03 Thread Jesse Barnes
We only handle a 32 bit swap count, so use the new structure definitions. Signed-off-by: Jesse Barnes --- configure.ac |4 ++-- src/glx/dri2.c |2 +- src/glx/glxext.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 3b05ca3

[Mesa-dev] [PATCH 5/6] GLX: don't crash when indirect clients try to set an event mask

2011-05-03 Thread Jesse Barnes
After sending the GLXChangeDrawableAttributes request, we also set a local set of attributes on the DRI drawable. But in the indirect case this array won't be present, so skip the setting in that case to avoid a crash. Signed-off-by: Jesse Barnes --- src/glx/glx_pbuffer.c |3 +++ 1 files ch

[Mesa-dev] [PATCH] dri2proto: make DRI2 swap event match GLX spec

2011-05-03 Thread Jesse Barnes
We only spec a 32 bit sbc count, so drop the high bits. Signed-off-by: Jesse Barnes --- configure.ac |2 +- dri2proto.h |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 5b78d6b..9505f56 100644 --- a/configure.ac +++ b/configure.ac

[Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

2011-05-03 Thread Jesse Barnes
We only spec a 32 bit swap count, so drop the high sbc field. Signed-off-by: Jesse Barnes --- configure.ac |2 +- glxproto.h |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index d88e6df..a3047e4 100644 --- a/configure.ac +++ b/configu

[Mesa-dev] [PATCH 4/4] GLX/DRI2: make GLX swap event handling match spec

2011-05-03 Thread Jesse Barnes
Only send a 32 bit swap count out to the client. Signed-off-by: Jesse Barnes --- configure.ac |4 ++-- glx/glxdri2.c |5 ++--- hw/xfree86/dri2/dri2.c|2 +- hw/xfree86/dri2/dri2.h|2 +- hw/xfree86/dri2/dri2ext.c |5 ++--- 5 files changed, 8 ins

[Mesa-dev] [PATCH 3/4] GLX/DRI2: pass drawable correctly for indirect swap events

2011-05-03 Thread Jesse Barnes
Pass the right drawable pointer as data to the swap complete function. Signed-off-by: Jesse Barnes --- glx/glxdri2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index d979717..93c5e5b 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -2

[Mesa-dev] Make swap event handling match the spec

2011-05-03 Thread Jesse Barnes
Ian reminded me that we changed the spec to fit within an XEvent, but we never updated the code to match. This set of patches (much simpler than the last) does just that. Wrapping support can be added to Mesa if we really want 64 bit values, but that means checking the drawable sbc and adding whe

Re: [Mesa-dev] r600g on rv635 and broken mipmaps

2011-05-03 Thread Fredrik Höglund
On Monday 02 May 2011, Alex Deucher wrote: > One thing to double check is that rv6xx_context_surface_base_update() > gets emitted properly every time a base address is emitted. Right now > I think we only call it once per command buffer, but it needs to be > emitted every time a base address chang

Re: [Mesa-dev] [RFC] swap complete event handling fixes

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 11:38:26 -0700 Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 05/03/2011 10:59 AM, Jesse Barnes wrote: > > Ended up moving over to generic events since the GLX type code is part > > of the GLX namespace and larger than 8 bits. > > > > Apparently

Re: [Mesa-dev] [RFC] swap complete event handling fixes

2011-05-03 Thread Jesse Barnes
On Tue, 03 May 2011 11:38:26 -0700 Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 05/03/2011 10:59 AM, Jesse Barnes wrote: > > Ended up moving over to generic events since the GLX type code is part > > of the GLX namespace and larger than 8 bits. > > > > Apparently

Re: [Mesa-dev] [RFC] swap complete event handling fixes

2011-05-03 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2011 10:59 AM, Jesse Barnes wrote: > Ended up moving over to generic events since the GLX type code is part > of the GLX namespace and larger than 8 bits. > > Apparently no one had ever tried ChangeDrawableAttributes with indirect > clients,

[Mesa-dev] [PATCH] DRI2: fix swap complete event size by using a generic event

2011-05-03 Thread Jesse Barnes
The existing swap complete event is too large to fit in an XEvent, so use a generic event instead. New servers and clients can use this structure to fully pass the swap count along with the media stamp counter, swap complete type, and timestamp. Signed-off-by: Jesse Barnes --- configure.ac |

[Mesa-dev] [PATCH 8/8] GLX: support generic swap events

2011-05-03 Thread Jesse Barnes
Send the new generic GLX swap event if supported by the client. This means checking the client GLX version at swap complete time and constructing a new generic swap completion event at swap complete time. Signed-off-by: Jesse Barnes --- configure.ac|2 +- glx/glxdri2.c

[Mesa-dev] [PATCH 4/5] DRI2: support generic swap event handling

2011-05-03 Thread Jesse Barnes
The existing swap event structure is too large to fit in an XEvent, so new servers will send a generic event if the client supports it. This allows a valid swap count value to be sent along with the event type, timestamp, and media stamp. Check for server support based on the advertised DRI2 vers

[Mesa-dev] [PATCH 3/5] GLX: don't crash when indirect clients try to set an event mask

2011-05-03 Thread Jesse Barnes
After sending the GLXChangeDrawableAttributes request, we also set a local set of attributes on the DRI drawable. But in the indirect case this array won't be present, so skip the setting in that case to avoid a crash. Signed-off-by: Jesse Barnes --- src/glx/glx_pbuffer.c |3 +++ 1 files ch

[Mesa-dev] [PATCH 7/8] DRI2: support generic swap events

2011-05-03 Thread Jesse Barnes
Send the new generic swap event type if the client supports it. This means checking the client's DRI2 proto version at connect time and then constructing a new generic event at swap complete time. To track the client version, we need to add a new DRI2 client private type and track it for the life

[Mesa-dev] [PATCH 6/8] GLX/DRI2: pass drawable correctly for indirect swap events

2011-05-03 Thread Jesse Barnes
Pass the right drawable pointer as data to the swap complete function. Signed-off-by: Jesse Barnes --- glx/glxdri2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index d979717..93c5e5b 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -2

[Mesa-dev] [PATCH 5/5] GLX: support generic swap events

2011-05-03 Thread Jesse Barnes
The existing swap event structure is too big to fit in an XEvent, so support servers that send generic events instead. Do this by advertising the GLX proto version we support when connecting and check for generic events in the event stream. Convert any received events into regular swap complete e

[Mesa-dev] [PATCH] GLX: fix broken swap event size by using a generic event

2011-05-03 Thread Jesse Barnes
The existing event is too large for an XEvent meaning that the swap count is never sent to clients. Create a generic event instead for use by new clients & servers. Signed-off-by: Jesse Barnes --- configure.ac |2 +- glxproto.h | 18 ++ 2 files changed, 19 insertions(+),

[Mesa-dev] [RFC] swap complete event handling fixes

2011-05-03 Thread Jesse Barnes
Ended up moving over to generic events since the GLX type code is part of the GLX namespace and larger than 8 bits. Apparently no one had ever tried ChangeDrawableAttributes with indirect clients, because simply going a glXSelectEvent causes a crash in that case. So this patch set includes a fix

Re: [Mesa-dev] [PATCH 2/2] gallium: implement seamless cubemap extensions

2011-05-03 Thread Roland Scheidegger
Am 03.05.2011 15:55, schrieb Marek Olšák: > diff --git a/src/mesa/state_tracker/st_atom_rasterizer.c > b/src/mesa/state_tracker/st_atom_rasterizer.c > index 250cbb2..ac6d76a 100644 > --- a/src/mesa/state_tracker/st_atom_rasterizer.c > +++ b/src/mesa/state_tracker/st_atom_rasterizer.c > @@ -257,6 +

Re: [Mesa-dev] [PATCH 0/2] Seamless cube map in Gallium and the AMD extension

2011-05-03 Thread Roland Scheidegger
Am 03.05.2011 15:55, schrieb Marek Olšák: > Hi, > > the first patch adds AMD_seamless_cubemap_per_texture to Mesa. > > The second patch adds support for both seamless_cube_map extensions to > Gallium. The motivation for this particular implementation is to make driver > code as simple as possib

Re: [Mesa-dev] [PATCH] st/xorg: flush after loading the cursor

2011-05-03 Thread Michel Dänzer
On Die, 2011-05-03 at 11:45 +0200, Marcin Slusarz wrote: > On Tue, May 03, 2011 at 09:40:55AM +0200, Michel Dänzer wrote: > > On Mon, 2011-05-02 at 21:26 +0200, Marcin Slusarz wrote: > > > On Mon, May 02, 2011 at 08:57:25AM +0200, Michel Dänzer wrote: > > > > On Mon, 2011-05-02 at 00:01 +0200, Ma

Re: [Mesa-dev] r600g on rv635 and broken mipmaps

2011-05-03 Thread Alex Deucher
2011/5/3 Mathias Fröhlich : > > Marek, > > On Tuesday, May 03, 2011 01:33:17 you wrote: >> 2011/5/2 Mathias Fröhlich : >> > I have again spent some more tries with different kinds of flushes on the >> > rv635. What helps for the mipmap problem here is emitting a >> > texture_barrier as well as flus

[Mesa-dev] [PATCH 2/2] gallium: implement seamless cubemap extensions

2011-05-03 Thread Marek Olšák
--- src/gallium/include/pipe/p_defines.h|2 ++ src/gallium/include/pipe/p_state.h |2 ++ src/mesa/state_tracker/st_atom_rasterizer.c |6 +- src/mesa/state_tracker/st_atom_sampler.c|3 +++ src/mesa/state_tracker/st_extensions.c |9 + 5 files

[Mesa-dev] [PATCH 1/2] mesa: implement AMD_seamless_cubemap_per_texture

2011-05-03 Thread Marek Olšák
--- src/mesa/main/extensions.c |1 + src/mesa/main/mtypes.h |2 ++ src/mesa/main/texobj.c |2 ++ src/mesa/main/texparam.c | 32 4 files changed, 37 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extens

[Mesa-dev] [PATCH 0/2] Seamless cube map in Gallium and the AMD extension

2011-05-03 Thread Marek Olšák
Hi, the first patch adds AMD_seamless_cubemap_per_texture to Mesa. The second patch adds support for both seamless_cube_map extensions to Gallium. The motivation for this particular implementation is to make driver code as simple as possible. A Gallium driver can support either of these two CA

[Mesa-dev] [Bug 36792] New: [PATCH] link to shared LLVM library

2011-05-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=36792 Summary: [PATCH] link to shared LLVM library Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Severity: normal Priority: medium Compone

Re: [Mesa-dev] [PATCH] gallium/xorg st/nv50/i915: add PIPE_BIND_CURSOR

2011-05-03 Thread Daniel Vetter
On Mon, May 2, 2011 at 8:40 PM, Marcin Slusarz wrote: > On Mon, May 02, 2011 at 03:11:00PM +0200, Daniel Vetter wrote: >> On Mon, May 2, 2011 at 2:56 PM, Benjamin Franzke >> wrote: >> > I think in i915g the CURSOR flag should be used in i9x5_scanout_layout >> > for the "special case for cursors"

Re: [Mesa-dev] [PATCH] st/xorg: flush after loading the cursor

2011-05-03 Thread Marcin Slusarz
On Tue, May 03, 2011 at 09:40:55AM +0200, Michel Dänzer wrote: > On Mon, 2011-05-02 at 21:26 +0200, Marcin Slusarz wrote: > > On Mon, May 02, 2011 at 08:57:25AM +0200, Michel Dänzer wrote: > > > On Mon, 2011-05-02 at 00:01 +0200, Marcin Slusarz wrote: > > > > We need cursor data to land in destin

Re: [Mesa-dev] r600g on rv635 and broken mipmaps

2011-05-03 Thread Marek Olšák
2011/5/3 Mathias Fröhlich : > Correct me when I am wrong: > In u_gen_mipmap, we call cso_set_framebuffer, which I expect to be aequivalent > to switching rendering outputs to a different fbo. When I do the aequivalent > from OpenGL level, I expect to have everything available from the previous > bo

Re: [Mesa-dev] [PATCH] st/xorg: flush after loading the cursor

2011-05-03 Thread Michel Dänzer
On Mon, 2011-05-02 at 21:26 +0200, Marcin Slusarz wrote: > On Mon, May 02, 2011 at 08:57:25AM +0200, Michel Dänzer wrote: > > On Mon, 2011-05-02 at 00:01 +0200, Marcin Slusarz wrote: > > > We need cursor data to land in destination buffer before drmModeSetCursor. > > > It fixes "cursor lag" at le