Re: [Mesa-dev] [PATCH] i965: fix mask used to write to clip distance registers when gen>6

2011-06-13 Thread Eric Anholt
On Mon, 13 Jun 2011 11:30:56 -0700, Paul Berry wrote: > On 13 June 2011 09:58, Eric Anholt wrote: > > On Sun, 12 Jun 2011 21:14:50 -0700, Paul Berry > > wrote: > >> In gen6 and above, clip distances 0-3 are written to message register > >> 3's xyzw components, and 4-7 to message register 4's xy

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-13 Thread Eric Anholt
On Mon, 13 Jun 2011 12:09:04 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > Previously it was up to the driver or later code generator to reject > these shaders. It turns out that nobody did this. > > This will need changes to support geometry shaders. > > NOTE: This is a candidate for

[Mesa-dev] [Bug 38085] Mesa: User error: GL_INVALID_ENUM in glTexParameter(param=0x2901)

2011-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38085 --- Comment #7 from Alexandre Demers 2011-06-13 17:26:28 PDT --- (In reply to comment #6) > It's best to ssh in from another computer and do your debugging from there. That will be a problem, since my netbook was stolen a couple of months ago.

[Mesa-dev] Mesa 7.10.3 release

2011-06-13 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mesa 7.10.3 has been released. This is a stable release containing bug fixes since the 7.10.2 release. The tag in the GIT repository for Mesa 7.10.3 is 'mesa-7.10.3'. Mesa 7.10.3 is available for download at ftp://freedesktop.org/pub/mesa/7.10.3/ m

[Mesa-dev] [PATCH] st/mesa: improved is_interleaved_arrays() checking

2011-06-13 Thread Brian Paul
Check that the difference in array pointers/offsets from the 0th array are less than the stride, for both VBOs and user-space arrays. Previously, we were only doing this for the later. This tightens up the interleaved array test and fixes a problem with the llvmpipe driver where we were creating w

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Brian Paul
On 06/13/2011 03:53 PM, Jeremy Huddleston wrote: b44d13e67bfe81b2d7af4aeda2c3caf7f252bd0f should work for you. Thanks for letting me know. Another warning: glapi_gentable.c: In function ‘_glapi_create_table_from_handle’: glapi_gentable.c:54:9: warning: ISO C90 forbids mixed declarations and

[Mesa-dev] [PATCH] glx: Bind to our context before __glXSetCurrentContext

2011-06-13 Thread Jeremy Huddleston
We want to bind to our context before calling __glXSetCurrentContext or messing with the gc rect in order to properly handle error conditions. Signed-off-by: Jeremy Huddleston --- src/glx/glxcurrent.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Jeremy Huddleston
b44d13e67bfe81b2d7af4aeda2c3caf7f252bd0f should work for you. Thanks for letting me know. --Jeremy On Jun 13, 2011, at 2:27 PM, Brian Paul wrote: > On 06/13/2011 02:05 PM, Jeremy Huddleston wrote: >> Hi Brian, >> >> Does this get rid of your warnings? (you'll need to regenerate the >> glapi_

Re: [Mesa-dev] Status of VDPAU and XvMC state-trackers (was Re: Build error on current xvmc-r600 pipe-video)

2011-06-13 Thread Younes Manton
On Mon, Jun 13, 2011 at 3:23 PM, Jose Fonseca wrote: > > - Original Message - >> Am 05.06.2011 06:31, schrieb Younes Manton: >> > 2011/6/4 Jose Fonseca : >> >> At very least there are ovious things that need to be fixed: >> >> >> >> - get_param / is_format_supported should not be duplicate

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Jeremy Huddleston
Alright... looks like it needs the cast. Thanks. On Jun 13, 2011, at 2:27 PM, Brian Paul wrote: > On 06/13/2011 02:05 PM, Jeremy Huddleston wrote: >> Hi Brian, >> >> Does this get rid of your warnings? (you'll need to regenerate the >> glapi_gentable.c) >> > > Getting a different warning now

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Brian Paul
On 06/13/2011 02:05 PM, Jeremy Huddleston wrote: Hi Brian, Does this get rid of your warnings? (you'll need to regenerate the glapi_gentable.c) Getting a different warning now: glapi_gentable.c: In function ‘_glapi_create_table_from_handle’: glapi_gentable.c:54:24: warning: ISO C forbids as

Re: [Mesa-dev] Status of VDPAU and XvMC state-trackers (was Re: Build error on current xvmc-r600 pipe-video)

2011-06-13 Thread Younes Manton
On Mon, Jun 6, 2011 at 12:52 PM, Roland Scheidegger wrote: > Am 05.06.2011 06:31, schrieb Younes Manton: >> 2011/6/4 Jose Fonseca : >>> At very least there are ovious things that need to be fixed: >>> >>> - get_param / is_format_supported should not be duplicated from screen. >> >> This is also de

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Jeremy Huddleston
Hi Brian, Does this get rid of your warnings? (you'll need to regenerate the glapi_gentable.c) diff --git a/src/mapi/glapi/gen/gl_gentable.py b/src/mapi/glapi/gen/gl_gentable.py index 0dfebf8..1681a80 100644 --- a/src/mapi/glapi/gen/gl_gentable.py +++ b/src/mapi/glapi/gen/gl_gentable.py @@ -42,

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-13 Thread Tilman Sauerbeck
Ian Romanick [2011-06-13 12:09]: > [...] > + } else if (var->type->is_matrix()) { > + varying_vectors += var->type->matrix_columns; > + float_components += var->type->matrix_columns * 4; > + } else { > + varying_vectors++; > + float_components += var->type

Re: [Mesa-dev] Status of VDPAU and XvMC state-trackers (was Re: Build error on current xvmc-r600 pipe-video)

2011-06-13 Thread Jose Fonseca
- Original Message - > Am 05.06.2011 06:31, schrieb Younes Manton: > > 2011/6/4 Jose Fonseca : > >> At very least there are ovious things that need to be fixed: > >> > >> - get_param / is_format_supported should not be duplicated from > >> screen. > > > > This is also deliberate. > > Pa

[Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

2011-06-13 Thread Ian Romanick
From: Ian Romanick Previously it was up to the driver or later code generator to reject these shaders. It turns out that nobody did this. This will need changes to support geometry shaders. NOTE: This is a candidate for the stable branches. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?

Re: [Mesa-dev] [PATCH] i965: fix mask used to write to clip distance registers when gen>6

2011-06-13 Thread Paul Berry
On 13 June 2011 09:58, Eric Anholt wrote: > On Sun, 12 Jun 2011 21:14:50 -0700, Paul Berry > wrote: >> In gen6 and above, clip distances 0-3 are written to message register >> 3's xyzw components, and 4-7 to message register 4's xyzw components. >> Therefore when when writing the clip distances

Re: [Mesa-dev] [PATCH] llvmpipe: SSE2 fastpaths for b8g8r8x8 {un, }swizzle

2011-06-13 Thread Jose Fonseca
Good catch! Jose - Original Message - > Copy-and-paste from the bgra cases. The C paths attempt to avoid > copying the 'x' channel, but it's harmless, you might as well. Good > for > about 5% in glxgears (740 to 780 fps). > > Signed-off-by: Adam Jackson > --- > src/gallium/drivers/ll

[Mesa-dev] [PATCH] glx: Alias glXFreeContextEXT to glXDestroyContext

2011-06-13 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 20 ++-- 1 files changed, 6 insertions(+), 14 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index ab6b61a..e4356dd 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -354,8 +354,9 @@ glx_send_destroy_c

Re: [Mesa-dev] [PATCH 2/4] intel: Clean up intel_render_texture with a rename and a helper function.

2011-06-13 Thread Chad Versace
On Fri, 10 Jun 2011 13:56:44 -0700, Eric Anholt wrote: > On Fri, 10 Jun 2011 12:58:12 -0700, Kenneth Graunke > wrote: > > On 06/07/2011 11:47 AM, Eric Anholt wrote: > > > The "newImage" isn't particularly new -- it might be the same texture > > > that was attached to the same attachment point be

Re: [Mesa-dev] [PATCH 4/4] intel: Do the drawable x/y offset in intel_renderbuffer_map() for spans.

2011-06-13 Thread Chad Versace
On Tue, 7 Jun 2011 11:47:14 -0700, Eric Anholt wrote: > We were mapping the renderbuffer once, then walking over all the > buffers to map just the texture ones using the other texture mapping > function that handled the x/y offset to the image in the region. But > then we would go and overwrite

Re: [Mesa-dev] [PATCH 1/4] intel: Move the draw_x/draw_y to the renderbuffer where it belongs.

2011-06-13 Thread Chad Versace
On Tue, 7 Jun 2011 11:47:11 -0700, Eric Anholt wrote: > It was originally located in the region because the tracking of > depth/color buffers was on the regions, and getting back to the irb > would have been tricky. Now, we're keying off of the renderbuffer in > more places, which means we can m

Re: [Mesa-dev] [PATCH 3/4] intel: Use rb->Data and rb->RowStride to handle spans Y flipping.

2011-06-13 Thread Chad Versace
On Tue, 7 Jun 2011 11:47:13 -0700, Eric Anholt wrote: > This is already pointing at 0 or Height - 1 and with an appropriate > pitch, so no need to recompute those values per customization of the > spans code. Cuts 3 out of 21kb of the compiled size. > --- > src/mesa/drivers/dri/intel/intel_span

Re: [Mesa-dev] [PATCH 2/4] intel: Clean up intel_render_texture with a rename and a helper function.

2011-06-13 Thread Chad Versace
On Tue, 7 Jun 2011 11:47:12 -0700, Eric Anholt wrote: > The "newImage" isn't particularly new -- it might be the same texture > that was attached to the same attachment point before. This function > also gets called when just rebinding back to an FBO with a texture > attachment. > --- > src/mes

[Mesa-dev] [PATCH] llvmpipe: SSE2 fastpaths for b8g8r8x8 {un, }swizzle

2011-06-13 Thread Adam Jackson
Copy-and-paste from the bgra cases. The C paths attempt to avoid copying the 'x' channel, but it's harmless, you might as well. Good for about 5% in glxgears (740 to 780 fps). Signed-off-by: Adam Jackson --- src/gallium/drivers/llvmpipe/lp_tile_soa.py | 68 ++- 1 file

Re: [Mesa-dev] [PATCH] mesa: move texrender.c to swrast

2011-06-13 Thread Brian Paul
On 06/13/2011 10:59 AM, Eric Anholt wrote: On Fri, 10 Jun 2011 20:37:21 -0600, Brian Paul wrote: This stuff is really for software rendering, it's not core Mesa. A small step toward pushing the FetchTexel() stuff down into swrast. Reviewed-by: Eric Anholt Do we feel the same about the other

Re: [Mesa-dev] [PATCH 4/4] intel: Do the drawable x/y offset in intel_renderbuffer_map() for spans.

2011-06-13 Thread Eric Anholt
On Sun, 12 Jun 2011 22:36:04 -0700, Chad Versace wrote: > On Tue, 7 Jun 2011 11:47:14 -0700, Eric Anholt wrote: > > We were mapping the renderbuffer once, then walking over all the > > buffers to map just the texture ones using the other texture mapping > > function that handled the x/y offset t

Re: [Mesa-dev] [PATCH] mesa: move texrender.c to swrast

2011-06-13 Thread Eric Anholt
On Fri, 10 Jun 2011 20:37:21 -0600, Brian Paul wrote: > This stuff is really for software rendering, it's not core Mesa. > A small step toward pushing the FetchTexel() stuff down into swrast. Reviewed-by: Eric Anholt Do we feel the same about the other renderbuffer accessors? pgpv5kaTt2V5E.pg

Re: [Mesa-dev] [PATCH 3/4] intel: Use rb->Data and rb->RowStride to handle spans Y flipping.

2011-06-13 Thread Eric Anholt
On Sun, 12 Jun 2011 22:28:08 -0700, Chad Versace wrote: > On Tue, 7 Jun 2011 11:47:13 -0700, Eric Anholt wrote: > > This is already pointing at 0 or Height - 1 and with an appropriate > > pitch, so no need to recompute those values per customization of the > > spans code. Cuts 3 out of 21kb of

Re: [Mesa-dev] [PATCH 10/11] intel: Drop dead preinitialization of align_w, align_h.

2011-06-13 Thread Eric Anholt
On Fri, 10 Jun 2011 18:10:13 -0700, Ian Romanick wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/10/2011 01:38 PM, Eric Anholt wrote: > > --- > > src/mesa/drivers/dri/intel/intel_tex_layout.c |4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

Re: [Mesa-dev] [PATCH] i965: fix mask used to write to clip distance registers when gen>6

2011-06-13 Thread Eric Anholt
On Sun, 12 Jun 2011 21:14:50 -0700, Paul Berry wrote: > In gen6 and above, clip distances 0-3 are written to message register > 3's xyzw components, and 4-7 to message register 4's xyzw components. > Therefore when when writing the clip distances we need to examine the > lower 2 bits of the clip d

Re: [Mesa-dev] [PATCH] glxinfo: add support for creating/querying core-profile contexts

2011-06-13 Thread Gustaw Smolarczyk
2011/6/13 Brian Paul : > On 06/12/2011 12:56 PM, Gustaw Smolarczyk wrote: >> >> I found some bugs in this code. >> >> 2011/6/11 Brian Paul: >>> >>> The -c flag says to try to create a core profile (no legacy features) >>> using glXCreateContextAttribsARB().  A core profile may advertise a >>> diffe

Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-13 Thread Alex Deucher
2011/6/12 Mathias Fröhlich : > > Hi, > > attached is a set of patches to r600g. > > 0001-r600g-Fix-typo.patch: > Fix a more or less obvious typo in shader initialization setup. > > 0002-r600g-Set-the-domains-value-also-for-recycled-buffer.patch: > Makes sure that buffer objects from the userspace b

Re: [Mesa-dev] Mesa (master): glapi: Add API that can create a _glapi_table from a dlfcn handle

2011-06-13 Thread Brian Paul
On 06/11/2011 11:18 PM, Jeremy Huddleston wrote: Module: Mesa Branch: master Commit: 85937f4c0d4a78d3a11e3c1fa6148640f2a9ad7b URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=85937f4c0d4a78d3a11e3c1fa6148640f2a9ad7b Author: Jeremy Huddleston Date: Thu Jun 9 16:59:49 2011 -0700 glap

[Mesa-dev] [Bug 38210] Mesa git write access

2011-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38210 Brian Paul changed: What|Removed |Added Product|Mesa|freedesktop.org Component|Other

Re: [Mesa-dev] [PATCH] st/mesa: rebind vertex arrays if _NEW_BUFFER_OBJECT is dirty

2011-06-13 Thread Brian Paul
On 06/12/2011 03:29 PM, Marek Olšák wrote: This fixes piglit/vbo-bufferdata. It's a regression in 7.11. --- src/mesa/state_tracker/st_draw.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index 5695

Re: [Mesa-dev] mesa compressed mipmap generation

2011-06-13 Thread Brian Paul
On 06/10/2011 02:42 PM, Eric Anholt wrote: Here's my series to finally fix compressed mipmap generation on hw drivers. Take a look at the last commit in particular -- I'd love to do TexImage in the uncompressed path as well so we could get rid of that awful code for handling this non-TexImage up

Re: [Mesa-dev] [PATCH] glxinfo: add support for creating/querying core-profile contexts

2011-06-13 Thread Brian Paul
On 06/12/2011 12:56 PM, Gustaw Smolarczyk wrote: I found some bugs in this code. 2011/6/11 Brian Paul: The -c flag says to try to create a core profile (no legacy features) using glXCreateContextAttribsARB(). A core profile may advertise a different set of extensions than a compatibility profi