Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-08 Thread Marek Olšák
2011/9/7 Roland Scheidegger srol...@vmware.com: That said I'm not really sure why pipe_sampler_view and pipe_surface actually have a context pointer in them, since they are only supposed to be used with the context in which they were created I think those shouldn't actually exist -

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Benjamin Franzke
First thanks for taking this on. There are some things I'd like to have addtionally/differently: Supported shm formats are exposed via a format event as well (like the supported drm formats), so the config creation logic is the same for drm and shm, and I think it can remain in native_wayland.c

Re: [Mesa-dev] [PATCH 5/5] st/egl: add premultiplied alpha support to wayland

2011-09-08 Thread Benjamin Franzke
2011/9/8 Chia-I Wu olva...@gmail.com: From: Chia-I Wu o...@lunarg.com Return true for NATIVE_PARAM_PREMULTIPLIED_ALPHA when all formats with alpha support premultiplied alpha.  Currently, it means when argb32 and argb32_pre are both supported. ---  

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: First thanks for taking this on. There are some things I'd like to have addtionally/differently: Supported shm formats are exposed via a format event as well (like the supported drm formats), so the config

Re: [Mesa-dev] [PATCH 5/5] st/egl: add premultiplied alpha support to wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:13 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: 2011/9/8 Chia-I Wu olva...@gmail.com: From: Chia-I Wu o...@lunarg.com Return true for NATIVE_PARAM_PREMULTIPLIED_ALPHA when all formats with alpha support premultiplied alpha.  Currently, it means when

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:41 PM, Chia-I Wu olva...@gmail.com wrote: On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: First thanks for taking this on. There are some things I'd like to have addtionally/differently: Supported shm formats are exposed via a

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Benjamin Franzke
2011/9/8 Chia-I Wu olva...@gmail.com: On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: First thanks for taking this on. There are some things I'd like to have addtionally/differently: Supported shm formats are exposed via a format event as well (like

Re: [Mesa-dev] [PATCH 5/5] st/egl: add premultiplied alpha support to wayland

2011-09-08 Thread Benjamin Franzke
2011/9/8 Chia-I Wu olva...@gmail.com: On Thu, Sep 8, 2011 at 3:13 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: 2011/9/8 Chia-I Wu olva...@gmail.com: From: Chia-I Wu o...@lunarg.com Return true for NATIVE_PARAM_PREMULTIPLIED_ALPHA when all formats with alpha support

Re: [Mesa-dev] [PATCH 4/5] st/egl: correctly return configs under wayland

2011-09-08 Thread Chia-I Wu
On Thu, Sep 8, 2011 at 3:53 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: 2011/9/8 Chia-I Wu olva...@gmail.com: On Thu, Sep 8, 2011 at 3:11 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: First thanks for taking this on. There are some things I'd like to have

[Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Yuanhan Liu
If user call glTexImage1D with width = 0 and height = 0(the last level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart, 0, 0, format, type, pixel) It would generate a SIGSEGV fault. As i945_miptree_layout_2d didn't handle this special case. More info are commented in line in this

Re: [Mesa-dev] [RFC] [PATCH 2/2] i965: setup the edge flag enable bit in VE on SNB+

2011-09-08 Thread Eric Anholt
On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu yuanhan@linux.intel.com wrote: This patch is just for RFC, as I am not sure it's the right way to setup the edge flag enable bit in Vertex Element struture. Setting up this bit, according to Bspec, need do: 1. Edge flags are supported for

Re: [Mesa-dev] State tracker pipe_surface woes...

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 09:08, schrieb Marek Olšák: 2011/9/7 Roland Scheidegger srol...@vmware.com: That said I'm not really sure why pipe_sampler_view and pipe_surface actually have a context pointer in them, since they are only supposed to be used with the context in which they were created I think

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian Romanick ian.d.roman...@intel.com Core Mesa already does the dispatch offset remapping for every function that could possibly ever be

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Eric Anholt
On Thu, 08 Sep 2011 10:53:45 -0700, Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/06/2011 03:21 PM, Roland Scheidegger wrote: EXT_blend_equation_separate allows some unholy combinations which the r200 (possibly other hw too) can't handle

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 19:59, schrieb Eric Anholt: On Thu, 08 Sep 2011 10:53:45 -0700, Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/06/2011 03:21 PM, Roland Scheidegger wrote: EXT_blend_equation_separate allows some unholy combinations which the r200

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 19:53, schrieb Ian Romanick: On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian Romanick ian.d.roman...@intel.com Core Mesa already does the dispatch offset remapping for every function that could possibly ever be supported.

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 21:03, schrieb Roland Scheidegger: Am 08.09.2011 19:53, schrieb Ian Romanick: On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian Romanick ian.d.roman...@intel.com Core Mesa already does the dispatch offset remapping for every

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2011 12:18 PM, Roland Scheidegger wrote: Am 08.09.2011 21:03, schrieb Roland Scheidegger: Am 08.09.2011 19:53, schrieb Ian Romanick: On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian

Re: [Mesa-dev] [PATCH] glsl: Clarify error message about whole-array assignment in GLSL 1.10.

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/07/2011 12:51 PM, Eric Anholt wrote: Previously, it would produce: Failed to compile FS: 0:6(7): error: non-lvalue in assignment and now it produces: Failed to compile FS: 0:5(7): error: whole array assignment is not allowed in GLSL

Re: [Mesa-dev] [PATCH 03/20] intel: Silence many intel_batchbuffer.h:97:39: warning: comparison between signed and unsigned integer expressions

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:53 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/intel/intel_batchbuffer.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 04/20] intel: Silence several warning: unused parameter

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:54 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/intel/intel_buffer_objects.c | 47 ++--- 1 files changed, 31 insertions(+), 16 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 06/20] intel: Silence warning: unused parameter ‘fb’

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:56 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The gl_framebuffer was not used in intel_draw_buffer, so remove it. Reviewed-by: Eric Anholt e...@anholt.net pgpon7SjIctA3.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH 08/20] intel: Silence warning: unused parameter ‘target’

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:58 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The GLenum target parameter was not used in intel_copy_texsubimage, so remove it. We should also stop having all 3 callers look up the internalFormat from the

Re: [Mesa-dev] [PATCH 09/20] intel: Silence warning: unused parameter ‘depth0’

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:58:59 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The depth0 parameter was not used in intel_miptree_create_for_region, so remove it. All of the places that call this function, pass 1 for that parameter, and the place

Re: [Mesa-dev] [PATCH 10/20] intel: Silence several warning: unused parameter

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:59:00 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The internalFormat, format, and type parameters were not used by either try_pbo_upload or try_pbo_zcopy, so remove them. The width parameter was also not used by

Re: [Mesa-dev] [PATCH 12/20] intel: Silence intel/intel_fbo.h:105:4: warning: comparison of unsigned expression 0 is always false

2011-09-08 Thread Eric Anholt
On Mon, 29 Aug 2011 14:59:02 -0700, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com The test was of an enum, attIndex, which should be unsigned. The explicit check for 0 was replaced with a cast to unsigned in an assertion that attIndex is less than the

Re: [Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2011 03:16 AM, Yuanhan Liu wrote: If user call glTexImage1D with width = 0 and height = 0(the last level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart, 0, 0, format, type, pixel) It would generate a SIGSEGV fault. As

Re: [Mesa-dev] New VS by default.

2011-09-08 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/07/2011 01:03 PM, Eric Anholt wrote: With the core GLSL fixups I just sent out plus this patch series, I think it's ready to turn on by default. piglit is non-regressing, and the oglconform I've tested is overall better (but not perfect),

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Eric Anholt
On Thu, 08 Sep 2011 20:13:45 +0200, Roland Scheidegger srol...@vmware.com wrote: Am 08.09.2011 19:59, schrieb Eric Anholt: On Thu, 08 Sep 2011 10:53:45 -0700, Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/06/2011 03:21 PM, Roland

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Marek Olšák
On Thu, Sep 8, 2011 at 9:03 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.09.2011 19:53, schrieb Ian Romanick: On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian Romanick ian.d.roman...@intel.com Core Mesa already does the dispatch

Re: [Mesa-dev] New VS by default.

2011-09-08 Thread Kenneth Graunke
On 09/07/2011 01:03 PM, Eric Anholt wrote: With the core GLSL fixups I just sent out plus this patch series, I think it's ready to turn on by default. piglit is non-regressing, and the oglconform I've tested is overall better (but not perfect), and I think it will fix one actual bug report.

[Mesa-dev] [PATCH 0/3] i965 texelFetch/TXF support

2011-09-08 Thread Kenneth Graunke
These patches implement texelFetch/TXF via the ld sampler message on all i965 platforms. I've tested it on Broadwater, Cantiga, Sandybridge, and Ivybridge. Pretty sure I tested on Ironlake too, but a while ago. Piglit tests fs-texelFetch-2D and fs-texelFetchOffset-2D pass now. Huge thanks to

[Mesa-dev] [PATCH 1/3] i965/fs: Implement texelFetch() on Ironlake and Sandybridge.

2011-09-08 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_defines.h |2 ++ src/mesa/drivers/dri/i965/brw_fs.cpp |1 + src/mesa/drivers/dri/i965/brw_fs.h |1 + src/mesa/drivers/dri/i965/brw_fs_emit.cpp|4

[Mesa-dev] [PATCH 2/3] i965/fs: Implement texelFetch() on Ivybridge.

2011-09-08 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp index

[Mesa-dev] [PATCH 3/3] i965/fs: Implement texelFetch() on Gen4.

2011-09-08 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_emit.cpp|5 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 15 +++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp

[Mesa-dev] [Bug 40729] New: d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 Summary: d3d1x build error: any interface changes lately? Product: Mesa Version: git Platform: All OS/Version: All Status: NEW Severity: major Priority: medium

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 23:13, schrieb Marek Olšák: On Thu, Sep 8, 2011 at 9:03 PM, Roland Scheidegger srol...@vmware.com wrote: Am 08.09.2011 19:53, schrieb Ian Romanick: On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian Romanick

Re: [Mesa-dev] [PATCH 4/9] r200: Enable extensions by just setting the flags

2011-09-08 Thread Roland Scheidegger
Am 08.09.2011 21:43, schrieb Ian Romanick: On 09/08/2011 12:18 PM, Roland Scheidegger wrote: Am 08.09.2011 21:03, schrieb Roland Scheidegger: Am 08.09.2011 19:53, schrieb Ian Romanick: On 09/06/2011 03:21 PM, Roland Scheidegger wrote: Am 06.09.2011 22:13, schrieb Ian Romanick: From: Ian

Re: [Mesa-dev] [PATCH] glsl: Clarify error message about whole-array assignment in GLSL 1.10.

2011-09-08 Thread Eric Anholt
On Thu, 08 Sep 2011 12:57:31 -0700, Ian Romanick i...@freedesktop.org wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/07/2011 12:51 PM, Eric Anholt wrote: Previously, it would produce: Failed to compile FS: 0:6(7): error: non-lvalue in assignment and now it produces:

Re: [Mesa-dev] [PATCH] intel: fix null 1D texture handling

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 01:16:23PM -0700, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/08/2011 03:16 AM, Yuanhan Liu wrote: If user call glTexImage1D with width = 0 and height = 0(the last level) like this: glTexImage1D(GL_TEXTURE_1D, level, interfomart, 0, 0,

[Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
There is already comments show how to detect a null texture. Fix the code to match the comments. This would fix the oglc divzero(basic.texQOrWEqualsZero) and divzero(basic.texTrivialPrim) test case fail. Signed-off-by: Yuanhan Liu yuanhan@linux.intel.com ---

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #1 from Chia-I Wu olva...@gmail.com 2011-09-08 21:01:08 PDT --- Created an attachment (id=50992) View: https://bugs.freedesktop.org/attachment.cgi?id=50992 Review: https://bugs.freedesktop.org/review?bug=40729attachment=50992 fix

[Mesa-dev] [PATCH] intel: Remove pointless boolean return value from *_miptree_layout.

2011-09-08 Thread Kenneth Graunke
i915_miptree_layout, i945_miptree_layout, and brw_miptree_layout always just return GL_TRUE, so there's really no point to it. Change them to void functions and remove the (dead) error checking code. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

Re: [Mesa-dev] [RFC] [PATCH 2/2] i965: setup the edge flag enable bit in VE on SNB+

2011-09-08 Thread Kenneth Graunke
On 09/08/2011 06:59 PM, Yuanhan Liu wrote: On Thu, Sep 08, 2011 at 08:39:46AM -0700, Eric Anholt wrote: On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu yuanhan@linux.intel.com wrote: BTW, this patch fix the oglc pntrast fail on SNB(haven't tested it on IVB yet). Could you include a

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #2 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-09-08 21:41:56 PDT --- Not quite yet: g++ -c -I. -I../../../../../src/gallium/include -I../../../../../src/gallium/auxiliary -I../../../../../src/gallium/drivers

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #4 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-09-08 22:03:17 PDT --- (In reply to comment #3) (In reply to comment #2) src/dxgi_native.cpp: In member function ‘virtual HRESULT GalliumDXGISwapChain::Present(UINT,

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
On Fri, Sep 09, 2011 at 10:56:36AM +0800, Yuanhan Liu wrote: There is already comments show how to detect a null texture. Fix the code to match the comments. This would fix the oglc divzero(basic.texQOrWEqualsZero) and divzero(basic.texTrivialPrim) test case fail. Signed-off-by: Yuanhan

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #5 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-09-08 22:10:52 PDT --- OK, I think I got it working. You must have meant to replace pipe by native at line 1109. Doing this fixed your patch and allowed me to build without

[Mesa-dev] [Bug 40729] d3d1x build error: any interface changes lately?

2011-09-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=40729 --- Comment #6 from Alexandre Demers alexandre.f.dem...@gmail.com 2011-09-08 22:13:10 PDT --- Review of attachment 50992: -- (https://bugs.freedesktop.org/review?bug=40729attachment=50992) Need to replace struct pipe_present_control ctrl; by

Re: [Mesa-dev] [PATCH] intel: fix the wrong code to detect null texture.

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 09:12:44PM -0700, Kenneth Graunke wrote: On 09/08/2011 07:56 PM, Yuanhan Liu wrote: There is already comments show how to detect a null texture. Fix the code to match the comments. This would fix the oglc divzero(basic.texQOrWEqualsZero) and

Re: [Mesa-dev] [RFC] [PATCH 2/2] i965: setup the edge flag enable bit in VE on SNB+

2011-09-08 Thread Yuanhan Liu
On Thu, Sep 08, 2011 at 09:25:30PM -0700, Kenneth Graunke wrote: On 09/08/2011 06:59 PM, Yuanhan Liu wrote: On Thu, Sep 08, 2011 at 08:39:46AM -0700, Eric Anholt wrote: On Thu, 8 Sep 2011 11:00:52 +0800, Yuanhan Liu yuanhan@linux.intel.com wrote: BTW, this patch fix the oglc pntrast