Re: [Mesa-dev] [PATCH 1/3] glsl: Add support for constant expression evaluation on round(), roundEven().

2011-10-04 Thread Kenneth Graunke
On 10/04/2011 01:23 PM, Eric Anholt wrote: > On Tue, 4 Oct 2011 04:42:55 +0200, Henri Verbeet wrote: >> On 4 October 2011 00:41, Eric Anholt wrote: >>> They're both implemented the same in GLSL IR (since round() has >>> undefined behavior for n + 0.5). The specification of the C function >>> in

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-04 Thread Kenneth Graunke
On 10/03/2011 03:41 PM, Eric Anholt wrote: > The condmod instruction ends up generating garbage condition codes, > because apparently the comparison happens on the accumulator value (33 > bits for UD), not the truncated value that would be written. > > Fixes fs-op-neg-* I am uneasy about these tw

[Mesa-dev] libgallium.so and miscelaneous buildsystem patches

2011-10-04 Thread Fabio
Can the patches at http://lists.freedesktop.org/archives/mesa-dev/2011-August/011099.html be considered for merging? Sharing libgallium should save some MB of installed space. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesk

Re: [Mesa-dev] mesa integer format updates

2011-10-04 Thread Dave Airlie
On Tue, Oct 4, 2011 at 10:33 PM, Brian Paul wrote: > On 10/04/2011 02:11 PM, Dave Airlie wrote: >> >> This series adds the new integer formats and the associated >> texture and fbo pieces in core mesa. >> >> I'm really trying to upstream this in chunks, I don't think >> I'll get it all perfect, bu

Re: [Mesa-dev] [PATCH] glsl: Consider "__" in identifers as reserved in GLSL 1.30+.

2011-10-04 Thread Kenneth Graunke
On 10/04/2011 05:36 PM, Eric Anholt wrote: > On Tue, 04 Oct 2011 12:11:54 -0700, Ian Romanick wrote: >> On 10/04/2011 10:39 AM, Eric Anholt wrote: >>> On Mon, 03 Oct 2011 17:02:29 -0700, Kenneth Graunke >>> wrote: On 10/03/2011 04:51 PM, Eric Anholt wrote: > --- > src/glsl/ast_to_

[Mesa-dev] [PATCH RFC] gallium: interface changes necessary to implement transform feedback

2011-10-04 Thread Marek Olšák
Namely: - EXT_transform_feedback - ARB_transform_feedback2 - ARB_transform_feedback_instanced The old interface was unusable for OpenGL and had to go away. This interface was originally designed for OpenGL, but additional changes have been made in order to make st/d3d1x support easier. The most

Re: [Mesa-dev] [PATCH] glsl: Consider "__" in identifers as reserved in GLSL 1.30+.

2011-10-04 Thread Ian Romanick
On 10/04/2011 05:36 PM, Eric Anholt wrote: On Tue, 04 Oct 2011 12:11:54 -0700, Ian Romanick wrote: On 10/04/2011 10:39 AM, Eric Anholt wrote: On Mon, 03 Oct 2011 17:02:29 -0700, Kenneth Graunke wrote: On 10/03/2011 04:51 PM, Eric Anholt wrote: --- src/glsl/ast_to_hir.cpp |6 ++

Re: [Mesa-dev] [PATCH] glsl: Consider "__" in identifers as reserved in GLSL 1.30+.

2011-10-04 Thread Eric Anholt
On Tue, 04 Oct 2011 12:11:54 -0700, Ian Romanick wrote: > On 10/04/2011 10:39 AM, Eric Anholt wrote: > > On Mon, 03 Oct 2011 17:02:29 -0700, Kenneth Graunke > > wrote: > >> On 10/03/2011 04:51 PM, Eric Anholt wrote: > >>> --- > >>> src/glsl/ast_to_hir.cpp |6 ++ > >>> 1 files changed,

Re: [Mesa-dev] [PATCH 4/4] mesa: update fbo format tablet for integer types.

2011-10-04 Thread Ian Romanick
On 10/04/2011 04:47 PM, Eric Anholt wrote: On Tue, 4 Oct 2011 21:11:36 +0100, Dave Airlie wrote: From: Dave Airlie This updates the fbo format table for the integer types. Signed-off-by: Dave Airlie --- src/mesa/main/fbobject.c | 62 +- 1 file

[Mesa-dev] [PATCH 3/3] st/mesa: completely stop using gl_texture_image::Data

2011-10-04 Thread Brian Paul
From: Brian Paul Instead, use the new st_texture_image::TexData field to hold texture images that don't fit the parent object's mipmap buffer. --- src/mesa/state_tracker/st_cb_texture.c | 26 +- src/mesa/state_tracker/st_texture.h|7 ++- 2 files changed, 19

[Mesa-dev] [PATCH 2/3] st/mesa: stop using gl_texture_image::Data when mapping/unmapping textures

2011-10-04 Thread Brian Paul
From: Brian Paul Since core Mesa no longer depends on gl_texture_image::Data pointing to mapped texture buffers we don't have to mess with it all over the place in the state tracker. Now Data is only used to point to malloc'd memory that holds images which don't fit in the texture object's mipma

Re: [Mesa-dev] [PATCH 4/4] mesa: update fbo format tablet for integer types.

2011-10-04 Thread Eric Anholt
On Tue, 4 Oct 2011 21:11:36 +0100, Dave Airlie wrote: > From: Dave Airlie > > This updates the fbo format table for the integer types. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/fbobject.c | 62 > +- > 1 files changed, 61 insertions(+)

[Mesa-dev] [PATCH] i965: Remove brw_count_bits.

2011-10-04 Thread Paul Berry
This is a follow-up commit to be squashed into "mesa: Create a _mesa_bitcount_64() function." The new commit messsage should be: mesa: Create _mesa_bitcount_64() to replace i965's brw_count_bits() The i965 driver already had a function to count bits in a 64-bit uint (brw_count_bits()), but it wa

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Brian Paul
On 10/04/2011 04:08 PM, Kenneth Graunke wrote: On 10/04/2011 12:20 PM, Ian Romanick wrote: On 10/04/2011 10:49 AM, Paul Berry wrote: On 4 October 2011 10:32, Chad Versacemailto:c...@chad-versace.us>> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Overall, the patch looks

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Kenneth Graunke
On 10/04/2011 12:20 PM, Ian Romanick wrote: > On 10/04/2011 10:49 AM, Paul Berry wrote: >> On 4 October 2011 10:32, Chad Versace > > wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Overall, the patch looks good, but I'm going to take the

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a gl_vert_result for gl_ClipVertex.

2011-10-04 Thread Paul Berry
On 4 October 2011 14:49, Brian Paul wrote: > On 10/04/2011 03:19 PM, Paul Berry wrote: > >> On 4 October 2011 13:15, Ian Romanick > > wrote: >> >>On 10/03/2011 02:17 PM, Paul Berry wrote: >> >>Before this patch, clip planes didn't work properly in Mesa >>

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a gl_vert_result for gl_ClipVertex.

2011-10-04 Thread Brian Paul
On 10/04/2011 03:19 PM, Paul Berry wrote: On 4 October 2011 13:15, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 10/03/2011 02:17 PM, Paul Berry wrote: Before this patch, clip planes didn't work properly in Mesa when using vertex shaders, because Mesa assigned

Re: [Mesa-dev] mesa integer format updates

2011-10-04 Thread Brian Paul
On 10/04/2011 02:11 PM, Dave Airlie wrote: This series adds the new integer formats and the associated texture and fbo pieces in core mesa. I'm really trying to upstream this in chunks, I don't think I'll get it all perfect, but I don't think its really any worse than what we have now which is m

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a gl_vert_result for gl_ClipVertex.

2011-10-04 Thread Paul Berry
On 4 October 2011 13:15, Ian Romanick wrote: > On 10/03/2011 02:17 PM, Paul Berry wrote: > >> Before this patch, clip planes didn't work properly in Mesa when using >> vertex shaders, because Mesa assigned both gl_ClipVertex and >> gl_Position to the same gl_vert_result (VERT_RESULT_HPOS). As a

Re: [Mesa-dev] [PATCH 0/9] Elminate redudnant Mesa IR references

2011-10-04 Thread Brian Paul
On 10/04/2011 02:44 PM, Ian Romanick wrote: This is the next in my series of internal shader API cleaning. The primary purpose of this series is to remove the extra tracking of Mesa IR shaders. The gl_shader_program has a reference to the Mesa IR shader for each stage, and the entry in gl_shade

Re: [Mesa-dev] [PATCH 6/9] mesa: Simplify calling Driver.ProgramStringNotify after previous refactors

2011-10-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Nice cleanup BTW. Marek On Tue, Oct 4, 2011 at 10:44 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: Marek Olšák > --- >  src/mesa/program/ir_to_mesa.cpp            |   33 +++-- >  src/mesa/state_tracker/st_glsl_to_

Re: [Mesa-dev] [PATCH 3/3] api: Allow GL_CLIP_PLANE0+6 and GL_CLIP_PLANE0+7.

2011-10-04 Thread Ian Romanick
On 10/04/2011 01:55 PM, Kenneth Graunke wrote: Fixes the ES1 conformance 'userclip' test, which broke when we increased MAX_CLIP_PLANES to 8. Core Mesa already validates incoming values against MAX_CLIP_PLANES; we just need the ES wrapper to pass everything through. I've been using 'mesa/es:'

Re: [Mesa-dev] [PATCH 1/3] meta: Don't enable TEXTURE_RECTANGLE when it's unsupported.

2011-10-04 Thread Ian Romanick
On 10/04/2011 01:55 PM, Kenneth Graunke wrote: In particular, it's not supported on OpenGL ES 1.x. I'd change this text slightly. It's just the current convention that drivers that support NV_texture_rectangle (and some other extensions) don't enable them in ES 1.x. In the future, I'd like

[Mesa-dev] [PATCH 3/3] api: Allow GL_CLIP_PLANE0+6 and GL_CLIP_PLANE0+7.

2011-10-04 Thread Kenneth Graunke
Fixes the ES1 conformance 'userclip' test, which broke when we increased MAX_CLIP_PLANES to 8. Core Mesa already validates incoming values against MAX_CLIP_PLANES; we just need the ES wrapper to pass everything through. Signed-off-by: Kenneth Graunke --- src/mesa/main/APIspec.xml | 14 ++-

[Mesa-dev] [PATCH 2/3] mesa/get: Move MAX_LIGHTS from GL/ES2 to GL/ES1.

2011-10-04 Thread Kenneth Graunke
It's required for ES 1.0 and 1.1, and isn't specified for ES 2. While the comment says Mesa depends on it internally, removing it from ES2 doesn't seem to regress any Piglit or ES2 conformance tests. Signed-off-by: Kenneth Graunke --- src/mesa/main/get.c |3 +-- 1 files changed, 1 insertion

[Mesa-dev] [PATCH 1/3] meta: Don't enable TEXTURE_RECTANGLE when it's unsupported.

2011-10-04 Thread Kenneth Graunke
In particular, it's not supported on OpenGL ES 1.x. Prior to this, none of the OpenGL ES 1.1 conformance tests passed. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/common/meta.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/sr

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/04/2011 12:20 PM, Ian Romanick wrote: > On 10/04/2011 10:49 AM, Paul Berry wrote: >> On 4 October 2011 10:32, Chad Versace > > wrote: >> >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Overall, t

[Mesa-dev] [PATCH 6/9] mesa: Simplify calling Driver.ProgramStringNotify after previous refactors

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: Marek Olšák --- src/mesa/program/ir_to_mesa.cpp| 33 +++-- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 44 +++- 2 files changed, 22 insertions(+), 55 deletions(-) diff --git a/src/mesa/

[Mesa-dev] [PATCH 8/9] mesa: Silence several 'warning: unused parameter' in _mesa_GetnUniformdvARB

2011-10-04 Thread Ian Romanick
From: Ian Romanick This function isn't implemented yet, so none of its parameters are used yet. Signed-off-by: Ian Romanick --- src/mesa/main/uniforms.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniforms.c index 7bdee

[Mesa-dev] [PATCH 9/9] glsl: Remove unused method ir_variable::component_slots

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ir.cpp |8 src/glsl/ir.h |8 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index d6594cd..d968890 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -13

[Mesa-dev] [PATCH 7/9] mesa: Remove unused function _mesa_append_uniform

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/program/prog_uniform.c | 74 --- src/mesa/program/prog_uniform.h |4 -- 2 files changed, 0 insertions(+), 78 deletions(-) diff --git a/src/mesa/program/prog_uniform.c b/src/mesa/program/prog_u

[Mesa-dev] [PATCH 3/9] mesa: Use gl_shader_program::_LinkedShaders instead of FragmentProgram

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_fs.cpp |8 +--- src/mesa/drivers/dri/i965/brw_fs.h |3 ++- src/mesa/drivers/dri/i965/brw_wm.c |2 +- src/mesa/main/context.c|3 +-- src/mesa/main/mtypes

[Mesa-dev] [PATCH 2/9] mesa: Use gl_shader_program::_LinkedShaders instead of GeometryProgram

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/context.c|3 +-- src/mesa/main/mtypes.h |1 - src/mesa/main/shaderapi.c |9 + src/mesa/main/shaderobj.c |1 - src/mesa/main/state.c

[Mesa-dev] [PATCH 5/9] mesa: Simplify destroy_shader_program_variants_cb after previous refactors

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/state_tracker/st_program.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c index 4162bb9..acd3b56 100644 --- a/src/mesa/state_t

[Mesa-dev] [PATCH 4/9] mesa: Simplify validate_shader_program after previous refactors

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/shaderapi.c | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 1583520..c3aabe4 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/me

[Mesa-dev] [PATCH 1/9] mesa: Use gl_shader_program::_LinkedShaders instead of VertexProgram

2011-10-04 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |3 ++- src/mesa/drivers/dri/i965/brw_vs.c |8 +--- src/mesa/main/context.c|2 +- src/mesa/main/ff_fragment_shader.cpp | 10 +

[Mesa-dev] [PATCH 0/9] Elminate redudnant Mesa IR references

2011-10-04 Thread Ian Romanick
This is the next in my series of internal shader API cleaning. The primary purpose of this series is to remove the extra tracking of Mesa IR shaders. The gl_shader_program has a reference to the Mesa IR shader for each stage, and the entry in gl_shader_program::_LinkedShaders has a reference to t

Re: [Mesa-dev] [PATCH 1/3] glsl: Add support for constant expression evaluation on round(), roundEven().

2011-10-04 Thread Eric Anholt
On Tue, 4 Oct 2011 04:42:55 +0200, Henri Verbeet wrote: > On 4 October 2011 00:41, Eric Anholt wrote: > > They're both implemented the same in GLSL IR (since round() has > > undefined behavior for n + 0.5).  The specification of the C function > > in use here is a bit unclear: rint(3) says that n

Re: [Mesa-dev] [PATCH 1/2] mesa: Accept GL_DEPTH and GL_STENCIL for window system FBO only

2011-10-04 Thread Brian Paul
On 10/04/2011 01:32 PM, Ian Romanick wrote: From: Ian Romanick Previously GL_DEPTH_BUFFER and GL_STENCIL_BUFFER were (incorrectly) allowed for both. Those enums don't even really exist! Now GL_DEPTH and GL_STENCIL are only allowed for the window system FBO. Signed-off-by: Ian Romanick For 1

Re: [Mesa-dev] [PATCH v2 1/2] mesa: Add a gl_vert_result for gl_ClipVertex.

2011-10-04 Thread Ian Romanick
On 10/03/2011 02:17 PM, Paul Berry wrote: Before this patch, clip planes didn't work properly in Mesa when using vertex shaders, because Mesa assigned both gl_ClipVertex and gl_Position to the same gl_vert_result (VERT_RESULT_HPOS). As a result, backends couldn't distinguish between the two vari

[Mesa-dev] [PATCH 4/4] mesa: update fbo format tablet for integer types.

2011-10-04 Thread Dave Airlie
From: Dave Airlie This updates the fbo format table for the integer types. Signed-off-by: Dave Airlie --- src/mesa/main/fbobject.c | 62 +- 1 files changed, 61 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbo

[Mesa-dev] [PATCH 1/4] mesa/formats: add rest of integer formats.

2011-10-04 Thread Dave Airlie
From: Dave Airlie This is taken from reading EXT_texture_integer + EXT_texture_rg in combination, Comments on necessity of each format, naming of formats and bugs in the formats tables please. Is there any formats I've missed? Eric looked over this to make sure its consistent at least. As I'v

[Mesa-dev] [PATCH 3/4] mesa/texstore: add texstore paths for all the integer types.

2011-10-04 Thread Dave Airlie
From: Dave Airlie This just adds the entries to the table and fixes the asserts up. The int32 one is definitely wrong, since it uses a float temp which will lose precision, but its no worse than now. Signed-off-by: Dave Airlie --- src/mesa/main/texstore.c | 102 ++

[Mesa-dev] [PATCH 2/4] mesa/texformat: update choose_tex_format for integer types.

2011-10-04 Thread Dave Airlie
From: Dave Airlie This adds the integer types to the tex format chooser. Signed-off-by: Dave Airlie --- src/mesa/main/texformat.c | 83 ++-- 1 files changed, 79 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/texformat.c b/src/mesa/main/texfo

[Mesa-dev] mesa integer format updates

2011-10-04 Thread Dave Airlie
This series adds the new integer formats and the associated texture and fbo pieces in core mesa. I'm really trying to upstream this in chunks, I don't think I'll get it all perfect, but I don't think its really any worse than what we have now which is missing so many pieces. Dave. _

[Mesa-dev] [PATCH 2/2] mesa: Only allow queries of window system FBO on desktop GL w/ARB_fbo

2011-10-04 Thread Ian Romanick
From: Ian Romanick Neither OES_framebuffer_object nor EXT_framebuffer_object allow querying the window system FBO. Signed-off-by: Ian Romanick --- src/mesa/main/fbobject.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mes

[Mesa-dev] [PATCH 1/2] mesa: Accept GL_DEPTH and GL_STENCIL for window system FBO only

2011-10-04 Thread Ian Romanick
From: Ian Romanick Previously GL_DEPTH_BUFFER and GL_STENCIL_BUFFER were (incorrectly) allowed for both. Those enums don't even really exist! Now GL_DEPTH and GL_STENCIL are only allowed for the window system FBO. Signed-off-by: Ian Romanick --- src/mesa/main/fbobject.c | 39 ++

[Mesa-dev] Mesa 7.11 and osmesa

2011-10-04 Thread Paul Gotzel
Hello, I've recently upgraded to mesa 7.11 and I've noticed significant performance degradation when using osmesa.  Here's my results when comparing the versions: Version   Time 7.6.1    4s 7.10.3 16s 7.11 23s This is the time to render a single frame (including

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Ian Romanick
On 10/04/2011 10:49 AM, Paul Berry wrote: On 4 October 2011 10:32, Chad Versace mailto:c...@chad-versace.us>> wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Overall, the patch looks good, but I'm going to take the bikeshed bait. Symbols of form GLxxx and constants of form

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-04 Thread Ian Romanick
On 10/04/2011 10:37 AM, Eric Anholt wrote: On Mon, 03 Oct 2011 16:34:28 -0700, Ian Romanick wrote: On 10/03/2011 03:41 PM, Eric Anholt wrote: diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 2000180..555d26d 100644 --- a/src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH] glsl: Consider "__" in identifers as reserved in GLSL 1.30+.

2011-10-04 Thread Ian Romanick
On 10/04/2011 10:39 AM, Eric Anholt wrote: On Mon, 03 Oct 2011 17:02:29 -0700, Kenneth Graunke wrote: On 10/03/2011 04:51 PM, Eric Anholt wrote: --- src/glsl/ast_to_hir.cpp |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_

Re: [Mesa-dev] [PATCH 4/6] i965: Make brw_compute_vue_map's userclip dependency a boolean.

2011-10-04 Thread Paul Berry
On 4 October 2011 10:54, Ian Romanick wrote: > On 10/03/2011 03:11 PM, Paul Berry wrote: > >> Previously, brw_compute_vue_map required an argument indicating the >> number of clip planes in use, but all it did with it was check if it >> was nonzero. >> >> This patch changes brw_compute_vue_map to

Re: [Mesa-dev] [PATCH 6/6] i965 Gen6+: De-compact clip planes.

2011-10-04 Thread Ian Romanick
On 10/03/2011 03:11 PM, Paul Berry wrote: Previously, if the user enabled a non-consecutive set of clip planes (e.g. 0, 1, and 3), the driver would compact them down to a consecutive set starting at 0. This optimization was of dubious value, and complicated the implementation of gl_ClipDistance.

Re: [Mesa-dev] [PATCH 4/6] i965: Make brw_compute_vue_map's userclip dependency a boolean.

2011-10-04 Thread Ian Romanick
On 10/03/2011 03:11 PM, Paul Berry wrote: Previously, brw_compute_vue_map required an argument indicating the number of clip planes in use, but all it did with it was check if it was nonzero. This patch changes brw_compute_vue_map to take a boolean instead. This allows us to avoid some unnecessa

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Paul Berry
On 4 October 2011 10:32, Chad Versace wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Overall, the patch looks good, but I'm going to take the bikeshed bait. > > Symbols of form GLxxx and constants of form GL_XXX should be reserved for > those defined in the GL headers. If I encounte

Re: [Mesa-dev] [PATCH] glsl: Consider "__" in identifers as reserved in GLSL 1.30+.

2011-10-04 Thread Eric Anholt
On Mon, 03 Oct 2011 17:02:29 -0700, Kenneth Graunke wrote: > On 10/03/2011 04:51 PM, Eric Anholt wrote: > > --- > > src/glsl/ast_to_hir.cpp |6 ++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > > index 91a223

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Fix comparisions with uint negation.

2011-10-04 Thread Eric Anholt
On Mon, 03 Oct 2011 16:34:28 -0700, Ian Romanick wrote: > On 10/03/2011 03:41 PM, Eric Anholt wrote: > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > > b/src/mesa/drivers/dri/i965/brw_fs.cpp > > index 2000180..555d26d 100644 > > --- a/src/mesa/drivers/dri/i965/brw_fs.cpp > > +++ b/src/mes

[Mesa-dev] [PATCH] winsys: fill in missing displaytarget bits in null winsys

2011-10-04 Thread Fredrik Höglund
This is needed for renderbuffer support. --- src/gallium/winsys/sw/null/null_sw_winsys.c | 52 +++ 1 files changed, 45 insertions(+), 7 deletions(-) diff --git a/src/gallium/winsys/sw/null/null_sw_winsys.c b/src/gallium/winsys/sw/null/null_sw_winsys.c index 73b777f..4af

Re: [Mesa-dev] [PATCH v2 2/2] i965 Gen6: Implement gl_ClipVertex.

2011-10-04 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Overall, the patch looks good, but I'm going to take the bikeshed bait. Symbols of form GLxxx and constants of form GL_XXX should be reserved for those defined in the GL headers. If I encountered the symbol GLclipplane in Mesa, I would confidently, ye

Re: [Mesa-dev] [PATCH 1/6] mesa: Create a _mesa_bitcount_64() function.

2011-10-04 Thread Paul Berry
On 4 October 2011 09:41, Kenneth Graunke wrote: > On 10/04/2011 07:00 AM, Brian Paul wrote: > > > > I'm guessing you could eventually get rid of the brw_count_bits() > > wrapper altogether at some point. > > > > Reviewed-by: Brian Paul > > I'd be glad to see that go, too. > > Reviewed-by: Kennet

Re: [Mesa-dev] [PATCH 1/6] mesa: Create a _mesa_bitcount_64() function.

2011-10-04 Thread Kenneth Graunke
On 10/04/2011 07:00 AM, Brian Paul wrote: > On 10/03/2011 04:11 PM, Paul Berry wrote: >> The i965 driver already had a function to do this (brw_count_bits()), >> but it was buggy (it only counted the bottom 32 bits) and it was >> clumsy (it had a strange and broken fallback for non-GCC-like >> comp

[Mesa-dev] [Bug 41441] Crashes introduced in f7f678331d5e95d2266fe6b3ea1cfa47d6421065

2011-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41441 --- Comment #2 from rei4...@gmail.com 2011-10-04 09:12:04 PDT --- Yes, with this patch the crash doesn't occur anymore. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: -

[Mesa-dev] [Bug 31084] 7.9 configure doesn't check for python

2011-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31084 Lauri Kasanen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 41441] Crashes introduced in f7f678331d5e95d2266fe6b3ea1cfa47d6421065

2011-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41441 --- Comment #1 from Brian Paul 2011-10-04 07:33:23 PDT --- Created an attachment (id=51961) View: https://bugs.freedesktop.org/attachment.cgi?id=51961 Review: https://bugs.freedesktop.org/review?bug=41441&attachment=51961 allocate all result a

Re: [Mesa-dev] [PATCH 1/6] mesa: Create a _mesa_bitcount_64() function.

2011-10-04 Thread Brian Paul
On 10/03/2011 04:11 PM, Paul Berry wrote: The i965 driver already had a function to do this (brw_count_bits()), but it was buggy (it only counted the bottom 32 bits) and it was clumsy (it had a strange and broken fallback for non-GCC-like compilers, which fortunately was never used). Since Mesa

Re: [Mesa-dev] [PATCH] st/glx: Set the drawable attribute on xmesa_buffer creation.

2011-10-04 Thread Jose Fonseca
Looks good. Although I wonder if either b->drawable or b->ws.drawable could be removed. Jose - Original Message - > From: Stephen White > > Otherwise we'll be unable to use our pbuffers. > --- > src/gallium/state_trackers/glx/xlib/xm_api.c |2 +- > 1 files changed, 1 insertions(+)

Re: [Mesa-dev] [PATCH mesa 0/3] Some cleanups

2011-10-04 Thread Brian Paul
On Tue, Oct 4, 2011 at 12:46 AM, Guillem Jover wrote: > Hi! > > Here's some patches that clean up the tree from legacy stuff, update > the documentation and the .gitignore file. Looks good to me. I'll commit these soon. -Brian ___ mesa-dev mailing lis

[Mesa-dev] [Bug 41441] New: Crashes introduced in f7f678331d5e95d2266fe6b3ea1cfa47d6421065

2011-10-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41441 Summary: Crashes introduced in f7f678331d5e95d2266fe6b3ea1cfa47d6421065 Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW