Re: [Mesa-dev] Radeon DRI1 removal

2011-10-21 Thread Alex Deucher
2011/10/20 Eric Anholt : > On Thu, 20 Oct 2011 10:35:31 +0200, Michel Dänzer wrote: >> On Mit, 2011-10-19 at 17:50 -0700, Eric Anholt wrote: >> > So, Radeon maintainers, what do you think?  And, does anyone else want >> > to test it on the other drivers?  I caught two bugs in my r300 testing >> >

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-21 Thread Kurt Roeckx
On Wed, Oct 19, 2011 at 05:50:29PM -0700, Eric Anholt wrote: > I think it would be much better to just ditch DRI1 at this point, since > KMS and DRI2 are quite well established, and are relied on by shipping > desktop environments. Does this mean I can't use UMS anymore, and so can't have an accel

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-21 Thread Alex Deucher
On Fri, Oct 21, 2011 at 1:31 PM, Kurt Roeckx wrote: > On Wed, Oct 19, 2011 at 05:50:29PM -0700, Eric Anholt wrote: >> I think it would be much better to just ditch DRI1 at this point, since >> KMS and DRI2 are quite well established, and are relied on by shipping >> desktop environments. > > Does

[Mesa-dev] [PATCH] i965: Apply post-sync non-zero workaround to homebrew workaround.

2011-10-21 Thread Kenneth Graunke
In commit 3e5d3626, Eric added a homebrew workaround to fix GPU hangs in the Mesa "engine" demo and oglc's api-texcoord test. Unfortunately, his PIPE_CONTROL contains a Depth Stall, which necessitates the post-sync non-zero workaround, Seems to help stability in Civilization 4 and PlaneShift. NO

Re: [Mesa-dev] [PATCH 2/2] i965: Avoid generating MOVs for most ir_assignment handling.

2011-10-21 Thread Stéphane Marchesin
2011/10/19 Stéphane Marchesin : > On Sat, Aug 27, 2011 at 03:23, Kenneth Graunke wrote: >> This is a port of vec4_visitor::try_rewrite_rhs_to_dst to fs_visitor. >> >> Not only is this technique less invasive and more robust, it also >> generates better code.  Over and above the previous technique,

Re: [Mesa-dev] [PATCH 5/5] intel: Remove intel_renderbuffer::hiz_region

2011-10-21 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/19/2011 11:12 AM, Chad Versace wrote: > On 10/18/2011 03:57 PM, Eric Anholt wrote: >> On Mon, 17 Oct 2011 07:40:28 -0700, Chad Versace >> wrote: >>> Replace it with intel_renderbuffer::region::hiz::region. >>> >>> Signed-off-by: Chad Versace >

[Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Ian Romanick
From: Ian Romanick Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that query uniforms in shaders, uniform declarations cannot be removed after the locations have been set. However, it should still be saf

[Mesa-dev] [PATCH 2/2] linker: Eliminate more dead code after demoting shader inputs and outputs

2011-10-21 Thread Ian Romanick
From: Ian Romanick Consider the following vertex shader and fragment shader: // vertex shader varying vec4 v; uniform vec4 u; void main() { gl_Position = vec4(0.0); v = u; } // fragment shader void main() { gl_FragColor = vec4(0.0); } Since the fragment shader does not use 'v', it is demoted

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Bryan Cain
If it's worth anything, the glsl_to_tgsi part is Reviewed-by: Bryan Cain On 10/21/2011 01:49 PM, Ian Romanick wrote: > From: Ian Romanick > > Setting this flag prevents declarations of uniforms from being removed > from the IR. Since the IR is directly used by several API functions > that quer

Re: [Mesa-dev] [PATCH 2/2] linker: Eliminate more dead code after demoting shader inputs and outputs

2011-10-21 Thread Kenneth Graunke
On 10/21/2011 11:49 AM, Ian Romanick wrote: > From: Ian Romanick > > Consider the following vertex shader and fragment shader: > > // vertex shader > varying vec4 v; > uniform vec4 u; > > void main() { gl_Position = vec4(0.0); v = u; } > > // fragment shader > void main() { gl_FragColor = vec4

Re: [Mesa-dev] [PATCH] Fix _GNUC__ typo in check for gcc 3.x for _mesa_bitcount

2011-10-21 Thread Ian Romanick
On 10/20/2011 06:30 PM, Jason Wood wrote: On 10/20/2011 06:58 PM, Alan Coopersmith wrote: Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a candidate for the stable branches. Signed-off-by: Alan Coopersmith

Re: [Mesa-dev] [PATCH 2/2] i965: Avoid generating MOVs for most ir_assignment handling.

2011-10-21 Thread Eric Anholt
On Fri, 21 Oct 2011 11:05:53 -0700, Stéphane Marchesin wrote: > 2011/10/19 Stéphane Marchesin : > > On Sat, Aug 27, 2011 at 03:23, Kenneth Graunke > > wrote: > >> This is a port of vec4_visitor::try_rewrite_rhs_to_dst to fs_visitor. > >> > >> Not only is this technique less invasive and more ro

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Brian Paul
On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanick Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that query uniforms in shaders, uniform declarations cannot be removed after the locations ha

Re: [Mesa-dev] [PATCH] Fix _GNUC__ typo in check for gcc 3.x for _mesa_bitcount

2011-10-21 Thread Brian Paul
On 10/21/2011 01:10 PM, Ian Romanick wrote: On 10/20/2011 06:30 PM, Jason Wood wrote: On 10/20/2011 06:58 PM, Alan Coopersmith wrote: Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a candidate for the stab

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Brian Paul
On 10/21/2011 01:23 PM, Brian Paul wrote: On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanick Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that query uniforms in shaders, uniform declaration

Re: [Mesa-dev] [PATCH] Fix _GNUC__ typo in check for gcc 3.x for _mesa_bitcount

2011-10-21 Thread Alan Coopersmith
On 10/20/11 18:30, Jason Wood wrote: On 10/20/2011 06:58 PM, Alan Coopersmith wrote: Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a candidate for the stable branches. Signed-off-by: Alan Coopersmith ---

Re: [Mesa-dev] [PATCH] Fix _GNUC__ typo in check for gcc 3.x for _mesa_bitcount

2011-10-21 Thread Alan Coopersmith
On 10/21/11 12:30, Brian Paul wrote: How about doing something like: #if __GNUC__ * 10 + __GNUC_MINOR__ < 34 I find that a bit easier to follow. The X.Org headers I'm more familiar with do something very much like that, just with a little protection against the possibility of gcc someday hitt

[Mesa-dev] [PATCH 1/2] Fix gcc version checks for _mesa_bitcount

2011-10-21 Thread Alan Coopersmith
- Fix _GNUC__ typo in both checks - Fix logic error in check for gcc < 3.4 that breaks for gcc 2.x & older Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a candidate for the stable branches. Signed-off-by: A

[Mesa-dev] [PATCH 2/2] Convert additional GNUC_MINOR checks to multiplied version

2011-10-21 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- src/mesa/main/imports.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index 9cb6c6c..797f357 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -453,7 +453,7 @@

[Mesa-dev] [PATCH] gallium/auxiliary/util: Solaris also has standard Unix sockets

2011-10-21 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- src/gallium/auxiliary/util/u_network.c |9 ++--- src/gallium/auxiliary/util/u_network.h |3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_network.c b/src/gallium/auxiliary/util/u_network.c index 77f

Re: [Mesa-dev] [PATCH 1/2] Fix gcc version checks for _mesa_bitcount

2011-10-21 Thread Kenneth Graunke
On 10/21/2011 04:10 PM, Alan Coopersmith wrote: > - Fix _GNUC__ typo in both checks > - Fix logic error in check for gcc < 3.4 that breaks for gcc 2.x & older > > Without this fix, builds with gcc 3.4.x end up depending on undefined > _mesa_bitcount instead of gcc's __builtin_popcount. > > NOTE:

[Mesa-dev] [PATCH] TransformFeedback: Assign transform feedback varying slots in linker.

2011-10-21 Thread Dan McCabe
Modify the linker to assign additional slots for varying variables used by transform feedback. This is done after other varyings are already assigned slots. Since this is done after previous varying slot assignments, the code needs to know how many varyings are already assigned slots. A new functi

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Kenneth Graunke
On 10/21/2011 11:49 AM, Ian Romanick wrote: > From: Ian Romanick > > Setting this flag prevents declarations of uniforms from being removed > from the IR. Since the IR is directly used by several API functions > that query uniforms in shaders, uniform declarations cannot be removed > after the l

Re: [Mesa-dev] [PATCH 1/2] glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass

2011-10-21 Thread Ian Romanick
On 10/21/2011 12:53 PM, Brian Paul wrote: On 10/21/2011 01:23 PM, Brian Paul wrote: On 10/21/2011 12:49 PM, Ian Romanick wrote: From: Ian Romanick Setting this flag prevents declarations of uniforms from being removed from the IR. Since the IR is directly used by several API functions that que

Re: [Mesa-dev] [PATCH 1/2] Fix gcc version checks for _mesa_bitcount

2011-10-21 Thread Ian Romanick
On 10/21/2011 04:10 PM, Alan Coopersmith wrote: - Fix _GNUC__ typo in both checks - Fix logic error in check for gcc< 3.4 that breaks for gcc 2.x& older Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a ca

[Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images

2011-10-21 Thread Chad Versace
For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case, nr_images == 6 and depth == 1. It is simple to determine if a texture is a cube or not, so the presence of two fields here was not helpful. Worse,