Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_VERTEXID

2011-11-11 Thread Christoph Bumiller
On 12.11.2011 00:30, Brian Paul wrote: > On 11/11/2011 04:18 PM, Christoph Bumiller wrote: >> On 11.11.2011 23:59, Brian Paul wrote: >>> On 11/11/2011 03:18 PM, Christoph Bumiller wrote: --- src/gallium/auxiliary/tgsi/tgsi_dump.c |1 + src/gallium/auxiliary/tgsi/tgsi_sca

Re: [Mesa-dev] 7.11.1 release, and picking NormalMatrix fix

2011-11-11 Thread tom fogal
On 11/11/2011 02:54 PM, Ian Romanick wrote: On 11/02/2011 12:48 PM, Ian Romanick wrote: On 11/02/2011 12:04 PM, tom fogal wrote: It's been three months since 7.11 came out. Have there been any thoughts on a 7.11.1 release date? "Soon." After the last big round of cherry picking that I did, ou

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_VERTEXID

2011-11-11 Thread Brian Paul
On 11/11/2011 04:18 PM, Christoph Bumiller wrote: On 11.11.2011 23:59, Brian Paul wrote: On 11/11/2011 03:18 PM, Christoph Bumiller wrote: --- src/gallium/auxiliary/tgsi/tgsi_dump.c |1 + src/gallium/auxiliary/tgsi/tgsi_scan.c |3 +++ src/gallium/auxiliary/tgsi/tgsi_scan.

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_VERTEXID

2011-11-11 Thread Christoph Bumiller
On 11.11.2011 23:59, Brian Paul wrote: > On 11/11/2011 03:18 PM, Christoph Bumiller wrote: >> --- >> src/gallium/auxiliary/tgsi/tgsi_dump.c |1 + >> src/gallium/auxiliary/tgsi/tgsi_scan.c |3 +++ >> src/gallium/auxiliary/tgsi/tgsi_scan.h |1 + >> src/gallium/auxiliary/t

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_VERTEXID

2011-11-11 Thread Brian Paul
On 11/11/2011 03:18 PM, Christoph Bumiller wrote: --- src/gallium/auxiliary/tgsi/tgsi_dump.c |1 + src/gallium/auxiliary/tgsi/tgsi_scan.c |3 +++ src/gallium/auxiliary/tgsi/tgsi_scan.h |1 + src/gallium/auxiliary/tgsi/tgsi_text.c |1 + src/gallium/include/pip

[Mesa-dev] [PATCH 2/2] st/mesa: fix system value to semantic mapping

2011-11-11 Thread Christoph Bumiller
Broken by addition of SYSTEM_VALUE_VERTEX_ID in 919c53e87a1f6f5322bc1f1486bb3e6b954b00d5. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |1 + src/mesa/state_tracker/st_mesa_to_tgsi.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_t

[Mesa-dev] [PATCH 1/2] gallium: add TGSI_SEMANTIC_VERTEXID

2011-11-11 Thread Christoph Bumiller
--- src/gallium/auxiliary/tgsi/tgsi_dump.c |1 + src/gallium/auxiliary/tgsi/tgsi_scan.c |3 +++ src/gallium/auxiliary/tgsi/tgsi_scan.h |1 + src/gallium/auxiliary/tgsi/tgsi_text.c |1 + src/gallium/include/pipe/p_shader_tokens.h |5 +++-- 5 files changed, 9 inse

Re: [Mesa-dev] [PATCH 1/2] meta: Don't forget to flag state when restoring texobjects.

2011-11-11 Thread Ian Romanick
On 11/11/2011 10:31 AM, Eric Anholt wrote: It's unlikely that we changed the object but no other texture parameter, but be correct anyway. Noticed by inspection. For the series, Reviewed-by: Ian Romanick --- src/mesa/drivers/common/meta.c |7 +-- 1 files changed, 5 insertions(+)

Re: [Mesa-dev] [PATCH 4/4] intel: Support native Z16 depth textures (including as renderbuffer) on i965.

2011-11-11 Thread Ian Romanick
On 11/11/2011 10:57 AM, Eric Anholt wrote: This is required for GL 3.0. The old comment about Z24 is dropped, since we support X8_Z24 now. --- src/mesa/drivers/dri/intel/intel_context.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/

Re: [Mesa-dev] 7.11.1 release, and picking NormalMatrix fix

2011-11-11 Thread Ian Romanick
On 11/02/2011 12:48 PM, Ian Romanick wrote: On 11/02/2011 12:04 PM, tom fogal wrote: It's been three months since 7.11 came out. Have there been any thoughts on a 7.11.1 release date? "Soon." After the last big round of cherry picking that I did, our internal QA has been running the full round

[Mesa-dev] [Bug 42803] bitmap2 demo in mesa_demos/src/sample hangs the GPU

2011-11-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42803 Kenneth Graunke changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop. |i...@freedesktop.org

Re: [Mesa-dev] [PATCH] glcpp: Add GL_ARB_draw_instanced #define.

2011-11-11 Thread Kenneth Graunke
On 11/11/2011 03:26 AM, Morgan Armand wrote: --- src/glsl/glcpp/glcpp-parse.y |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 1b17ff4..c0457b0 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/g

Re: [Mesa-dev] [PATCH 1/4] mesa: Include R/RG integer textures in _mesa_is_integer_format.

2011-11-11 Thread Kenneth Graunke
On 11/11/2011 10:57 AM, Eric Anholt wrote: Fixes some spurious GL errors in the upcoming gl-3.0-required-sized-formats piglit test. For patch 1, 2, and 4: Reviewed-by: Kenneth Graunke Brian's idea for patch 3 sounds reasonable to me, but I don't know what other changes that would entail. I'

Re: [Mesa-dev] [PATCH 3/4] mesa: Fix the component type of unorm depth textures.

2011-11-11 Thread Brian Paul
On 11/11/2011 11:57 AM, Eric Anholt wrote: Fixes a failure in piglit gl-3.0-required-sized-formats --- src/mesa/main/texparam.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index e9bed23..fad864d

Re: [Mesa-dev] [PATCH 2/4] mesa: Don't report types for 0-sized components of textures.

2011-11-11 Thread Brian Paul
On 11/11/2011 11:57 AM, Eric Anholt wrote: The GL_TEXTURE_WHATEVER_SIZE entrypoints were checking if the specified base type of the texture allowed that channel to be present before reporting the size of the channel, so that GL_RGB didn't end up with an alpha size if the hardware driver had to st

Re: [Mesa-dev] [PATCH 2/2] meta: Fix restoring of fixed function texture enables.

2011-11-11 Thread Brian Paul
On 11/11/2011 11:31 AM, Eric Anholt wrote: If they were disabled on entry, and we enabled one (like for BlitFramebuffer), we wouldn't disable it on the way out. Retain the attempted optimization here (don't keep calling to set each bit for changes that won't matter) by just setting the bits dire

Re: [Mesa-dev] [PATCH 1/2] meta: Don't forget to flag state when restoring texobjects.

2011-11-11 Thread Brian Paul
On 11/11/2011 11:31 AM, Eric Anholt wrote: It's unlikely that we changed the object but no other texture parameter, but be correct anyway. Noticed by inspection. --- src/mesa/drivers/common/meta.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 2/2] xlib: set alpha to 0xff when mapping RGB pixmaps

2011-11-11 Thread Brian Paul
On 11/11/2011 09:34 AM, Eric Anholt wrote: On Thu, 10 Nov 2011 18:01:47 -0700, Brian Paul wrote: Fixes a bunch of conform regressions. --- src/mesa/drivers/x11/xm_buffer.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/x11/xm_buffer.c b/s

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Theiss, Ingo
Am Freitag, 11. November 2011 14:53 CET, Brian Paul schrieb: > 2011/11/11 Michel Dänzer : > > > Anyway, I guess there's room for optimization in glReadPixels... > > Ingo, if you could find out what the format/type parameters to > glReadPixels are, we could look into some optimization in th

Re: [Mesa-dev] [PATCH] mesa: Fix glFramebufferTexture*() for depth and stencil attachments

2011-11-11 Thread Eric Anholt
On Thu, 10 Nov 2011 10:36:38 -0800, y...@chad-versace.us wrote: > + /* As above, but with depth and stencil juxtasposed. */ "juxtaposed" > + reuse_framebuffer_texture_attachment(fb, BUFFER_STENCIL, > + BUFFER_DEPTH); > + } else { > + _

Re: [Mesa-dev] [PATCH] i965: Don't try to normalize cubemap coordinates for textureSize.

2011-11-11 Thread Eric Anholt
On Fri, 11 Nov 2011 02:07:00 -0800, Kenneth Graunke wrote: > Although textureSize is represented as an ir_texture with op == ir_txs, > it doesn't have a coordinate, so normalizing it doesn't make sense. > > Fixes crashes in oglconform glsl-bif-tex-size basic.samplerCube.* tests. Reviewed-by: Er

Re: [Mesa-dev] [PATCH 1/4] mesa: Include R/RG integer textures in _mesa_is_integer_format.

2011-11-11 Thread Dave Airlie
On Fri, Nov 11, 2011 at 6:57 PM, Eric Anholt wrote: > Fixes some spurious GL errors in the upcoming > gl-3.0-required-sized-formats piglit test. Reviewed-by: Dave Airlie > --- >  src/mesa/main/image.c |   12 >  1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/src/

[Mesa-dev] [PATCH 2/4] mesa: Don't report types for 0-sized components of textures.

2011-11-11 Thread Eric Anholt
The GL_TEXTURE_WHATEVER_SIZE entrypoints were checking if the specified base type of the texture allowed that channel to be present before reporting the size of the channel, so that GL_RGB didn't end up with an alpha size if the hardware driver had to store it that way. The GL_TEXTURE_WHATEVER_TYP

[Mesa-dev] [PATCH 3/4] mesa: Fix the component type of unorm depth textures.

2011-11-11 Thread Eric Anholt
Fixes a failure in piglit gl-3.0-required-sized-formats --- src/mesa/main/texparam.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index e9bed23..fad864d 100644 --- a/src/mesa/main/texparam.c +++ b/src

[Mesa-dev] [PATCH 1/4] mesa: Include R/RG integer textures in _mesa_is_integer_format.

2011-11-11 Thread Eric Anholt
Fixes some spurious GL errors in the upcoming gl-3.0-required-sized-formats piglit test. --- src/mesa/main/image.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/image.c b/src/mesa/main/image.c index 7d95dd6..d3eaf27 100644 --- a/src/mesa/main/im

[Mesa-dev] [PATCH 4/4] intel: Support native Z16 depth textures (including as renderbuffer) on i965.

2011-11-11 Thread Eric Anholt
This is required for GL 3.0. The old comment about Z24 is dropped, since we support X8_Z24 now. --- src/mesa/drivers/dri/intel/intel_context.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 2/2] meta: Fix restoring of fixed function texture enables.

2011-11-11 Thread Eric Anholt
If they were disabled on entry, and we enabled one (like for BlitFramebuffer), we wouldn't disable it on the way out. Retain the attempted optimization here (don't keep calling to set each bit for changes that won't matter) by just setting the bits directly with appropriate flushing. Fixes misren

[Mesa-dev] [PATCH 1/2] meta: Don't forget to flag state when restoring texobjects.

2011-11-11 Thread Eric Anholt
It's unlikely that we changed the object but no other texture parameter, but be correct anyway. Noticed by inspection. --- src/mesa/drivers/common/meta.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 10/10] vbo: Clean up recalculate_input_bindings.

2011-11-11 Thread Mathias Fröhlich
Now the gl_array_object's layout matches the one used in recalculate_input_bindings. Make use of this and remove the bind_array_obj function. --- src/mesa/vbo/vbo_exec.h |6 src/mesa/vbo/vbo_exec_array.c | 53 +++- 2 files changed, 15 insertion

[Mesa-dev] [PATCH 09/10] mesa: Make NV generic attributes alias the legacy arrays.

2011-11-11 Thread Mathias Fröhlich
The NV_vertex_program generic attributes should alias the legacy attributes. Simplify aliasing by using the same gl_client_arrays for legacy and NV_vertex_program attributes. The same is already done for the current state values. --- src/mesa/main/enable.c| 10 ++-- src/mesa/main/get.c

[Mesa-dev] [PATCH 06/10] intel: Make gl_program::InputsRead 64 bits.

2011-11-11 Thread Mathias Fröhlich
--- src/mesa/drivers/dri/i915/i915_fragprog.c |4 ++-- src/mesa/drivers/dri/i965/brw_context.h |2 +- src/mesa/drivers/dri/i965/brw_draw_upload.c |6 +++--- src/mesa/drivers/dri/i965/brw_vs.c |4 ++-- src/mesa/drivers/dri/i965/brw_vs_constval.c |2 +- src/mesa/d

[Mesa-dev] [PATCH 07/10] radeon: Make gl_program::InputsRead 64 bits.

2011-11-11 Thread Mathias Fröhlich
--- src/mesa/drivers/dri/r200/r200_vertprog.c | 31 ++-- 1 files changed, 20 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/r200/r200_vertprog.c b/src/mesa/drivers/dri/r200/r200_vertprog.c index 697073e..bf87d80 100644 --- a/src/mesa/drivers/dri/r200/

[Mesa-dev] [PATCH 00/10] Make gl_array_object use an array of gl_client_attribs

2011-11-11 Thread Mathias Fröhlich
Hi all, following a patch series to make gl_array_object use a VERT_ATTRIB_* indexed array of gl_client_array structs. Since we have already 33 client arrays in an array object the VERT_BIT_* and for vertex shader inputs bitmaps are extended to 64 bits. Drivers and shader code is updated to use t

[Mesa-dev] [PATCH 05/10] mesa: Make gl_program::InputsRead 64 bits.

2011-11-11 Thread Mathias Fröhlich
--- src/mesa/main/context.c|2 +- src/mesa/main/ff_fragment_shader.cpp |2 +- src/mesa/main/ffvertex_prog.c | 18 +- src/mesa/main/mtypes.h |4 ++-- src/mesa/main/state.c

[Mesa-dev] [PATCH 04/10] mesa: Make gl_array_object::_Enabled 64 bits.

2011-11-11 Thread Mathias Fröhlich
--- src/mesa/main/context.c |2 +- src/mesa/main/enable.c |2 +- src/mesa/main/mtypes.h | 54 +++--- src/mesa/main/varray.c |2 +- 4 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/cont

[Mesa-dev] [PATCH 02/10] mesa: Replace _NEW_ARRAY_* bits with VERT_BIT_*

2011-11-11 Thread Mathias Fröhlich
Consolidate the two distinct set of flags to use VERT_BIT_*. --- src/mesa/main/arrayobj.c |2 +- src/mesa/main/enable.c | 20 ++-- src/mesa/main/mtypes.h | 37 ++--- src/mesa/main/varray.c | 36 ++-- 4

[Mesa-dev] [PATCH 03/10] vbo: Use The VERT_{ATTRIB,BIT} defines.

2011-11-11 Thread Mathias Fröhlich
--- src/mesa/vbo/vbo_context.c| 26 +++--- src/mesa/vbo/vbo_exec.h |4 ++-- src/mesa/vbo/vbo_exec_api.c | 24 src/mesa/vbo/vbo_exec_array.c | 41 + src/mesa/vbo/vbo_exec_draw.c | 22

[Mesa-dev] [PATCH 01/10] mesa: Introduce more symbolic VERT_{ATTRIB, BIT}* defines.

2011-11-11 Thread Mathias Fröhlich
Introduce a set of defines for VERT_ATTRIB_* and VERT_BIT_* that will be used in the followup patches. --- src/mesa/main/context.c | 29 ++ src/mesa/main/mtypes.h | 60 -- 2 files changed, 71 insertions(+), 18 deletions(-) diff

Re: [Mesa-dev] [PATCH 2/2] intel: make sure hardware choose the right filter mode

2011-11-11 Thread Eric Anholt
On Thu, 3 Nov 2011 10:16:06 +0800, Yuanhan Liu wrote: > On Wed, Nov 02, 2011 at 02:18:46PM -0700, Eric Anholt wrote: > > On Wed, 2 Nov 2011 11:12:07 +0800, Yuanhan Liu > > wrote: > > > On Tue, Nov 01, 2011 at 05:57:36PM +0800, Yuanhan Liu wrote: > > > > According to bspec, MIPCnt(was set to int

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Theiss, Ingo
> > > > Ok I have added -mfpmath=sse to the 32-bit CFLAGS and the readback > > performance increased from 30.44 Mpixels/sec to 48.92 Mpixel/sec. We > > are getting closer to the 64-bit performance. > > hmm. you should try -msse2 too. It's implied on 64bits, and I'm not sure if > -march/-mfpmath

Re: [Mesa-dev] [PATCH 2/2] xlib: set alpha to 0xff when mapping RGB pixmaps

2011-11-11 Thread Eric Anholt
On Thu, 10 Nov 2011 18:01:47 -0700, Brian Paul wrote: > Fixes a bunch of conform regressions. > --- > src/mesa/drivers/x11/xm_buffer.c | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/drivers/x11/xm_buffer.c > b/src/mesa/drivers/x11/xm_buffer.c >

Re: [Mesa-dev] [PATCH 13/17] swrast: Drop the global mapping of buffers across glReadPixels().

2011-11-11 Thread Eric Anholt
On Thu, 10 Nov 2011 15:13:48 +, Dave Airlie wrote: > On Tue, Nov 1, 2011 at 11:17 PM, Eric Anholt wrote: > > Reviewed-by: Brian Paul > > Just as an aside and maybe some way to help me figure out why > > this break piglit windowoverlap test on r100, specifically the sub > window drawing sto

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Michel Dänzer
On Fre, 2011-11-11 at 06:52 -0800, Jose Fonseca wrote: > > - Original Message - > > > > Am Freitag, 11. November 2011 14:33 CET, Michel Dänzer > > schrieb: > > > > > On Fre, 2011-11-11 at 14:15 +0100, Theiss, Ingo wrote: > > > > > > > > Here are the compiler flags used. > > > > > >

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Jose Fonseca
- Original Message - > > Am Freitag, 11. November 2011 14:33 CET, Michel Dänzer > schrieb: > > > On Fre, 2011-11-11 at 14:15 +0100, Theiss, Ingo wrote: > > > Am Freitag, 11. November 2011 12:09 CET, Michel Dänzer > > > schrieb: > > > > > > > So It makes sense to find a glReadPixels

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Theiss, Ingo
Am Freitag, 11. November 2011 14:33 CET, Michel Dänzer schrieb: > On Fre, 2011-11-11 at 14:15 +0100, Theiss, Ingo wrote: > > Am Freitag, 11. November 2011 12:09 CET, Michel Dänzer > > schrieb: > > > > > So It makes sense to find a glReadPixels in VirtualGL's glxSwapBuffers. > > > > > >

Re: [Mesa-dev] The current status of the gallium vmwgfx driver

2011-11-11 Thread Treviño
Jakob Bornecrantz vmware.com> writes: > We are working on improving the driver and as such have reorganized > the driver, deprecated a couple of things, moved things around and > require the latest Fusion/Workstation/Player release[1] to get 3D. > 2D only will work just fine with a older release.

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Brian Paul
2011/11/11 Michel Dänzer : > Anyway, I guess there's room for optimization in glReadPixels... Ingo, if you could find out what the format/type parameters to glReadPixels are, we could look into some optimization in the state tracker. I wouldn't be surprised if there's some channel swizzling or f

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Michel Dänzer
On Fre, 2011-11-11 at 14:15 +0100, Theiss, Ingo wrote: > Am Freitag, 11. November 2011 12:09 CET, Michel Dänzer > schrieb: > > > So It makes sense to find a glReadPixels in VirtualGL's glxSwapBuffers. > > > > Ah. I thought the time measurements in Ingo's original post were for the > > Mesa gl

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Theiss, Ingo
Am Freitag, 11. November 2011 12:09 CET, Michel Dänzer schrieb: > So It makes sense to find a glReadPixels in VirtualGL's glxSwapBuffers. > > Ah. I thought the time measurements in Ingo's original post were for the > Mesa glXSwapBuffers, not the VirtualGL one. If it's the latter, then > this

[Mesa-dev] Makedepend running forever on Fedora 16

2011-11-11 Thread Thomas Hellstrom
Hi, all The commit commit 63e7a4c6e5bf51d8090046ebc5adcb4207448565 Author: José Fonseca Date: Wed Nov 9 10:20:51 2011 + mesa,glsl,mapi: Put extern "C" { ... } where appropriate. Probably a several places missing, but enough to cover all headers (in)directly included by unifo

[Mesa-dev] [PATCH] glcpp: Add GL_ARB_draw_instanced #define.

2011-11-11 Thread Morgan Armand
--- src/glsl/glcpp/glcpp-parse.y |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 1b17ff4..c0457b0 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@ -1132,6 +1132,9 @@ glcpp_pa

Re: [Mesa-dev] Performance glxSwapBuffers 32 bit vs. 64 bit

2011-11-11 Thread Michel Dänzer
On Fre, 2011-11-11 at 07:35 +0100, Mathias Fröhlich wrote: > On Thursday, November 10, 2011 18:42:13 Michel Dänzer wrote: > > On Don, 2011-11-10 at 11:01 +0100, Theiss, Ingo wrote: > > > The function calls of mesa/state_tracker/st_cb_readpixels.c:382 -> > > > st_readpixels and mesa/main/pack.c:552

[Mesa-dev] [PATCH 2/3] glsl: Split code to generate an ir_call out from match_function_by_name.

2011-11-11 Thread Kenneth Graunke
match_function_by_name performs two fairly separate tasks: 1. Hunt down the appropriate ir_function_signature for the callee. 2. Generate the actual ir_call (assuming we found the callee). Both of these are complicated. The first has to handle exact/inexact matches, lazy importing of built-in pro

[Mesa-dev] [PATCH 3/3] glsl: Always search for an exact function signature match.

2011-11-11 Thread Kenneth Graunke
Previously, we would fail to compile the following shader due to a bug in lazy built-in importing: #version 130 void main() { float f = abs(5.0); int i = abs(5); } The first call, abs(5.0), would fail to find a local signature, look through the built-ins, and import "f

[Mesa-dev] [PATCH 1/3] glsl: Add a new matching_signature() variant that returns exact/inexact.

2011-11-11 Thread Kenneth Graunke
When matching function signatures across multiple linked shaders, we often want to see if the current shader has _any_ match, but also know whether or not it was exact. (If not, we may want to keep looking.) This could be done via the existing mechanisms: sig = f->exact_matching_signature(par

[Mesa-dev] Lazy GLSL built-in importing bug fix

2011-11-11 Thread Kenneth Graunke
While looking at some oglconform failures the other day, I noticed some of their shaders were trying to use % on a float and failing to compile. It turned out to be a nasty bug in my lazy built-in importing code. The shader was calling abs() on an int, but we selected abs(float) instead of abs(in

[Mesa-dev] [PATCH] i965: Don't try to normalize cubemap coordinates for textureSize.

2011-11-11 Thread Kenneth Graunke
Although textureSize is represented as an ir_texture with op == ir_txs, it doesn't have a coordinate, so normalizing it doesn't make sense. Fixes crashes in oglconform glsl-bif-tex-size basic.samplerCube.* tests. Signed-off-by: Kenneth Graunke --- .../drivers/dri/i965/brw_cubemap_normalize.cpp