Re: [Mesa-dev] [PATCH 2/2] i965: fix the wrong min/max_index for nr_prims 1

2011-12-29 Thread Michel Dänzer
On Don, 2011-12-29 at 10:03 +0800, Yuanhan Liu wrote: On Wed, Dec 28, 2011 at 12:07:08PM -0800, Eric Anholt wrote: On Wed, 28 Dec 2011 13:54:43 +0800, Yuanhan Liu yuanhan@linux.intel.com wrote: The current code would just calculate min/max_index for the first prim unconditionally,

[Mesa-dev] llvmpipe vs fbo-alphatest-formats

2011-12-29 Thread Dave Airlie
Hi guys, was doing some piglit comparisons between softpipe and llvmpipe and noticed the fbo-alphatest-formats test fails on llvmpipe for all the I8 formats. Now I looked at the code generated for lp_tile_soa.c:lp_tile_i8_unorm_unswizzle_4ub and it references a[i+0] and a[i+1], if I change it to

[Mesa-dev] [PATCH 2/2] gallium: improves glsl_to_tgsi generation of ARL

2011-12-29 Thread Vincent Lejeune
This commit should generates less ARL instructions when dealing with indirect addressing. v2: fix glsl-fs-uniform-array-4 piglit test --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 56 +--- 1 files changed, 34 insertions(+), 22 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] llvmpipe: Remove useless draw_install_pstipple_stage call.

2011-12-29 Thread Jose Fonseca
- Original Message - It is #ifdef'd out, and is already called unconditionnaly a couple lines above. --- src/gallium/drivers/llvmpipe/lp_context.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_context.c

Re: [Mesa-dev] [PATCH] r600g: Manage fences per screen rather than per context.

2011-12-29 Thread Michel Dänzer
On Don, 2011-12-29 at 14:57 +0100, Mathias Fröhlich wrote: On Thursday, December 29, 2011 13:35:19 Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=44151 Probably fixes:

Re: [Mesa-dev] [PATCH 2/3] vl: seperate shader buffers from components

2011-12-29 Thread Maarten Lankhorst
Hey, Op 26-12-11 14:00, Christian König schreef: Buffers for shader based decoding can now be released without its component still being around. Signed-off-by: Christian König deathsim...@vodafone.de Looks good to me. Acked-by: Maarten Lankhorst m.b.lankho...@gmail.com ~Maarten

[Mesa-dev] [PATCH 1/7] i965: Fix transform feedback of gl_PointSize.

2011-12-29 Thread Paul Berry
On i965 Gen6 and above, gl_PointSize is stored in component W of the first VUE slot (which corresponds to VERT_RESULT_PSIZ in the VUE map). Normally we store varying floats in component X of a VUE slot, so we need special case logic for gl_PointSize. For Gen6, we do this with a . swizzle in

[Mesa-dev] [PATCH 1/2] gallium: dereference are now handled by a separate visitor in glsl_to_tgsi

2011-12-29 Thread Vincent Lejeune
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 453 ++-- 1 files changed, 294 insertions(+), 159 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 59ecb52..3523159 100644 ---

[Mesa-dev] [PATCH] swrast: Remove dead code in _swrast_clear_depth_buffer()

2011-12-29 Thread Paul Berry
This code was generating the gcc warning: variable ‘clearValue’ set but not used [-Wunused-but-set-variable] --- src/mesa/swrast/s_depth.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/src/mesa/swrast/s_depth.c b/src/mesa/swrast/s_depth.c index

[Mesa-dev] [RFC] glsl-to-tgsi ARL generator small improvements

2011-12-29 Thread Vincent Lejeune
Hi, These patches reworks sightly glsl-to-tgsi ir_dereference* visitor. The first one is self explanatory. The second one factor ir_dereference* in a separate visitor ; by itself, this change does not bring anything to code generation, however it should make easier to handle case where variable

[Mesa-dev] [PATCH 2/7] i965: Fix transform feedback of gl_ClipVertex.

2011-12-29 Thread Paul Berry
Previously, on i965 Gen6 and above, we weren't allocating space for gl_ClipVertex in the VUE, since the VS was automatically converting it to clip distances. This prevented transform feedback from being able to capture gl_ClipVertex. This patch goes aheads and allocates space for gl_ClipVertex

[Mesa-dev] [PATCH 6/7] mesa: Make tfeedback_decl::var_name a const char *.

2011-12-29 Thread Paul Berry
--- src/glsl/linker.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 452d8b5..6def821 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -1420,7 +1420,7 @@ private: /** * The name of the variable,

[Mesa-dev] [Bug 43332] corrupted output in mesa-demo/fp-tri using r600g

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43332 Michel Dänzer mic...@daenzer.net changed: What|Removed |Added AssignedTo|dri-devel@lists.freedesktop

[Mesa-dev] [PATCH] r600g: Manage fences per screen rather than per context.

2011-12-29 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=44151 Probably fixes: https://bugs.freedesktop.org/show_bug.cgi?id=44007 https://bugs.freedesktop.org/show_bug.cgi?id=43993 Signed-off-by: Michel Dänzer michel.daen...@amd.com ---

[Mesa-dev] [PATCH 5/7] gallium: Make use of gl_transform_feedback_info::ComponentOffset.

2011-12-29 Thread Paul Berry
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 77aa0d1..d337f9b 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++

[Mesa-dev] [PATCH] glsl: fix usage of potentially undefined data_end union

2011-12-29 Thread Alexander von Gluck
--- src/glsl/link_uniforms.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index c7de480..b331db7 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_uniforms.cpp @@ -365,9 +365,9 @@

Re: [Mesa-dev] [PATCH] r600g: Manage fences per screen rather than per context.

2011-12-29 Thread Mathias Fröhlich
Hi, On Thursday, December 29, 2011 13:35:19 Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=44151 Probably fixes: https://bugs.freedesktop.org/show_bug.cgi?id=44007

[Mesa-dev] [PATCH 1/3] gallium: create a new variable_store class replacing variables field in glsl_to_tgsi_visitor

2011-12-29 Thread Vincent Lejeune
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 37 ++-- 1 files changed, 24 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 77aa0d1..59ecb52 100644 ---

Re: [Mesa-dev] [PATCH] r600g: Manage fences per screen rather than per context.

2011-12-29 Thread Mathias Fröhlich
Hi, On Thursday, December 29, 2011 15:34:24 Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com A fence is a screen object and can outlive the context it was created from. The previous code would access freed memory in that case, resulting in various problems. Fixes:

[Mesa-dev] [PATCH] gallium: use Haiku provided debug_printf in OS.h

2011-12-29 Thread Alexander von Gluck
--- src/gallium/auxiliary/util/u_debug.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index b5ea405..448d799 100644 --- a/src/gallium/auxiliary/util/u_debug.h +++

[Mesa-dev] [PATCH 4/7] i965: Make use of gl_transform_feedback_info::ComponentOffset.

2011-12-29 Thread Paul Berry
--- src/mesa/drivers/dri/i965/brw_gs.c |9 + src/mesa/drivers/dri/i965/brw_gs.h |7 +++ src/mesa/drivers/dri/i965/brw_gs_emit.c|2 +- src/mesa/drivers/dri/i965/gen7_sol_state.c |2 ++ 4 files changed, 19 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] gallium: improves glsl_to_tgsi generation of ARL

2011-12-29 Thread Vincent Lejeune
This commit should generates less ARL instructions when dealing with indirect addressing. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 56 +--- 1 files changed, 34 insertions(+), 22 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 2/3] gallium: dereference are now handled by a separate visitor in glsl_to_tgsi

2011-12-29 Thread Vincent Lejeune
--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 455 ++-- 1 files changed, 296 insertions(+), 159 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 59ecb52..becb774 100644 ---

Re: [Mesa-dev] [PATCH] util: u_gen_mipmap: use software path for small mipmap levels

2011-12-29 Thread Lucas Stach
Ok, disregard this patch. I see this is a bad idea and will fix the issue in another way in nvfx. Thanks, Lucas Am Donnerstag, den 29.12.2011, 01:12 +0100 schrieb Marek Olšák: HI Lucas, The fallback will be slower on Radeons for these two reasons: - Texture transfers are implemented using

Re: [Mesa-dev] [PATCH 5/7] gallium: Make use of gl_transform_feedback_info::ComponentOffset.

2011-12-29 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com On Thu, Dec 29, 2011 at 6:16 PM, Paul Berry stereotype...@gmail.com wrote: ---  src/mesa/state_tracker/st_glsl_to_tgsi.cpp |    3 ++-  1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin varyings.

2011-12-29 Thread Paul Berry
On 29 December 2011 09:16, Paul Berry stereotype...@gmail.com wrote: Arguments in favor: (1) Because of transform feedback's intended use and its position in the pipeline, the distinction between varyings and other vertex shader outputs is irrelevant; in all likelihood the spec writers

[Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin varyings.

2011-12-29 Thread Paul Berry
This patch series allows transform feedback to work properly on the built-in vertex shader output variables gl_PointSize, gl_ClipVertex, and gl_ClipDistance. gl_PointSize and gl_ClipVertex were broken due to bugs in the i965 driver, and were trivial to fix--those are fixed in patches 1 and 2.

Re: [Mesa-dev] [PATCH 3/3] vl: replace decode_buffers with auxiliary data field

2011-12-29 Thread Maarten Lankhorst
Hey Christian, Op 26-12-11 14:00, Christian König schreef: Based on patches from Maarten Lankhorst m.b.lankho...@gmail.com Signed-off-by: Christian König deathsim...@vodafone.de diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index de79a9b..f7ee522

[Mesa-dev] [PATCH] r600g: Manage fences per screen rather than per context.

2011-12-29 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com A fence is a screen object and can outlive the context it was created from. The previous code would access freed memory in that case, resulting in various problems. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=44151 Probably fixes:

Re: [Mesa-dev] [PATCH 1/3] intel: Fix bad read/write flags on self-copies for glCopyBufferSubData().

2011-12-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/28/2011 11:14 AM, Eric Anholt wrote: We didn't consume these flags in any way that would produce a functional difference, but we might have some day. --- src/mesa/drivers/dri/intel/intel_buffer_objects.c |4 +++- 1 files changed, 3

Re: [Mesa-dev] [PATCH 2/3] intel: Fix pitch handling for linear blits.

2011-12-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/28/2011 11:14 AM, Eric Anholt wrote: The new assert in intelEmitCopyBlit() gets angry if we don't align to dwords. Rather than make the assert have a special case for height == 1 on the assumption that the hardware doesn't use it in that

[Mesa-dev] [Bug 42645] Graphics issues on BZFlag 2.4.0 with i915g (gallium)

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42645 --- Comment #3 from Stephane Marchesin marche...@icps.u-strasbg.fr 2011-12-29 12:21:52 PST --- Can you retry with git mesa? It might be fixed by my recent changes. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email

[Mesa-dev] [PATCH 1/3] mesa: Use BITFIELD64_RANGE for VERT_BIT_*_ALL.

2011-12-29 Thread Mathias Fröhlich
Signed-off-by: Mathias Fröhlich mathias.froehl...@web.de --- src/mesa/main/mtypes.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 107371e..451d442 100644 --- a/src/mesa/main/mtypes.h +++

[Mesa-dev] [PATCH 2/3] mesa: Introduce enabled bitfield helper functions.

2011-12-29 Thread Mathias Froehlich
Depending on the installed shader type, different arrays are used from gl_array_object. Provide helper functions that compute the bitmask of these arrays that are finally enabled for a given shader type. The will be used in a followup change. Signed-off-by: Mathias Fröhlich

[Mesa-dev] [PATCH 3/3] mesa: Clean up gl_array_object::_MaxElement computation.

2011-12-29 Thread Mathias Fröhlich
Use a bitmask approach to compute gl_array_object::_MaxElement. To make this work reliably depending on the shader type actually used, make use of the newly introduced typed bitmaks getters. With this change I gain about 5% draw time on some osgviewer examples. Signed-off-by: Mathias Fröhlich

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2011-12-29 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/20/2011 12:31 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This adds a new tests directory at the top-level and some extra build infrastructure. The tests use the Google C++ Testing Framework, and they will only be

[Mesa-dev] [Bug 39017] [bisected] Segfault in Gallium drivers in Mupen64Plus

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39017 --- Comment #6 from Peter Ward peteraw...@gmail.com 2011-12-29 16:33:45 PST --- Created attachment 54965 -- https://bugs.freedesktop.org/attachment.cgi?id=54965 gdb session I'm also getting this crash. I've attached a log from gdb showing the

[Mesa-dev] [Bug 39017] [bisected] Segfault in Gallium drivers in Mupen64Plus

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39017 Peter Ward peteraw...@gmail.com changed: What|Removed |Added CC||peteraw...@gmail.com

[Mesa-dev] [Bug 44298] SIGSEGV src/mesa/state_tracker/st_cb_blit.c:87

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44298 Vinson Lee v...@vmware.com changed: What|Removed |Added AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 44298] SIGSEGV src/mesa/state_tracker/st_cb_blit.c:87

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44298 --- Comment #2 from Stephane Marchesin marche...@icps.u-strasbg.fr 2011-12-29 17:29:28 PST --- I think it's a similar problem to the one discussed in http://lists.freedesktop.org/archives/mesa-dev/2011-September/011578.html The bug will affect

[Mesa-dev] [Bug 42645] Graphics issues on BZFlag 2.4.0 with i915g (gallium)

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42645 --- Comment #4 from Christian Inci chris.pcguy.i...@gmail.com 2011-12-29 22:08:36 PST --- I've already tested earlier the day if this bug still occurs. It won't. :-) But another bug still does: With the classic driver (i915) the main menu is

[Mesa-dev] [Bug 42645] Graphics issues on BZFlag 2.4.0 with i915g (gallium)

2011-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42645 Stephane Marchesin marche...@icps.u-strasbg.fr changed: What|Removed |Added Status|NEW |RESOLVED