[Mesa-dev] [PATCH] mesa: Silence GCC unused variable warnings.

2012-01-03 Thread Vinson Lee
Silences these GCC warnings. warning: unused variable 'texelBytes' Signed-off-by: Vinson Lee --- src/mesa/main/texstore.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index bb2fe25..

[Mesa-dev] [PATCH] mesa: Silence GCC unused variable warnings.

2012-01-03 Thread Vinson Lee
Silences these GCC warnings. warning: unused variable 'texelBytes' Signed-off-by: Vinson Lee --- src/mesa/main/texstore.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index bb2fe25..

[Mesa-dev] [PATCH] glsl: Add a lowering pass to remove reads of shader output variables.

2012-01-03 Thread Kenneth Graunke
From: Vincent Lejeune This is similar to Gallium's existing glsl_to_tgsi::remove_output_read lowering pass, but done entirely inside the GLSL compiler. Signed-off-by: Vincent Lejeune Signed-off-by: Kenneth Graunke --- src/glsl/Makefile.sources |1 + src/glsl/ir_optimization.h |

Re: [Mesa-dev] [PATCH 1/2] mesa: XCB is no longer optional for GLX or DRI

2012-01-03 Thread Kenneth Graunke
On 01/02/2012 05:44 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > configure.ac | 28 ++-- > 1 files changed, 6 insertions(+), 22 deletions(-) At some point, you'll want to check for libxcb >= 1.8, i.e. a version that has the new

Re: [Mesa-dev] [PATCH 1/2] mesa: XCB is no longer optional for GLX or DRI

2012-01-03 Thread Dave Airlie
On Tue, Jan 3, 2012 at 10:25 AM, Kenneth Graunke wrote: > On 01/02/2012 05:44 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >>  configure.ac |   28 ++-- >>  1 files changed, 6 insertions(+), 22 deletions(-) > > At some point, you'l

[Mesa-dev] [Bug 44407] git mesa/src/glx fails to compile

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44407 Kenneth Graunke changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

Re: [Mesa-dev] [PATCH] glsl: Add a lowering pass to remove reads of shader output variables.

2012-01-03 Thread Dave Airlie
On Tue, Jan 3, 2012 at 10:08 AM, Kenneth Graunke wrote: > From: Vincent Lejeune > > This is similar to Gallium's existing glsl_to_tgsi::remove_output_read > lowering pass, but done entirely inside the GLSL compiler. > > Signed-off-by: Vincent Lejeune > Signed-off-by: Kenneth Graunke All 3 work

[Mesa-dev] [Bug 35945] GLX contexts are not resized properly when using XCBOwnsEventQueue

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35945 Uli Schlachter changed: What|Removed |Added CC||psyc...@znc.in -- Configure bugmail: h

[Mesa-dev] [Bug 35945] GLX contexts are not resized properly when using XCBOwnsEventQueue

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35945 Uli Schlachter changed: What|Removed |Added Attachment #45213|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 1/2] mesa: XCB is no longer optional for GLX or DRI

2012-01-03 Thread Laurent Carlier
> On Tue, Jan 3, 2012 at 10:25 AM, Kenneth Graunke > wrote: > > On 01/02/2012 05:44 PM, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> Signed-off-by: Ian Romanick > >> --- > >> configure.ac | 28 ++-- > >> 1 files changed, 6 insertions(+), 22 deletions(-) > > >

[Mesa-dev] [Bug 43125] [bisected] Start screen in Amnesia too dark after "Rewrite the way uniforms are tracked and handled" commit

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43125 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH] mesa: Silence GCC unused variable warnings.

2012-01-03 Thread Brian Paul
On 01/03/2012 01:03 AM, Vinson Lee wrote: Silences these GCC warnings. warning: unused variable 'texelBytes' Signed-off-by: Vinson Lee --- src/mesa/main/texstore.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texstore

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Brian Paul
On 01/02/2012 10:37 PM, Paul Berry wrote: --- src/mesa/main/shaderapi.c |2 +- src/mesa/main/transformfeedback.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index b71b44b..52a9bd4 100644 --- a/src/

[Mesa-dev] [PATCH] gallium: use Haiku provided debug_printf in OS.h

2012-01-03 Thread Alexander von Gluck
--- src/gallium/auxiliary/util/u_debug.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_debug.h b/src/gallium/auxiliary/util/u_debug.h index b5ea405..3aa6aaf 100644 --- a/src/gallium/auxiliary/util/u_debug.h +++ b/src/gallium/auxiliary

Re: [Mesa-dev] [PATCH] gallium: fix behavior of pipe_buffer_map_range

2012-01-03 Thread Brian Paul
On Sun, Jan 1, 2012 at 10:27 AM, Marek Olšák wrote: > To match what transfer_map returns. Really, subtracting the offset leads > to bugs if someone expects it to work exactly like transfer_map. > --- >  src/gallium/auxiliary/util/u_inlines.h       |    7 ++- >  src/gallium/auxiliary/util/u_upl

Re: [Mesa-dev] [PATCH] gallium: use Haiku provided debug_printf in OS.h

2012-01-03 Thread Brian Paul
On Tue, Jan 3, 2012 at 7:56 AM, Alexander von Gluck wrote: > --- >  src/gallium/auxiliary/util/u_debug.h |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_debug.h > b/src/gallium/auxiliary/util/u_debug.h > index b5ea405..3aa6aaf 100644

[Mesa-dev] [Bug 42131] Problem with resizing OpenGL windows when using XCB

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42131 Alex Deucher changed: What|Removed |Added AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH] u_upload_mgr: remove the 'flushed' parameter

2012-01-03 Thread Brian Paul
On Sun, Jan 1, 2012 at 10:28 AM, Marek Olšák wrote: > Not used by anybody. > --- >  src/gallium/auxiliary/util/u_upload_mgr.c        |   15 --- >  src/gallium/auxiliary/util/u_upload_mgr.h        |    7 ++- >  src/gallium/auxiliary/util/u_vbuf.c              |    6 ++ >  src/ga

[Mesa-dev] Haiku Mesa status

2012-01-03 Thread Alexander von Gluck
Good morning! I really appreciate Mesa being open to accepting the Haiku patches. The Haiku support is close to done. Given the current patches applied (plus a few small tweaks mentioned below), Mesa (and a few Gallium drivers!) build under Haiku. Here is whats left for the basic build...

Re: [Mesa-dev] Haiku Mesa status

2012-01-03 Thread Jakob Bornecrantz
- Original Message - > Good morning! > > I really appreciate Mesa being open to accepting the Haiku patches. Glad to hear. > > The Haiku support is close to done. Given the current patches applied > (plus a few small tweaks mentioned below), Mesa (and a few Gallium > drivers!) build und

Re: [Mesa-dev] [PATCH 3/3] vl: replace decode_buffers with auxiliary data field

2012-01-03 Thread Maarten Lankhorst
Hi Christian, 2012/1/2 Christian König : > Hi Maarten, > > first of all: Happy new Year and sorry for the late reply, have been on > vacation for the last week. > > > On 29.12.2011 16:41, Maarten Lankhorst wrote: >> >> Hey Christian, >> >> Op 26-12-11 14:00, Christian König schreef: >>> >>> Based

[Mesa-dev] [Bug 42131] Problem with resizing OpenGL windows when using XCB

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42131 --- Comment #2 from ikrabbe@gmail.com 2012-01-03 08:03:49 PST --- Created attachment 55087 --> https://bugs.freedesktop.org/attachment.cgi?id=55087 Demonstration how it may work This program is a bit bigger, than actually needed for this bu

[Mesa-dev] [Bug 42131] Problem with resizing OpenGL windows when using XCB

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42131 --- Comment #3 from ikrabbe@gmail.com 2012-01-03 08:07:48 PST --- Created attachment 55088 --> https://bugs.freedesktop.org/attachment.cgi?id=55088 Complete with Makefile Edit the MESA and XCB Variables in the Makefile or optionally in your

Re: [Mesa-dev] [PATCH] softpipe: remove the 32bits limitation on depth(-stencil) formats

2012-01-03 Thread Dave Airlie
On Wed, Dec 7, 2011 at 8:30 PM, Morgan Armand wrote: > This patch remove the 32bits limitation. As a side effect, it bring the > support for the GL_ARB_depth_buffer_float extension. > No regression have been found on piglit, and all tests for > GL_ARB_depth_buffer_float pass successfully. Just

[Mesa-dev] [PATCH] Add .gitignore files to exclude unit test build artifacts from git

2012-01-03 Thread Paul Berry
With the addition of unit tests in commit 3ef3ba4d2eee36f64062a21ce030c3f4d8c4cac4, several additional build artifacts are created: bin/depcomp bin/missing tests/Makefile tests/Makefile.in tests/glx/Makefile tests/glx/Makefile.in tests/glx/.deps/ This patch adds all of these files t

[Mesa-dev] [Bug 44405] Spring RTS crashes using r600g (5670, Redwood), kernel rejects relocations

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44405 Michel Dänzer changed: What|Removed |Added AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] mesa: Remove 'texelBytes' declarations that are only used in assertions.

2012-01-03 Thread Vinson Lee
This patch also silences these GCC warnings. warning: unused variable 'texelBytes' Signed-off-by: Vinson Lee --- src/mesa/main/texstore.c | 68 -- 1 files changed, 0 insertions(+), 68 deletions(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/mai

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Mike Lothian
Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing something stupid? Cheers Mike _

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-03 Thread Roland Scheidegger
Ah index scanning... I don't like that this will map/unmap the ib once for each prim, though I don't really see a nice way to avoid that (I think if you have to actually map the ib, you lose anyway). Hopefully won't hit that performance hog often... A comment inline. Am 31.12.2011 07:32, schrieb

Re: [Mesa-dev] softpipe and tgsi_exec.c FAST_MATH

2012-01-03 Thread Roland Scheidegger
Am 31.12.2011 17:46, schrieb Dave Airlie: > Hi, > > So in the interest of correctness > perf wrt softpipe, flicking > tgsi_exec.c FAST_MATH to 0 fixes 15 piglit tests with 0 regressions, > > I could probably be persuaded to make a SOFTPIPE_FAST_MATH run time > set to 0 by default, anyone care one

Re: [Mesa-dev] [PATCH] Add .gitignore files to exclude unit test build artifacts from git

2012-01-03 Thread Ian Romanick
On 01/03/2012 08:19 AM, Paul Berry wrote: With the addition of unit tests in commit 3ef3ba4d2eee36f64062a21ce030c3f4d8c4cac4, several additional build artifacts are created: bin/depcomp bin/missing tests/Makefile tests/Makefile.in tests/glx/Makefile tests/glx/Makefile.in tes

[Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-03 Thread Adam Jackson
There's no reason to only force the visual to be on the default screen, and in fact good reason not to. Signed-off-by: Adam Jackson --- src/glx/drisw_glx.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index 2d83a50..833ea7d

Re: [Mesa-dev] [PATCH] mesa: Remove 'texelBytes' declarations that are only used in assertions.

2012-01-03 Thread Stéphane Marchesin
As far as I know, this check has value, why not replace the assert with something like ASSERT(_mesa_get_format_bytes(dstFormat) == sizeof(GLuint)); instead? That would silence the warning but keep the check. Stéphane On Tue, Jan 3, 2012 at 10:54, Vinson Lee wrote: > This patch also silences the

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Ian Romanick
On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status: error: cannot find input file: `tests/Makefile.in' Before I raise a bug am I doing somethi

[Mesa-dev] [PATCH] glx: More hacking around versions of XCB that lack GLX_ARB_create_context support

2012-01-03 Thread Ian Romanick
From: Ian Romanick Detect whether a new enough version of XCB is installed at configure time. If it is not, don't enable the extension and don't build the unit tests. Signed-off-by: Ian Romanick --- Using this patch, I was able to successfully build and run both with and without updated XCB bi

Re: [Mesa-dev] [PATCH] glsl: Add a lowering pass to remove reads of shader output variables.

2012-01-03 Thread Ian Romanick
On 01/03/2012 02:08 AM, Kenneth Graunke wrote: From: Vincent Lejeune This is similar to Gallium's existing glsl_to_tgsi::remove_output_read lowering pass, but done entirely inside the GLSL compiler. Signed-off-by: Vincent Lejeune Signed-off-by: Kenneth Graunke Reviewed-by: Ian Romanick Now

Re: [Mesa-dev] [PATCH] mesa: Remove 'texelBytes' declarations that are only used in assertions.

2012-01-03 Thread Ian Romanick
On 01/03/2012 12:23 PM, Stéphane Marchesin wrote: As far as I know, this check has value, why not replace the assert with something like ASSERT(_mesa_get_format_bytes(dstFormat) == sizeof(GLuint)); instead? That would silence the warning but keep the check. I was going to suggest exactly the sa

[Mesa-dev] [PATCH] mesa/main: fix incorrect use of _mesa_ffsll. _mesa_ffsll may or may not be defined on GNUC

2012-01-03 Thread Alexander von Gluck
--- src/mesa/main/arrayobj.c |2 +- src/mesa/main/imports.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 4b3e07b..29bfed8 100644 --- a/src/mesa/main/arrayobj.c +++ b/src/mesa/main/arrayobj.c @@ -303,7 +303

Re: [Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-03 Thread Ian Romanick
On 01/03/2012 11:40 AM, Adam Jackson wrote: There's no reason to only force the visual to be on the default screen, and in fact good reason not to. Is the visual ID enough information to uniquely identify it? I may be mistaken (and horribly ignorant in this area), but I thought the visual ID

Re: [Mesa-dev] [PATCH] Add .gitignore files to exclude unit test build artifacts from git

2012-01-03 Thread Paul Berry
On 3 January 2012 11:28, Ian Romanick wrote: > On 01/03/2012 08:19 AM, Paul Berry wrote: > >> With the addition of unit tests in commit >> 3ef3ba4d2eee36f64062a21ce030c3**f4d8c4cac4, several additional build >> artifacts are created: >> >> bin/depcomp >> bin/missing >> tests/Makefile >> t

Re: [Mesa-dev] [PATCH 2/3] mesa: Check that all buffers are bound in BeginTransformFeedback.

2012-01-03 Thread Ian Romanick
On 01/02/2012 09:37 PM, Paul Berry wrote: From the EXT_transform_feedback spec: The error INVALID_OPERATION is generated by BeginTransformFeedbackEXT if any transform feedback buffer object binding point used in transform feedback mode does not have a buffer object bound. T

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Ian Romanick
On 01/02/2012 09:37 PM, Paul Berry wrote: Patches 1/3 and 3/3 are Reviewed-by: Ian Romanick I had a question about 2/3. --- src/mesa/main/shaderapi.c |2 +- src/mesa/main/transformfeedback.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/ma

[Mesa-dev] [PATCH] Add .gitignore files to exclude unit test build artifacts from git

2012-01-03 Thread Paul Berry
With the addition of unit tests in commit 3ef3ba4d2eee36f64062a21ce030c3f4d8c4cac4, several additional build artifacts are created: bin/depcomp bin/missing tests/Makefile tests/Makefile.in tests/glx/Makefile tests/glx/Makefile.in tests/glx/.deps/ tests/glx/.gitignore This patch ad

Re: [Mesa-dev] [PATCH 2/3] mesa: Check that all buffers are bound in BeginTransformFeedback.

2012-01-03 Thread Paul Berry
On 3 January 2012 12:57, Ian Romanick wrote: > On 01/02/2012 09:37 PM, Paul Berry wrote: > >> From the EXT_transform_feedback spec: >> >> The error INVALID_OPERATION is generated by >> BeginTransformFeedbackEXT if any transform feedback buffer object >> binding point used in transfor

[Mesa-dev] [PATCH] mesa: Avoid segfault when getting an unbound transform feedback buffer name.

2012-01-03 Thread Paul Berry
Previously we were using gl_transform_feedback_object::Buffers[i]->Name to service an indexed get request for GL_TRANSFORM_FEEDBACK_BUFFER_BINDING. However, if no buffer has been bound, gl_transform_feedback_object::Buffers[i] is NULL, so this was causing a segfault. This patch switches to using

Re: [Mesa-dev] [PATCH] mesa: Remove 'texelBytes' declarations that are only used in assertions.

2012-01-03 Thread Brian Paul
On 01/03/2012 01:44 PM, Ian Romanick wrote: On 01/03/2012 12:23 PM, Stéphane Marchesin wrote: As far as I know, this check has value, why not replace the assert with something like ASSERT(_mesa_get_format_bytes(dstFormat) == sizeof(GLuint)); instead? That would silence the warning but keep the c

Re: [Mesa-dev] [PATCH] mesa/main: fix incorrect use of _mesa_ffsll. _mesa_ffsll may or may not be defined on GNUC

2012-01-03 Thread Brian Paul
On Tue, Jan 3, 2012 at 1:49 PM, Alexander von Gluck wrote: > --- >  src/mesa/main/arrayobj.c |    2 +- >  src/mesa/main/imports.h  |    2 +- >  2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c > index 4b3e07b..29bfed8 100644 > --

Re: [Mesa-dev] [PATCH 2/3] mesa: Check that all buffers are bound in BeginTransformFeedback.

2012-01-03 Thread Ian Romanick
On 01/03/2012 01:07 PM, Paul Berry wrote: On 3 January 2012 12:57, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 01/02/2012 09:37 PM, Paul Berry wrote: From the EXT_transform_feedback spec: The error INVALID_OPERATION is generated by BeginTransfor

Re: [Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-03 Thread Adam Jackson
On 1/3/12 3:48 PM, Ian Romanick wrote: On 01/03/2012 11:40 AM, Adam Jackson wrote: There's no reason to only force the visual to be on the default screen, and in fact good reason not to. Is the visual ID enough information to uniquely identify it? I may be mistaken (and horribly ignorant in th

Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin "varyings".

2012-01-03 Thread Ian Romanick
On 12/29/2011 09:16 AM, Paul Berry wrote: This patch series allows transform feedback to work properly on the built-in vertex shader output variables gl_PointSize, gl_ClipVertex, and gl_ClipDistance. gl_PointSize and gl_ClipVertex were broken due to bugs in the i965 driver, and were trivial to f

[Mesa-dev] [PATCH] mesa: remove unused _mesa_init_teximage_fields() target parameter

2012-01-03 Thread Brian Paul
--- src/mesa/drivers/dri/intel/intel_tex_image.c |2 +- src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 +- src/mesa/drivers/dri/r200/r200_texstate.c |2 +- src/mesa/drivers/dri/radeon/radeon_texstate.c |2 +- src/mesa/drivers/dri/swrast/swrast.c |2 +- src/

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Mike Lothian
On 3 January 2012 20:27, Ian Romanick wrote: > On 01/03/2012 11:13 AM, Mike Lothian wrote: >> >> Hi >> >> Ever since these tests went in I get failures during configure: >> >> >> configure: creating ./config.status >> config.status: creating configs/autoconf >> config.status: error: cannot find in

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Mike Lothian
On 3 January 2012 20:27, Ian Romanick wrote: > On 01/03/2012 11:13 AM, Mike Lothian wrote: >> >> Hi >> >> Ever since these tests went in I get failures during configure: >> >> >> configure: creating ./config.status >> config.status: creating configs/autoconf >> config.status: error: cannot find in

Re: [Mesa-dev] [PATCH] ff_fragment_shader: Don't generate swizzles for scalar combiner inputs

2012-01-03 Thread Eric Anholt
On Mon, 02 Jan 2012 19:36:25 -0800, Ian Romanick wrote: > On 12/23/2011 10:35 PM, Eric Anholt wrote: > > On Thu, 22 Dec 2011 17:43:57 -0800, "Ian Romanick" > > wrote: > >> From: Ian Romanick > >> > >> There are a couple scenarios where the source could be zero and the > >> operand could be eithe

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Eric Anholt
This series is Reviewed-by: Eric Anholt With this and the fix I have for glGetTransformFeedbackVarying(), I think we should be passing the oglc tests, except for one more case: They try to ask for whole arrays to be fed back, without [] in the declaration. The clearest text I could find on this

Re: [Mesa-dev] [PATCH] mesa: remove unused _mesa_init_teximage_fields() target parameter

2012-01-03 Thread Yuanhan Liu
On Tue, Jan 03, 2012 at 05:48:37PM -0700, Brian Paul wrote: > --- > src/mesa/drivers/dri/intel/intel_tex_image.c |2 +- > src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 +- > src/mesa/drivers/dri/r200/r200_texstate.c |2 +- > src/mesa/drivers/dri/radeon/radeon_texstate.c |

Re: [Mesa-dev] [PATCH] mesa: Avoid segfault when getting an unbound transform feedback buffer name.

2012-01-03 Thread Eric Anholt
On Tue, 3 Jan 2012 14:11:42 -0800, Paul Berry wrote: > Previously we were using > gl_transform_feedback_object::Buffers[i]->Name to service an indexed > get request for GL_TRANSFORM_FEEDBACK_BUFFER_BINDING. However, if no > buffer has been bound, gl_transform_feedback_object::Buffers[i] is > NUL

[Mesa-dev] [PATCH] Bug 44205 - read from pointer after free

2012-01-03 Thread Anuj Phogat
Coverity reported a read from pointer after free defect in src/mesa/drivers/dri/intel/intel_mipmap_tree.c In intel_miptree_all_slices_resolve() function, i = i->next was executing after freeing i. I have defined a temporary variable (next) to store the value of i->next before freeing i Reported-by

Re: [Mesa-dev] RFC [PATCH 0/7] Fix transform feedback of builtin "varyings".

2012-01-03 Thread Paul Berry
On 3 January 2012 16:35, Ian Romanick wrote: > On 12/29/2011 09:16 AM, Paul Berry wrote: > >> This patch series allows transform feedback to work properly on the >> built-in vertex shader output variables gl_PointSize, gl_ClipVertex, >> and gl_ClipDistance. gl_PointSize and gl_ClipVertex were br

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:16, Eric Anholt wrote: > > This series is Reviewed-by: Eric Anholt > > With this and the fix I have for glGetTransformFeedbackVarying(), I > think we should be passing the oglc tests, except for one more case: > They try to ask for whole arrays to be fed back, without [] in

[Mesa-dev] [PATCH 2/2] mesa: Remove the dead Varyings list in the program.

2012-01-03 Thread Eric Anholt
--- src/mesa/main/mtypes.h|1 - src/mesa/main/shaderobj.c |5 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 9f0ef69..39ef245 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2292,7 +2292,6

[Mesa-dev] [PATCH 1/2] mesa: Fix glGetTransformFeedbackVarying().

2012-01-03 Thread Eric Anholt
The current implementation was totally broken -- it was looking in an unpopulated structure for varyings, and trying to do so using the current list of varying names, not the list used at link time. --- src/glsl/linker.cpp | 37 +++-- src/mesa/main/m

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Eric Anholt
On Tue, 3 Jan 2012 18:51:24 -0800, Paul Berry wrote: > On 3 January 2012 18:16, Eric Anholt wrote: > > > > > This series is Reviewed-by: Eric Anholt > > > > With this and the fix I have for glGetTransformFeedbackVarying(), I > > think we should be passing the oglc tests, except for one more cas

[Mesa-dev] [Bug 44217] vertex attribute 0 inconsistencies.

2012-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44217 Anuj Phogat changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop. |anuj.pho...@gmail.com |o

Re: [Mesa-dev] [PATCH] Bug 44205 - read from pointer after free

2012-01-03 Thread Eric Anholt
On Tue, 3 Jan 2012 18:36:22 -0800, Anuj Phogat wrote: > Coverity reported a read from pointer after free defect in > src/mesa/drivers/dri/intel/intel_mipmap_tree.c > In intel_miptree_all_slices_resolve() function, i = i->next was > executing after freeing i. I have defined a temporary variable >

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:56, Eric Anholt wrote: > On Tue, 3 Jan 2012 18:51:24 -0800, Paul Berry > wrote: > > On 3 January 2012 18:16, Eric Anholt wrote: > > > > > > > > This series is Reviewed-by: Eric Anholt > > > > > > With this and the fix I have for glGetTransformFeedbackVarying(), I > > > thi

[Mesa-dev] Cross Compile Arm

2012-01-03 Thread Fabio Ferreira
I am Brazilian, how configure plataform to cross compile mesa for the ARM platform ? I am use Ubuntu. Download all basic archives and headers, libs, etc. Help me___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [Mesa-dev] [PATCH] Bug 44205 - read from pointer after free

2012-01-03 Thread Ian Romanick
On 01/03/2012 06:36 PM, Anuj Phogat wrote: Coverity reported a read from pointer after free defect in src/mesa/drivers/dri/intel/intel_mipmap_tree.c In intel_miptree_all_slices_resolve() function, i = i->next was executing after freeing i. I have defined a temporary variable (next) to store the v

Re: [Mesa-dev] [PATCH] mesa: remove unused _mesa_init_teximage_fields() target parameter

2012-01-03 Thread Ian Romanick
On 01/03/2012 04:48 PM, Brian Paul wrote: Reviewed-by: Ian Roamnick --- src/mesa/drivers/dri/intel/intel_tex_image.c |2 +- src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 +- src/mesa/drivers/dri/r200/r200_texstate.c |2 +- src/mesa/drivers/dri/radeon/radeon_texstate

Re: [Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-03 Thread Ian Romanick
On 01/03/2012 04:33 PM, Adam Jackson wrote: On 1/3/12 3:48 PM, Ian Romanick wrote: On 01/03/2012 11:40 AM, Adam Jackson wrote: There's no reason to only force the visual to be on the default screen, and in fact good reason not to. Is the visual ID enough information to uniquely identify it? I

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix glGetTransformFeedbackVarying().

2012-01-03 Thread Ian Romanick
On 01/03/2012 06:52 PM, Eric Anholt wrote: The current implementation was totally broken -- it was looking in an unpopulated structure for varyings, and trying to do so using the current list of varying names, not the list used at link time. --- src/glsl/linker.cpp | 37

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-03 Thread Yuanhan Liu
On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: > Ah index scanning... > I don't like that this will map/unmap the ib once for each prim, Me either :) > though > I don't really see a nice way to avoid that (I think if you have to Well, I thought a while, we may do some combine

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix glGetTransformFeedbackVarying().

2012-01-03 Thread Paul Berry
On 3 January 2012 19:19, Ian Romanick wrote: > On 01/03/2012 06:52 PM, Eric Anholt wrote: > >> The current implementation was totally broken -- it was looking in an >> unpopulated structure for varyings, and trying to do so using the >> current list of varying names, not the list used at link tim

[Mesa-dev] [PATCH] intel: Re-enable GL_OES_standard_derivatives on GEN4+

2012-01-03 Thread Ian Romanick
From: Ian Romanick This extension only needs to be enabled on GEN3. Signed-off-by: Ian Romanick --- There are some other GLES extensions that we should look at enabling after the release. It's too close to the wire now to go mucking about with that. src/mesa/drivers/dri/intel/intel_extension

Re: [Mesa-dev] [PATCH 1/3] mesa: Fix typos in transform feedback error messages.

2012-01-03 Thread Paul Berry
On 3 January 2012 18:51, Paul Berry wrote: > On 3 January 2012 18:16, Eric Anholt wrote: > >> >> This series is Reviewed-by: Eric Anholt >> >> With this and the fix I have for glGetTransformFeedbackVarying(), I >> think we should be passing the oglc tests, except for one more case: >> They try

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Ian Romanick
On 01/03/2012 06:06 PM, Mike Lothian wrote: On 3 January 2012 20:27, Ian Romanick wrote: On 01/03/2012 11:13 AM, Mike Lothian wrote: Hi Ever since these tests went in I get failures during configure: configure: creating ./config.status config.status: creating configs/autoconf config.status

Re: [Mesa-dev] [PATCH] vbo: introduce vbo_get_minmax_indices function

2012-01-03 Thread Yuanhan Liu
On Wed, Jan 04, 2012 at 11:20:07AM +0800, Yuanhan Liu wrote: > On Tue, Jan 03, 2012 at 08:25:31PM +0100, Roland Scheidegger wrote: > > Ah index scanning... > > I don't like that this will map/unmap the ib once for each prim, > Me either :) > > > though > > I don't really see a nice way to avoid th

[Mesa-dev] [PATCH] glx/dri2: print FPS when env var MESA_SHOW_FPS is 1

2012-01-03 Thread Marek Olšák
This is useful for apps which don't print FPS. Only enabled in SwapBuffers. --- src/glx/dri2_glx.c | 36 +++- 1 files changed, 35 insertions(+), 1 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index a9bcebf..394823a 100644 --- a/src/glx/dri2_g

Re: [Mesa-dev] [PATCH 18/20] mesa: Rewrite the way uniforms are tracked and handled

2012-01-03 Thread Marek Olšák
On Fri, Oct 28, 2011 at 7:42 PM, Ian Romanick wrote: > diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp > index db2f200..50a724b 100644 > --- a/src/mesa/main/uniform_query.cpp > +++ b/src/mesa/main/uniform_query.cpp > @@ -22,15 +22,16 @@ >  * AN ACTION OF CONTRACT, TO

[Mesa-dev] [PATCH] mesa: Fix transform feedback of unsubscripted arrays.

2012-01-03 Thread Paul Berry
It is not explicitly stated in the GL 3.0 spec that transform feedback can be performed on a whole varying array (without supplying a subscript). However, it seems clear from context that this was the intent. Section 2.15 (TransformFeedback) says this: When writing varying variables that are

Re: [Mesa-dev] [PATCH 20/20] tests/glx: Add unit tests for GLX_ARB_create_context GLX protocol

2012-01-03 Thread Gaetan Nadon
On 12-01-03 03:27 PM, Ian Romanick wrote: > On 01/03/2012 11:13 AM, Mike Lothian wrote: >> Hi >> >> Ever since these tests went in I get failures during configure: >> >> >> configure: creating ./config.status >> config.status: creating configs/autoconf >> config.status: error: cannot find input fil

Re: [Mesa-dev] [PATCH] glx/dri2: print FPS when env var MESA_SHOW_FPS is 1

2012-01-03 Thread Michel Dänzer
On Mit, 2012-01-04 at 06:05 +0100, Marek Olšák wrote: > This is useful for apps which don't print FPS. > Only enabled in SwapBuffers. > --- > src/glx/dri2_glx.c | 36 +++- > 1 files changed, 35 insertions(+), 1 deletions(-) > > diff --git a/src/glx/dri2_glx.c b/