[Mesa-dev] [PATCH] all.tests: add ignore for missing configuration files.

2012-01-08 Thread Dylan Baker
if you don't have an /etc/drirc or ~/.drirc then all of the tests will give a status of 'warn', this addes that warning to the ignored list. --- tests/all.tests |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index b713de0..f8d942b 100644

Re: [Mesa-dev] [PATCH 3/3] vl: replace decode_buffers with auxiliary data field

2012-01-08 Thread Maarten Lankhorst
Hey Christian, Op 04-01-12 11:42, Christian König schreef: On 03.01.2012 17:03, Maarten Lankhorst wrote: Hi Christian, 2012/1/2 Christian Königdeathsim...@vodafone.de: Hi Maarten, first of all: Happy new Year and sorry for the late reply, have been on vacation for the last week. On

[Mesa-dev] [PATCH 00/14] Fix some linker stuff, kill one more user of ir_to_mesa

2012-01-08 Thread Ian Romanick
Patches 01/14 through 03/14 was previously sent to the list. It tickled a pre-existing bug (fixed by patch recently posted to the list by Eric) on some Intel chipsets. Patches 04/14 through 07/14 make the linker do some sampler tracking that was previously done by ir_to_mesa. I suspect that the

[Mesa-dev] [PATCH 01/14] mesa: Use uniform interfaces in fixed-function fragment shader code

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Poking directly at the backing resources works only by luck. Core Mesa code should only know about the gl_uniform_storage structure. Soon other code that looks at samplers will use the gl_uniform_storage structures instead of the data in the

[Mesa-dev] [PATCH 03/14] mesa: Track fixed-function fragment shader as a shader

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously the fixed-function fragment shader was tracked as a gl_program. This means that it shows up in the driver as a Mesa IR program instead of as a GLSL IR program. If a driver doesn't generate Mesa IR from the GLSL IR, that program is empty.

[Mesa-dev] [PATCH 04/14] mesa: Validate sampler settings using uniform storage

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Rather than looking at the settings in individual assembly programs, look at the settings in the top-level uniform values. The old code was flawed because examining each shader stage in isolation could allow inconsitent usage across stages (e.g., bind

[Mesa-dev] [PATCH 05/14] glsl: Add glsl_type::sampler_index

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/glsl_types.cpp | 29 + src/glsl/glsl_types.h |6 ++ 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/glsl/glsl_types.cpp

[Mesa-dev] [PATCH 06/14] linker: Calculate the sampler to texture target mapping during linking

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Track the calculated data in gl_shader_program instead of the individual assembly shaders. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/link_uniforms.cpp | 15 ++- src/mesa/main/ff_fragment_shader.cpp

[Mesa-dev] [PATCH 07/14] linker: Calculate used samplers and shadow samplers in the linker

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com It used to be done in ir_to_mesa, and that was kind of a bad place. I didn't change st_glsl_to_tgsi because there is some strange stuff happening in the code that generates glDrawPixels shaders. It looked like this would break horribly if I touched

[Mesa-dev] [PATCH 08/14] i965: Remove brw_vs_precompile

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The only error that the vertex shader precompile could generate is when register allocation fails. Since i965 can spill registers, this should never happen. It's also not something that can cause a link error. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 09/14] i965: Remove brw_fs_precompile

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There are several things that could cause the fragment shader precompile to fail. Looking for calls to 'fail' in brw_fs_visitor.cpp finds three classes of things: * Trying to emit instructions that are invalid in 16-wide mode. * Trying to emit

[Mesa-dev] [PATCH 10/14] i965: Clean up brw_shader_precompile cruft left from previous commits

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com All three of these commits could probably be squashed into one. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_shader.cpp | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH 11/14] i965: Don't calculate masks of used FS inputs

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This previously enabled some optimizations in the fragment shader (interpolation, etc.) if some input components were always 0.0 or 1.0. However, this data was generated by analyzing Mesa IR. The next patch in this series removes generation of Mesa IR

[Mesa-dev] [PATCH 12/14] i965: Make sure gl_fragment_program::UsesKill is set for GLSL shaders

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.h |2 +- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [PATCH 13/14] i965: Don't use _mesa_ir_link_shader to do our dirty work

2012-01-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Instead, do the uniform setting and input / output mapping directly in brw_link_shader. Hurray for not generating Mesa IR! Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_shader.cpp | 60

Re: [Mesa-dev] [PATCH] mesa: Bump version to 8.0 (devel)

2012-01-08 Thread Ian Romanick
On 01/06/2012 04:54 PM, Kenneth Graunke wrote: Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- Makefile|2 +- configs/default |4 +- docs/relnotes-7.12.html | 83 --- docs/relnotes-8.0.html | 83

Re: [Mesa-dev] Recent mesa changes are causing tinderbox to fail

2012-01-08 Thread Jeremy Huddleston
On Jan 2, 2012, at 7:03 PM, Ian Romanick wrote: On 01/02/2012 06:18 PM, Jeremy Huddleston wrote: xdriinfo is failing to build in tinderbox (through no change of its own). The relevant changes in mesa were bce506f..7705833. My guess is that this was caused by one of: glx: Add

[Mesa-dev] [PATCH] gallium: improve the pipe_stream_output_info struct

2012-01-08 Thread Marek Olšák
There are 3 changes: 1) stride is specified for each buffer, not just one, so that drivers don't have to derive it from the outputs 2) new per-output property dst_offset, which specifies the offset into the buffer in dwords where the output should be stored, so that drivers don't have

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix computation of transform feedback num_components.

2012-01-08 Thread Eric Anholt
Series is Reviewed-by: Eric Anholt e...@anholt.net pgpjfhSfYYkmc.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] mesa: rename _mesa_unpack_int_rgba_row() to _mesa_unpack_uint_rgba_row()

2012-01-08 Thread Eric Anholt
On Sat, 7 Jan 2012 14:37:34 -0700, Brian Paul bri...@vmware.com wrote: Since it returns uint values, not int. Series is: Reviewed-by: Eric Anholt e...@anholt.net pgpofeFGAiUZt.pgp Description: PGP signature ___ mesa-dev mailing list

[Mesa-dev] [PATCH 1/2] i965: Move the note about sampler count flag to the correct place.

2012-01-08 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/gen7_wm_state.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen7_wm_state.c b/src/mesa/drivers/dri/i965/gen7_wm_state.c index a994836..6a45520 100644 --- a/src/mesa/drivers/dri/i965/gen7_wm_state.c +++

Re: [Mesa-dev] [PATCH] all.tests: add ignore for missing configuration files.

2012-01-08 Thread Tolga Dalman
On 01/06/12 14:44, Dylan Baker wrote: if you don't have an /etc/drirc or ~/.drirc then all of the tests will give a status of 'warn', this addes that warning to the ignored list. --- tests/all.tests |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/all.tests

Re: [Mesa-dev] [PATCH] all.tests: add ignore for missing configuration files.

2012-01-08 Thread Ian Romanick
On 01/08/2012 01:25 PM, Tolga Dalman wrote: On 01/06/12 14:44, Dylan Baker wrote: if you don't have an /etc/drirc or ~/.drirc then all of the tests will give a status of 'warn', this addes that warning to the ignored list. --- tests/all.tests | 1 + 1 files changed, 1 insertions(+), 0

[Mesa-dev] [RFC]Improves st_finalize_texture cycles consumption

2012-01-08 Thread Vincent Lejeune
Hi, I did some profiling with perf under nexuiz and found that st_finalize_texture function was one of the most cycle consumming. (~1,50% whereas darkplaces took ~30%) I rewrite some part of this function to make it a bit faster ; with these 2 patches, st_finalize_texture consumption went down

[Mesa-dev] [PATCH 1/2] gallium: Avoid a if () only used for convenience for gen_mipmap

2012-01-08 Thread Vincent Lejeune
--- src/mesa/state_tracker/st_cb_texture.c | 67 --- src/mesa/state_tracker/st_cb_texture.h |5 ++ src/mesa/state_tracker/st_gen_mipmap.c |4 +- 3 files changed, 50 insertions(+), 26 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH 2/2] gallium: avoid generating loop overhead in case of a non cubemap texture.

2012-01-08 Thread Vincent Lejeune
--- src/mesa/state_tracker/st_cb_texture.c | 82 1 files changed, 62 insertions(+), 20 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 3cd1b2b..eeb6e3a 100644 ---

[Mesa-dev] [PATCH 01/11] i965: Add missing _NEW_BUFFERS dirty bit to Gen6+ DEPTH_STENCIL atoms.

2012-01-08 Thread Kenneth Graunke
This brings the dirty bits in line with the comments. This does /not/ need to be cherry-picked to stable branches because the access requiring _NEW_BUFFERS was added in master as part of HiZ. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen6_depthstencil.c

[Mesa-dev] i965: Fixing dirty bits

2012-01-08 Thread Kenneth Graunke
While investigating an etracer issue on Ivybridge, I did a lot of careful reading of the tracked state atoms' dirty bits. Found a bunch of issues. Unfortunately, none of these patches fixed the issues I was seeing. While we're at it: BRW_NEW_CONTEXT seems like the wrong thing in basically every

[Mesa-dev] [PATCH 02/11] i965: Add missing BRW_NEW_BATCH dirty bit to Gen6+ clip state atoms.

2012-01-08 Thread Kenneth Graunke
Without MI_SET_CONTEXT, there's no guarantee that another program hasn't reprogram the GPU's clip state since our last batch. We need to submit it every time. Found by inspection. NOTE: This is a candidate for the 7.11 branch. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH 04/11] i965: Add missing BRW_NEW_BATCH dirty bit to the Gen6 GS state atom.

2012-01-08 Thread Kenneth Graunke
Without MI_SET_CONTEXT, there's no guarantee that another program hasn't reprogram the GPU's GS state since our last batch. We need to submit it every time. This is especially important now that we actually use the GS unit: different Mesa-based programs may program it to different states. Found

[Mesa-dev] [PATCH 06/11] i965: Remove BRW_NEW_URB_FENCE dirty bit from Gen6+ atoms.

2012-01-08 Thread Kenneth Graunke
The BRW_NEW_URB_FENCE dirty bit is only flagged by the brw_recalculate_urb_fence state atom which isn't used on Gen6+. Since it's never flagged, there's no reason to depend on it. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen6_gs_state.c |3 +--

[Mesa-dev] [PATCH 05/11] i965: Add missing BRW_NEW_BATCH dirty bit to the Gen6+ URB atoms.

2012-01-08 Thread Kenneth Graunke
Without MI_SET_CONTEXT, there's no guarantee that another program hasn't reprogram the GPU's URB state since our last batch. We need to submit it every time. This is especially important now that we actually reprogram the URB layout on Gen6 based on whether or not we're using transform feedback.

[Mesa-dev] [PATCH 07/11] i965: Remove BRW_NEW_CURBE_OFFSETS dirty bit from Gen7 atoms.

2012-01-08 Thread Kenneth Graunke
The BRW_NEW_CURBE_OFFSETS dirty bit is only flagged by the brw_curbe_offsets state atom which is only used on Gen4-5. Since it's never flagged, there's no reason to depend on it. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen7_vs_state.c |3 +--

[Mesa-dev] [PATCH 08/11] i965: Move _NEW_PROGRAM dirty bit from gen7_sf_state to gen7_sbe_state.

2012-01-08 Thread Kenneth Graunke
According to a comment in gen6_sf_state.c, calls to get_attr_override need both _NEW_PROGRAM and _NEW_LIGHT. Since Gen7 reuses the same function, the same dirty bits should apply. When I performed the SF/SBE split, I partitioned the bits incorrectly: 3DSTATE_SBE (which contains the attribute

[Mesa-dev] [PATCH 09/11] i965: Add missing _NEW_PROGRAM bit to brw_sf_unit and gen7_sf_state.

2012-01-08 Thread Kenneth Graunke
From my reading of main/enable.c:735, it appears that ctx-VertexProgram.PointSizeEnabled is covered by _NEW_PROGRAM. NOTE: This is a candidate for the 7.11 branch. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_sf_state.c |2 ++

[Mesa-dev] [PATCH 10/11] i965: Update dirty bit comments for the gen7_ps_state atom.

2012-01-08 Thread Kenneth Graunke
CACHE_NEW_SAMPLER doesn't cover max_wm_threads, but it does cover brw-sampler.count. BRW_NEW_PS_BINDING_TABLE is obvious, but it's probably worth adding a comment anyway. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/gen7_wm_state.c |3 ++- 1 files

[Mesa-dev] [PATCH 11/11] i965: Re-sync outdated comments about Gen6+ push constants.

2012-01-08 Thread Kenneth Graunke
In f3e9ccb3b, I renamed gen6_upload_wm_constants to gen6_upload_wm_push_constants, but neglected to update this comment. I don't think there ever was a gen7_prepare_wm_constants function; it was probably a search and replace error. Of course, prepare functions died a while back as well.

[Mesa-dev] [Bug 44564] Fix build with LLVM -DLLVM_TARGETS_TO_BUILD=`native`

2012-01-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44564 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 2/2] gallium: avoid generating loop overhead in case of a non cubemap texture.

2012-01-08 Thread Matt Turner
On Sun, Jan 8, 2012 at 5:15 PM, Vincent Lejeune v...@ovi.com wrote: ---  src/mesa/state_tracker/st_cb_texture.c |   82  1 files changed, 62 insertions(+), 20 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

Re: [Mesa-dev] [RFC]Improves st_finalize_texture cycles consumption

2012-01-08 Thread Keith Whitwell
I don't have the code handy (and haven't looked at it in a while), but wonder if finer-grained tracking of dirtiness would help? Or more generally trying to preserve more computed results across state changes? Keith - Original Message - Hi, I did some profiling with perf under

[Mesa-dev] [PATCH] i965: Fix zeroing of unused attributes in 3DSTATE_SBE.

2012-01-08 Thread Kenneth Graunke
This brings the code in sync with gen6_sf_state.c; presumably the mistake was a botched rebase on initial Ivybridge bring-up patches. Found by diffing batch buffer dumps and noticing the random values. Thanks to Eric for catching the obvious mistake. NOTE: This is a candidate for the 7.11

[Mesa-dev] [PATCH] glsl: remove logical xor FINISHME

2012-01-08 Thread Matt Turner
GLSL spec boneheadedly says (a ^^ a) must actually be evaluated. Signed-off-by: Matt Turner matts...@gmail.com --- Fortunately, shaders that do this are even more boneheaded. src/glsl/opt_algebraic.cpp |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] glsl: remove logical xor FINISHME

2012-01-08 Thread Matt Turner
On Sun, Jan 8, 2012 at 10:44 PM, Matt Turner matts...@gmail.com wrote: GLSL spec boneheadedly says (a ^^ a) must actually be evaluated. Signed-off-by: Matt Turner matts...@gmail.com --- On second thought, maybe the better thing to do here is to evaluate $a twice, which in most cases would be