Re: [Mesa-dev] [PATCH 1/7] i965: use AM_CPPFLAGS instead of AM_CFLAGS/CXXFLAGS

2012-01-18 Thread Gaetan Nadon
On 12-01-18 01:11 PM, Eric Anholt wrote: > On Tue, 17 Jan 2012 15:58:11 -0500, Matt Turner wrote: > > As far as I can tell, the point of AM_CPPFLAGS existing is if you want > to make a target that separately calls the preprocessor, so you a list > of includes and a list of non-preprocessor compile

Re: [Mesa-dev] [PATCH 5/7] automake: src/mesa/drivers/dri/nouveau

2012-01-18 Thread Gaetan Nadon
On 12-01-17 08:30 PM, Matt Turner wrote: > On Tue, Jan 17, 2012 at 7:32 PM, Gaetan Nadon wrote: >> On 12-01-17 03:58 PM, Matt Turner wrote: >> >> +AM_CPPFLAGS = \ >> +-I$(top_srcdir)/include \ >> +-I$(top_srcdir)/src/ \ >> +-I$(top_srcdir)/src/mapi \ >> +-I$(top_srcdir)/src/mesa/ \

Re: [Mesa-dev] [PATCH 1/7] i965: use AM_CPPFLAGS instead of AM_CFLAGS/CXXFLAGS

2012-01-18 Thread Gaetan Nadon
On 12-01-17 08:28 PM, Matt Turner wrote: > On Tue, Jan 17, 2012 at 7:21 PM, Gaetan Nadon wrote: >> On 12-01-17 03:58 PM, Matt Turner wrote: >>> --- >>> src/mesa/drivers/dri/i965/Makefile.am |4 +--- >>> 1 files changed, 1 insertions(+), 3 deletions(-) >>> >>> diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

2012-01-18 Thread Yuanhan Liu
When rendering to FBO, rendering is inverted. At the same time, we would also make sure the point sprite origin is inverted. Or, we will get an inverted result correspoinding to rendering to the default winsys FBO. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44613 NOTE: This is a candi

Re: [Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

2012-01-18 Thread Yuanhan Liu
On Wed, Jan 18, 2012 at 11:53:20AM -0800, Ian Romanick wrote: > On 01/18/2012 02:23 AM, Yuanhan Liu wrote: > >When rendering to FBO, rendering is inverted. At the same time, we would > >also make sure the point sprite origin is inverted. Or, we will get an > >inverted result correspoinding to rende

Re: [Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

2012-01-18 Thread Yuanhan Liu
On Wed, Jan 18, 2012 at 12:13:28PM -0800, Ian Romanick wrote: > On 01/18/2012 02:21 AM, Yuanhan Liu wrote: > >On Wed, Jan 18, 2012 at 06:23:52PM +0800, Yuanhan Liu wrote: > >>When rendering to FBO, rendering is inverted. At the same time, we would > >>also make sure the point sprite origin is inver

[Mesa-dev] [PATCH] autoconf: Fix build of dri symbols test to not manually link expat.

2012-01-18 Thread Eric Anholt
AC_CHECK_LIB has this nasty behavior, like the cflags tests, of automatically putting the tested value into the global LIBS on success. This caused -lexpat to end up in LIBS, but without the --with-expat dir, so my 32-bit build on a 64 system using expat from a custom prefix could only find the sy

Re: [Mesa-dev] [Nouveau] [PATCH 4/4] nvfx: random cleanups of the state validation code

2012-01-18 Thread Lucas Stach
Am Mittwoch, den 18.01.2012, 21:54 +0100 schrieb Patrice Mandin: > Le Tue, 17 Jan 2012 18:22:59 +0100 > Patrice Mandin a écrit: > > > Le Tue, 10 Jan 2012 12:41:04 +0100 > > Lucas Stach a écrit: > > > > > Signed-off-by: Lucas Stach > > > --- > > > src/gallium/drivers/nvfx/nvfx_state_emit.c |

Re: [Mesa-dev] [PATCH] r600g: fixup AR handling (v3)

2012-01-18 Thread Vadim Girlin
On Wed, 2012-01-18 at 21:49 +, Dave Airlie wrote: > From: Dave Airlie > > So it appears R600s (except rv670) do AR handling different using a different > opcode. This patch fixes up r600g to work properly on r600. > > This fixes ~100 piglit tests here (in GLSL1.30 mode) on rv610. > > v3: ad

Re: [Mesa-dev] [PATCH] glsl: Fix isinf() for non-C99-compliant compilers.

2012-01-18 Thread Kenneth Graunke
On 01/18/2012 12:32 PM, Paul Berry wrote: Commit ede60bc4670a8d9c14921c77abee1ac57fc0e6bf (glsl: Add isinf() and isnan() builtins) uses "+INF" in the .ir file to represent infinity. This worked on C99-compliant compilers, since the s-expression reader uses strtod() to read numbers, and C99 requir

[Mesa-dev] [PATCH 1/2] i965/vs: Use the embedded-comparison SEL on gen6+, like the FS does.

2012-01-18 Thread Eric Anholt
Shaves a few instructions off of the VS in Lightsmark, but no statistically significant performance difference on gen7 (n=5). --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 2/2] i965/vs: Enable workaround-free math on gen7.

2012-01-18 Thread Eric Anholt
This is similar to a commit that did the same for the FS. Shaves several more instructions off of the VS in Lightsmark, but no statistically significant performance difference (n=5). --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(

Re: [Mesa-dev] [PATCH] r600g: fix streamout on evergreen

2012-01-18 Thread Marek Olšák
Well spotted, thanks! Reviewed-by: Marek Olšák Marek On Wed, Jan 18, 2012 at 10:46 AM, Vadim Girlin wrote: > Enable it in the evergreen_context_draw if needed. > Same as already done in the r600_context_draw for r6xx/r7xx. > > Signed-off-by: Vadim Girlin > --- >  src/gallium/drivers/r600/ever

[Mesa-dev] [PATCH] r600g: fixup AR handling (v3)

2012-01-18 Thread Dave Airlie
From: Dave Airlie So it appears R600s (except rv670) do AR handling different using a different opcode. This patch fixes up r600g to work properly on r600. This fixes ~100 piglit tests here (in GLSL1.30 mode) on rv610. v3: add index_mode as per the docs. This still fails any dst relative tests

Re: [Mesa-dev] [PATCH] glsl: Fix isinf() for non-C99-compliant compilers.

2012-01-18 Thread Paul Berry
On 18 January 2012 12:43, Jose Fonseca wrote: > Looks good to me. Thanks > > Should there be a case for -INF while we are at it? > I think you can make arguments both for and against. On the one hand, C99 requires strtod to recognize "INF", "+INF", "-INF", "INFINITY", "+INFINITY", "-INFINITY",

Re: [Mesa-dev] [Nouveau] [PATCH 4/4] nvfx: random cleanups of the state validation code

2012-01-18 Thread Patrice Mandin
Le Tue, 17 Jan 2012 18:22:59 +0100 Patrice Mandin a écrit: > Le Tue, 10 Jan 2012 12:41:04 +0100 > Lucas Stach a écrit: > > > Signed-off-by: Lucas Stach > > --- > > src/gallium/drivers/nvfx/nvfx_state_emit.c | 49 > > --- > > 1 files changed, 22 insertions(+), 27 del

Re: [Mesa-dev] [PATCH] glsl: Fix isinf() for non-C99-compliant compilers.

2012-01-18 Thread Jose Fonseca
Looks good to me. Thanks Should there be a case for -INF while we are at it? Jose - Original Message - > Commit ede60bc4670a8d9c14921c77abee1ac57fc0e6bf (glsl: Add isinf() > and > isnan() builtins) uses "+INF" in the .ir file to represent infinity. > This worked on C99-compliant compiler

[Mesa-dev] [Bug 44912] New: [bisected] WebGL conformance/textures/texture-mips tests fails

2012-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 Bug #: 44912 Summary: [bisected] WebGL conformance/textures/texture-mips tests fails Classification: Unclassified Product: Mesa Version: git Platform: Other

[Mesa-dev] [PATCH] glsl: Fix isinf() for non-C99-compliant compilers.

2012-01-18 Thread Paul Berry
Commit ede60bc4670a8d9c14921c77abee1ac57fc0e6bf (glsl: Add isinf() and isnan() builtins) uses "+INF" in the .ir file to represent infinity. This worked on C99-compliant compilers, since the s-expression reader uses strtod() to read numbers, and C99 requires strtod() to understand "+INF". However,

[Mesa-dev] [PATCH] mesa: Loosen glBlitFramebuffer restrictions on depthstencil buffers (v2)

2012-01-18 Thread Chad Versace
--- snip Supporting Z32 -> Z32_FLOAT is a bad idea. So I've amended the patch to avoid that. --- end snip This loosens the format validation in glBlitFramebuffer. When blitting depth bits, don't require an exact match between the depth formats; only require that the two formats have the same nu

Re: [Mesa-dev] [PATCH] mesa: Set default access flags based on the run-time API

2012-01-18 Thread Brian Paul
On 01/18/2012 12:41 PM, Ian Romanick wrote: From: Ian Romanick The default access flags for OpenGL ES (via GL_OES_map_buffer) and desktop OpenGL are different. The code previously tried to handle this, but the decision was made at compile time. Since the same driver binary can be used for both

Re: [Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

2012-01-18 Thread Ian Romanick
On 01/18/2012 02:21 AM, Yuanhan Liu wrote: On Wed, Jan 18, 2012 at 06:23:52PM +0800, Yuanhan Liu wrote: When rendering to FBO, rendering is inverted. At the same time, we would also make sure the point sprite origin is inverted. Or, we will get an inverted result correspoinding to rendering to t

Re: [Mesa-dev] renderbuffer-cleanups-v2 branch

2012-01-18 Thread Ian Romanick
On 01/17/2012 02:58 PM, Brian Paul wrote: On 01/16/2012 08:30 PM, Brian Paul wrote: On Mon, Jan 16, 2012 at 4:31 PM, Ian Romanick wrote: On 01/16/2012 01:30 PM, Brian Paul wrote: The renderbuffer-cleanups-v2 branch removes all the old swrast GetRow/PutRow stuff. All swrast rendering is now d

Re: [Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

2012-01-18 Thread Ian Romanick
On 01/18/2012 02:23 AM, Yuanhan Liu wrote: When rendering to FBO, rendering is inverted. At the same time, we would also make sure the point sprite origin is inverted. Or, we will get an inverted result correspoinding to rendering to the default winsys FBO. Bugzilla: https://bugs.freedesktop.org

[Mesa-dev] [PATCH] mesa: Set default access flags based on the run-time API

2012-01-18 Thread Ian Romanick
From: Ian Romanick The default access flags for OpenGL ES (via GL_OES_map_buffer) and desktop OpenGL are different. The code previously tried to handle this, but the decision was made at compile time. Since the same driver binary can be used for both OpenGL ES and desktop OpenGL, the decision m

[Mesa-dev] [PATCH] r600g: fix combined MEM_STREAM instructions

2012-01-18 Thread Vadim Girlin
BURST_COUNT is clipped with ARRAY_SIZE, so set it to the max value to avoid clipping. Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r

[Mesa-dev] [PATCH] r600g: fixup AR handling (V2)

2012-01-18 Thread Dave Airlie
From: Dave Airlie So it appears R600s (except rv670) do AR handling different using a different opcode. This patch fixes up r600g to work properly on r600. This fixes ~100 piglit tests here (in GLSL1.30 mode) on rv610. Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_asm.c|

Re: [Mesa-dev] [PATCH 1/7] i965: use AM_CPPFLAGS instead of AM_CFLAGS/CXXFLAGS

2012-01-18 Thread Eric Anholt
On Tue, 17 Jan 2012 15:58:11 -0500, Matt Turner wrote: As far as I can tell, the point of AM_CPPFLAGS existing is if you want to make a target that separately calls the preprocessor, so you a list of includes and a list of non-preprocessor compiler flags. Given that we don't have any preprocesso

Re: [Mesa-dev] [PATCH 1/2] mesa: use GL_MAP_INVALIDATE_RANGE_BIT in glTexImage paths

2012-01-18 Thread Eric Anholt
On Tue, 17 Jan 2012 08:19:44 -0700, Brian Paul wrote: > Update the dd.h docs to indicate that GL_MAP_INVALIDATE_RANGE_BIT > can be used with GL_MAP_WRITE_BIT when mapping renderbuffers and > texture images. > > Pass the flag when mapping texture images for glTexImage, glTexSubImage, > etc. It's

Re: [Mesa-dev] [PATCH 1/4] glapi: remove non-existent parameter references

2012-01-18 Thread nobled
On Tue, Jan 17, 2012 at 6:10 PM, Brian Paul wrote: > On 01/16/2012 04:45 PM, nobled wrote: >> >> glGetTexImage, for example, has no width/height/depth parameters. >> >> Also, copy some missing parameter info from the original versions >> of certain functions over to their ARB_robustness counterpar

[Mesa-dev] [Bug 44039] Mesa 7.12-devel implementation error: unexpected format 0x822e in _mesa_choose_tex_format()

2012-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44039 --- Comment #7 from Brian Paul 2012-01-18 09:47:45 PST --- I've pushed the 16-bit float fallback work-around. Commit 7628696004515074594d4fdac4e422c81c86b32c Nikita, Mathieu: can you re-test with Mesa/master? -- Configure bugmail: https://bug

Re: [Mesa-dev] [PATCH] i965/vs: Take attributes into account when deciding urb_entry_size.

2012-01-18 Thread Eric Anholt
On Tue, 17 Jan 2012 22:10:07 -0800, Kenneth Graunke wrote: > Both the VF and VS share space in the URB. First, the VF stores > attributes (shader inputs) there. The VS then reads the attributes, > executes, and reuses the space to store varyings (shader outputs). > > Thus, we need to calculate

Re: [Mesa-dev] dd_function_table::Clear()

2012-01-18 Thread Brian Paul
On 01/18/2012 09:01 AM, Dee Sharpe wrote: While implementing Clear() for a platform, which buffers in GLContext need to be cleared out of the list of: DrawBuffer ReadBuffer WinSysDrawBuffer WinSysReadBuffer Or do they all need to be cleared? Clearing effects "draw" buffers, not "read" buffer

[Mesa-dev] dd_function_table::Clear()

2012-01-18 Thread Dee Sharpe
While implementing Clear() for a platform, which buffers in GLContext need to be cleared out of the list of: DrawBuffer ReadBuffer WinSysDrawBuffer WinSysReadBuffer Or do they all need to be cleared? A. Demetrious Sharpe ___ mesa-dev mailing list mesa

Re: [Mesa-dev] [PATCH] Revert "mesa: check depth, stencil formats (not depths) in glBlitFramebuffer"

2012-01-18 Thread Brian Paul
On 01/17/2012 11:00 PM, Kenneth Graunke wrote: On 01/17/2012 05:27 PM, Ian Romanick wrote: On 01/17/2012 05:12 PM, Chad Versace wrote: This reverts commit 3f1fab06844f696de44d9a56e83ff62e8ea576bd. This loosens the format validation in glBlitFramebuffer. When blitting depth bits, don't require

[Mesa-dev] [Bug 24572] Can't compile git drm/linux-core/drm_memory.c

2012-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=24572 Michel Dänzer changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

Re: [Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

2012-01-18 Thread Yuanhan Liu
On Wed, Jan 18, 2012 at 06:23:52PM +0800, Yuanhan Liu wrote: > When rendering to FBO, rendering is inverted. At the same time, we would > also make sure the point sprite origin is inverted. Or, we will get an > inverted result correspoinding to rendering to the default winsys FBO. > > Bugzilla: ht

[Mesa-dev] [PATCH] i965: fix inverted point sprite origin when rendering to FBO

2012-01-18 Thread Yuanhan Liu
When rendering to FBO, rendering is inverted. At the same time, we would also make sure the point sprite origin is inverted. Or, we will get an inverted result correspoinding to rendering to the default winsys FBO. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44613 Signed-off-by: Yuanha

[Mesa-dev] [PATCH] r600g: fix streamout on evergreen

2012-01-18 Thread Vadim Girlin
Enable it in the evergreen_context_draw if needed. Same as already done in the r600_context_draw for r6xx/r7xx. Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/evergreen_hw_context.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/e

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-18 Thread Jose Fonseca
- Original Message - > On Tue, Jan 17, 2012 at 15:47, Stéphane Marchesin > wrote: > > On Wed, Jan 11, 2012 at 10:13, Jose Fonseca > > wrote: > >> - Original Message - > >>> Where else would the flush go? > >> > >> Maybe one of the callers already invoked glFlush, or something >