[Mesa-dev] [Bug 44405] Spring RTS crashes using r600g (5670, Redwood), kernel rejects relocations

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44405 Michel Dänzer changed: What|Removed |Added CC||aguz_...@hotmail.com --- Comment #12 fro

Re: [Mesa-dev] [PATCH] glsl: fix variable ordering in the output_read_remover

2012-04-02 Thread Tolga Dalman
Hi, On 31.03.2012 20:23, Vadim Girlin wrote: > Use the hash of the variable name string instead of the pointer value. > > Signed-off-by: Vadim Girlin > --- > > This patch solves the problem for me, afaics. > Tested with quick-driver.tests > > src/glsl/lower_output_reads.cpp |9 - >

Re: [Mesa-dev] [PATCH 1/9] util: fix undefined behavior

2012-04-02 Thread Tolga Dalman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 02.04.2012 00:24, nobled wrote: > #define LIST_FOR_EACH_ENTRY(pos, head, member) > \ > - for (pos = container_of((head)->next, pos, member); > \ > + for (pos = NULL, pos = container_of

Re: [Mesa-dev] [PATCH 5/9] mesa: fix truncated value warning

2012-04-02 Thread Brian Paul
On 04/01/2012 04:24 PM, nobled wrote: Silences a clang warning: format_pack.c:2546:30: warning: implicit conversion from 'int' to 'GLubyte' (aka 'unsigned char') changes value from 65535 to 255 [-Wconstant-conversion] d[i] = d[i] ? 0x : 0x0; ~ ^~~~

Re: [Mesa-dev] [PATCH 4/9] mesa: delete tautological compare

2012-04-02 Thread Brian Paul
On 04/01/2012 04:24 PM, nobled wrote: Noticed by clang: main/extensions.c:934:14: warning: comparison of unsigned expression< 0 is always false [-Wtautological-compare] if (index< 0) ~ ^ ~ Also don't cast away const needlessly in this function. --- src/mesa/main/extensions.c

Re: [Mesa-dev] [PATCH 3/9] egl: fix uninitialized values

2012-04-02 Thread Brian Paul
On 04/01/2012 04:24 PM, nobled wrote: Noticed by clang: eglimage.c:48:28: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to dereference it? [-Wsizeof-pointer-memaccess] memset(attrs, 0, sizeof(attrs)); ~^

Re: [Mesa-dev] [PATCH 2/9] util: fix uninitialized table

2012-04-02 Thread Brian Paul
On 04/01/2012 04:24 PM, nobled wrote: Most of the 256 values in the 'generic_to_slot' table were supposed to be initialized with the default value 0xff, but were left at zero (from CALLOC_STRUCT()) instead. Noticed by clang: u_linkage.h:60:31: warning: argument to 'sizeof' in 'memset' call is t

Re: [Mesa-dev] [PATCH 9/9] egl-static: fix printf warning

2012-04-02 Thread Brian Paul
On 04/01/2012 04:25 PM, nobled wrote: Noticed by clang: egl_st.c:57:50: warning: field precision should have type 'int', but argument has type 'size_t' (aka 'unsigned long') [-Wformat] ret = util_snprintf(path, sizeof(path), "%.*s/%s" UTIL_DL_EXT,

Re: [Mesa-dev] [PATCH 8/9] st/vega: fix uninitialized values

2012-04-02 Thread Brian Paul
On 04/01/2012 04:25 PM, nobled wrote: C still treats array arguments exactly like pointer arguments. By sheer coincidence, this still worked fine on 64-bit machines where 2 * sizeof(float) == sizeof(void*), but not on 32-bit. Noticed by clang: text.c:76:51: warning: sizeof on array function par

Re: [Mesa-dev] [PATCH 7/9] st/vega: silence enum cast warnings

2012-04-02 Thread Brian Paul
On 04/01/2012 04:24 PM, nobled wrote: clang warns on these: stroker.c:626:19: warning: implicit conversion from enumeration type 'VGPathCommand' to different enumeration type 'VGPathSegment' [-Wconversion] No change in the underlying value. --- src/gallium/state_trackers/vega/stroker.c |9

Re: [Mesa-dev] [PATCH] swrast: Fix memory leaks in blit_linear.

2012-04-02 Thread Brian Paul
On 04/01/2012 12:17 AM, Vinson Lee wrote: Fixes Coverity resource leak defects. NOTE: This is a candidate for the 8.0 branch. Signed-off-by: Vinson Lee --- src/mesa/swrast/s_blit.c |9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/swrast/s_blit.c b/src/mesa/swrast/s_bl

[Mesa-dev] [PATCH 1/6] r600g: kill off the fallback for crazy src_offset values

2012-04-02 Thread Marek Olšák
st/mesa doesn't allow src_offset to be greater than stride and the maximum stride r600 supports is 2047. --- src/gallium/drivers/r600/r600_asm.c | 24 +-- src/gallium/drivers/r600/r600_pipe.h |5 --- src/gallium/drivers/r600/r600_state_common.c | 39 ++-

[Mesa-dev] [PATCH 2/6] r600g: rework state emission of vertex buffers

2012-04-02 Thread Marek Olšák
This reduces a little of CPU overhead. The idea is to translate pipe vertex buffers directly into the CS and not using any intermediate representations. Framerate in Torcs: before: 32.2 after: 34.6 --- src/gallium/drivers/r600/evergreen_hw_context.c |4 -- src/gallium/drivers/r600/evergr

[Mesa-dev] [PATCH 3/6] r600g: rework state emission of constant buffers

2012-04-02 Thread Marek Olšák
Framerate in ipers: before: 43.6 FPS after: 46.6 FPS --- src/gallium/drivers/r600/evergreen_hw_context.c | 16 src/gallium/drivers/r600/evergreen_state.c | 71 + src/gallium/drivers/r600/r600_hw_context.c | 13 +-- src/gallium/drivers/r600/r600_pipe.h

[Mesa-dev] [PATCH 4/6] r600g: remove dead code after the rework

2012-04-02 Thread Marek Olšák
--- src/gallium/drivers/r600/evergreen_state.c | 38 - src/gallium/drivers/r600/r600.h| 12 src/gallium/drivers/r600/r600_hw_context.c | 42 +-- src/gallium/drivers/r600/r600_pipe.h | 13 src/gallium/driver

[Mesa-dev] [PATCH 5/6] r600g: invalidate caches at the beginning of CS

2012-04-02 Thread Marek Olšák
--- src/gallium/drivers/r600/r600_hw_context.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_hw_context.c b/src/gallium/drivers/r600/r600_hw_context.c index 46c8c04..e898a59 100644 --- a/src/gallium/drivers/r600/r600_hw_context.c ++

[Mesa-dev] [PATCH 6/6] r600g: handle DISCARD_WHOLE_RESOURCE for buffers

2012-04-02 Thread Marek Olšák
This should prevent stalls and therefore increase perfomance in some cases. --- src/gallium/drivers/r600/r600_buffer.c | 59 ++ src/gallium/drivers/r600/r600_state_common.c |2 +- 2 files changed, 60 insertions(+), 1 deletions(-) diff --git a/src/gallium/driver

Re: [Mesa-dev] [PATCH v2 01/11] gallium: Basic compute interface.

2012-04-02 Thread Marek Olšák
This looks good to me. Thank you. Reviewed-by: Marek Olšák Marek On Sat, Mar 31, 2012 at 6:39 PM, Francisco Jerez wrote: > Define an interface that exposes the minimal functionality required to > implement some of the popular compute APIs.  This commit adds entry > points to set the grid layou

Re: [Mesa-dev] Gallium: src_offset of pipe_vertex_element should be more restricted

2012-04-02 Thread Jose Fonseca
OK. In that case, I think it's fine to assume these hardware limits are never exceeded in practice, and we should just add a few assertions to catch if/when they do. And if we wanna be robust against this, then we should start by writing some piglit tests that exercise it. Jose - Original

[Mesa-dev] [PATCH] st/vdpau: fix deadlock in PresentationQueueQuerySurfaceStatus

2012-04-02 Thread Christian König
Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/presentation.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/gallium/state_trackers/vdpau/presentation.c b/src/gallium/state_trackers/vdpau/presentation.c index 2e3bea9..51a702e 100644 --- a/src/

Re: [Mesa-dev] Gallium: src_offset of pipe_vertex_element should be more restricted

2012-04-02 Thread Marek Olšák
Actually, nevermind. st/mesa doesn't allow a src_offset to be greater a stride and the maximum stride r600 supports is 2047, so we are much more likely to fail because of a too large stride than the src_offset (which has limit 65535). I think r600g is pretty safe right now as far as the src_offset

[Mesa-dev] [Bug 47373] [Intel HD3000] Desktop stop response when option "shadow" set to false

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47373 Chad Versace changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop. |ch...@chris-wilson.co.uk

[Mesa-dev] [PATCH 1/2] st/mesa: fix max_offset computation for base vertex

2012-04-02 Thread Brian Paul
Fixes a failed assertion in the u_upload_mgr.c code with the VMware svga driver. Note that we have to remove the !new_array test because the VBO module always sets _NEW_ARRAY when setting up the draw call. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48141 --- src/mesa/state_tracker/st_dra

[Mesa-dev] [PATCH 2/2] svga: handle TGSI_SEMANTIC_CLIPDIST/VERTEX semantics

2012-04-02 Thread Brian Paul
We can't support these vertex attributes, but don't die in an assertion. Issue a warning instead. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48142 --- src/gallium/drivers/svga/svga_tgsi_decl_sm30.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [Bug 47124] libEGL.la fails during linking

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47124 --- Comment #3 from Mandeep Singh Baines 2012-04-02 13:16:26 PDT --- I suspect this is fixed by: http://cgit.freedesktop.org/mesa/mesa/commit/configure.ac?id=ca760181b4420696c7e86aa2951d7203522ad1e8 commit ca760181b4420696c7e86aa2951d7203522ad

[Mesa-dev] [PATCH 1/2] i965: Remove vestiges of function call support from the old VS backend.

2012-04-02 Thread Kenneth Graunke
This never worked. brwProgramStringNotify also explicitly rejects programs that use CAL and RET. So there's no need for this to exist. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_eu.c | 124 --- src/mesa/drivers/dri/i965/brw_eu.h |

[Mesa-dev] [PATCH 2/2] ir_to_mesa: Remove pretense of support for function calls.

2012-04-02 Thread Kenneth Graunke
While ir_to_mesa contains code that attempts to support functions, I honestly doubt it's been tested and have little confidence that it works. The comment in visit(ir_function *ir) doesn't inspire confidence: /* Ignore function bodies other than main() -- we shouldn't see calls to * them since th

Re: [Mesa-dev] [PATCH 1/6] r600g: kill off the fallback for crazy src_offset values

2012-04-02 Thread Alex Deucher
On Mon, Apr 2, 2012 at 11:10 AM, Marek Olšák wrote: > st/mesa doesn't allow src_offset to be greater than stride and the maximum > stride r600 supports is 2047. For 5/6, IIRC, in the early days of r600g there were some issues with the ordering of the flushes since the ddx flushes after for dst ca

[Mesa-dev] [Bug 47607] [advocacy] Make Anomaly Warzone Earth work with Mesa

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47607 Eugeni Dodonov changed: What|Removed |Added CC||e...@anholt.net, |

[Mesa-dev] [PATCH] x86-64: Don't print "Initializing x86-64 optimizations" in debug builds.

2012-04-02 Thread Kenneth Graunke
In "release" builds, Mesa would print this message if the MESA_DEBUG variable was set. Make it so for debug builds as well. I build debug builds all the time, but I'm not debugging this. Signed-off-by: Kenneth Graunke --- src/mesa/x86-64/x86-64.c | 12 +--- 1 files changed, 1 inserti

[Mesa-dev] [Bug 47124] libEGL.la fails during linking

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47124 Alexandre Demers changed: What|Removed |Added CC|alexandre.f.dem...@gmail.co | |m

[Mesa-dev] [PATCH] gallivm: Pass in a MCInstrInfo to createMCInstPrinter on llvm-3.1.

2012-04-02 Thread Vinson Lee
llvm-3.1svn r153860 makes MCInstrInfo available to the MCInstPrinter. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp b/src/gallium/auxiliary