Re: [Mesa-dev] [PATCH] Mesa: Fix a race in the build

2012-06-12 Thread Mike Frysinger
On Tue, Jun 12, 2012 at 6:47 PM, Dan Nicholson wrote: > On 6/12/12, Stéphane Marchesin wrote: > > From: Mike Frysinger > > > > The intent of the message above it is right (we need to build those > > dependencies in that order) but the implementation is wrong, as it > > can be executed in any or

Re: [Mesa-dev] [PATCH 00/11] docs: html cleanup

2012-06-12 Thread Ian Romanick
On 06/11/2012 09:06 AM, Brian Paul wrote: On 06/10/2012 04:57 AM, Andreas Boll wrote: @ release manager Is there a script for converting the git shortlog into html in relnotes-*.html or are they converted by hand? The reason I'm asking is that not all html special chars are correctly escaped and

[Mesa-dev] [PATCH] Fix make process on Linux Mint 13 x64.

2012-06-12 Thread Aaron Watry
Previously, rbug_*.c would fail to compile with incomplete prototype errors when make was run from the command line on my machine. My IDE always built fine, and still does after this patch (Netbeans 7.1.2). Most of the includes from files in gallium/auxiliary/rbug/* were assuming an rbug/ subdirec

Re: [Mesa-dev] [PATCH] Mesa: Fix a race in the build

2012-06-12 Thread Dan Nicholson
On 6/12/12, Stéphane Marchesin wrote: > From: Mike Frysinger > > The intent of the message above it is right (we need to build those > dependencies in that order) but the implementation is wrong, as it > can be executed in any order. To enforce the order, invoke make > multiple times. > --- > sr

[Mesa-dev] [PATCH] Fix dependency generation for src/mesa/main directory

2012-06-12 Thread Chris Rankin
Hi, I have a Lenovo T60p laptop running 32 bit Fedora 17, and this patch fixes makedepend's behaviour when generating the src/mesa/depends file. Prior to this patch, makedepend had hung while still consuming 100% of the CPU. Strangely, none of the other PCs that I compile Mesa on are affected

[Mesa-dev] [PATCH] i965/blorp: Implement source clipping.

2012-06-12 Thread Paul Berry
This patch modifies blorp blits (which are used for MSAA) to properly account for clipping of source coordinates. Previously, if we detected the possibility of source clipping, we would fall back to the blit meta-op, which doesn't support MSAA and is very slow for depth and stencil buffers. Fixes

[Mesa-dev] [PATCH] Mesa: Fix a race in the build

2012-06-12 Thread Stéphane Marchesin
From: Mike Frysinger The intent of the message above it is right (we need to build those dependencies in that order) but the implementation is wrong, as it can be executed in any order. To enforce the order, invoke make multiple times. --- src/mesa/Makefile |8 ++-- 1 files changed, 6 in

[Mesa-dev] gprof

2012-06-12 Thread Frank Henigman
I see in the list archives that gprof support was pulled a few years ago. Anyone remember why? Is there any chance of working today? I tried compiling with -pg but haven't manage to get any profiling info yet. Thanks. ___ mesa-dev mailing list mesa-dev@l

[Mesa-dev] [Bug 50316] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.cos

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50316 Thomas Capricelli changed: What|Removed |Added CC||or...@freehackers.org -- Configure

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50317 Thomas Capricelli changed: What|Removed |Added CC||or...@freehackers.org -- Configure

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50317 --- Comment #2 from Thomas Capricelli 2012-06-12 14:19:56 PDT --- Hit by this bug when trying flightgear on latest libdrm/mesa/xorg-server/xf86-video-ati. All compiled today from git/svn/whatever: LLVM ERROR: Cannot select: target intrinsic %ll

Re: [Mesa-dev] [PATCH 00/11] docs: html cleanup

2012-06-12 Thread Andreas Boll
2012/6/12 Kenneth Graunke : > On 06/11/2012 11:18 AM, Andreas Boll wrote: >> 2012/6/11 Brian Paul : >>> On 06/10/2012 04:57 AM, Andreas Boll wrote: Hi, the following patch series is the first part of cleaning up docs/. Please review and commit. >>> >> >> Please commit/

[Mesa-dev] [PATCH] i965: Add hardware context support.

2012-06-12 Thread Kenneth Graunke
With fixes and updates from Ben Widawsky and comments from Paul Berry. This should not be pushed until libdrm 2.4.36 is released with Ben's hardware context support. I haven't hooked up the context destroy function yet as I'm not entirely sure about tear-down, but they will be freed on fd close,

[Mesa-dev] [PATCH v2 17/21] mesa/samplerobj: Allow meta module to call sampler functions

2012-06-12 Thread Pauli Nieminen
To allow meta module to use sample objects mesa GL functions need to be visible and linkable for meta module. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/main/samplerobj.c |8 src/mesa/main/samplerobj.h | 11 +++ 2 files changed, 15 insertions(+), 4

[Mesa-dev] [PATCH v2 13/21] mesa/ff_shader: Fix sampler state reading

2012-06-12 Thread Pauli Nieminen
Fixed function fragment shader generator was incorrectly read texture sampling state directly from texture object. To make sure that ARB_sampler_object works correctly shader generator has to use the bound sampler if one exist. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/

[Mesa-dev] [PATCH v2 07/21] mesa/samplerobj: Support EXT_texture_sRGB_decode

2012-06-12 Thread Pauli Nieminen
sRGBDecode state is part of sampler object state but mesa was missing handlers to access the state. This patch adds the support for required state changes and queries. GL_EXT_texture_sRGB_decode issue 4: "4) Should we add forward-looking support for ARB_sampler_objects? RESOLVED: YES

[Mesa-dev] [PATCH v2 18/21] meta: Use sampler object for mipmap generation

2012-06-12 Thread Pauli Nieminen
Sampler objects are perfect for meta operations.Sampler object is separate state object that shadows the sampling state in texture object. With sampler object mipmap can maintain same sampling state for all subsequent generation requests. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul ---

[Mesa-dev] [PATCH v2 20/21] meta: Add sampler object to texture decompression

2012-06-12 Thread Pauli Nieminen
Sampler objects can be used to shadow texture object state without modifying original application state. Decompression path feels a bit like path where caching shouldn't happen. But as everything else is cached already I decided to cache sampler state too. Signed-off-by: Pauli Nieminen Reviewed-b

[Mesa-dev] [PATCH v2 19/21] meta: texture rectangle textures may not have mipmaps

2012-06-12 Thread Pauli Nieminen
Avoid INVALID_OPERATION error if decompressing rectangle texture. Setting mipmap level limits for those textures is error that must not be hit by meta code to mislead user. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/drivers/common/meta.c |6 -- 1 file changed, 4

[Mesa-dev] [PATCH v2 15/21] mesa: Make ARB_sampler_objects mandatory

2012-06-12 Thread Pauli Nieminen
To allow meta acceleration operations to use sampler objects the ARB_sampler_objects extension needs to be mandatory for all drivers. Because the extension doesn't have any hardware dependencies it is trivial to implement. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/drive

[Mesa-dev] [PATCH v2 21/21] meta: Use sampler object in framebuffer blit

2012-06-12 Thread Pauli Nieminen
Framebuffer blit needs to setup texture sampling to match application requested blit operation. Sampler object can be used to avoid changes to texture object. But caching sampler object doesn't make much sense when we need to synamically change it based on filtering parameters. Signed-off-by: Paul

[Mesa-dev] [PATCH v2 12/21] radeon&r200: Add support for ARB_shader_object

2012-06-12 Thread Pauli Nieminen
Preparation for the mandator support of ARB_shader_object. I have tested this patch with rv280 only. While only compile testing radeon changes. Does someone want to run piglit tests for radeon too? Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/drivers/dri/r200/r200_tex.c

[Mesa-dev] [PATCH v2 10/21] nouveau: Add support for ARB_sampler_object

2012-06-12 Thread Pauli Nieminen
ARB_sampler_object is very simple software only extension to support. I want to make it mandator extension for Mesa drivers to allow meta module to use it. This patch add support for the extension to nouveau. It is completely untested search and replace patch. I hope someone with old NV hardware c

[Mesa-dev] [PATCH v2 11/21] radeon: Fix printf format not to warn in 64bit

2012-06-12 Thread Pauli Nieminen
When I build tested radeon changes I noticed two warnings about format size missmatch in 64bit. I decided to clean them to make relevant compiler warnings easier to spot. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/drivers/dri/radeon/radeon_blit.c |4 ++-- 1 file chan

[Mesa-dev] [PATCH v2 08/21] mesa/samplerobj: Avoid crash in sampler query if texture unit is disabled

2012-06-12 Thread Pauli Nieminen
Sampler queries are so far made only for enabled texture unit. But if any code would query sampler before checking texture unit state that would result to NULL deference. Making the inline helper easier to use with NULL check makes a lot sense because compiler is likely to combine the checks for t

[Mesa-dev] [PATCH v2 06/21] mesa: Move DepthMode to texture object

2012-06-12 Thread Pauli Nieminen
GL_DEPTH_TEXTURE_MODE isn't meant to be part of sampler state based on compatibility profile specifications. OpenGL specification 4.1 compatibility 20100725 3.9.2: "... The values accepted in the pname parameter are TEXTURE_WRAP_S, TEXTURE_WRAP_T, TEXTURE_WRAP_R, TEXTURE_MIN_- FILTER, TEXTURE_MAG_

[Mesa-dev] [PATCH v2 14/21] mesa/program: Use sampler object state if present

2012-06-12 Thread Pauli Nieminen
CompareFailValue is part of Sampler state that needs to be read from bound sampler object if present. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/program/prog_statevars.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/program/prog_stat

[Mesa-dev] [PATCH v2 05/21] mesa: Remove unnecessary parameters CompressedTexImage

2012-06-12 Thread Pauli Nieminen
In tune with previous patches. Again there is duplication of information in function parameters that is good to remove. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 -- src/mesa/main/dd.h |3 ---

[Mesa-dev] [PATCH v2 09/21] mesa/samplerobj: Set state dirty in bind if state is shared

2012-06-12 Thread Pauli Nieminen
State changes in share group must be updated when the object is rebound to the binding point. That requires mesa to set texture state dirty when binding sampler object in a share group. GL 4.2 specification appendix "Shared Objects and Multiple Contexts" D3.3 Rule 4: "If the contents of an object

[Mesa-dev] [PATCH v2 04/21] mesa: Remove unnecessary parameters from AllocTextureImageBuffer

2012-06-12 Thread Pauli Nieminen
Size and format information is always stored in gl_texture_image structure. That makes it preferable to remove duplicate information from parameters to make interface easier to understand. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa/drivers/dri/intel/intel_tex.c |

[Mesa-dev] [PATCH v2 03/21] mesa: Remove unnecessary parameters from TexImage

2012-06-12 Thread Pauli Nieminen
gl_texture_image structure always holds size and internal format before TexImage driver hook is called. Those passing same information in function parameters only duplicates information making the interface harder to understand. Signed-off-by: Pauli Nieminen Reviewed-by: Brian Paul --- src/mesa

[Mesa-dev] [PATCH v2 00/21] ARB_sampler_object and minor fixes

2012-06-12 Thread Pauli Nieminen
I updated patches based on review comments and run piglit for swrast. There is also new patch to fix sampler object binding to update shared state in share group. Too bad swrast fails randomly all tests that use front buffer because tests aren't waiting for map event. The mapping is required for X

[Mesa-dev] [PATCH v2 01/21] mesa/format_unpack: Fix YCBCR unpack

2012-06-12 Thread Pauli Nieminen
The YCBCR unpack was reading one RGBA value from 4 bytes of YCBCR texture. But single pixel is only 2 bytes in the format. After noticing that error Ville told me that second chroma sample has to be average to match MPEG chroma subsampling. MPEG defines horizontally alligment for chroma sample to

[Mesa-dev] [PATCH v2 02/21] mesa: Check index buffer offset in DrawElements

2012-06-12 Thread Pauli Nieminen
DrawElements checks for count beeing larger than index buffer object. But application can specify offset to buffer leading to buffer overflow again. ARB_vertex_buffer_object leaves the case undefined but allows program termination. But if we do check the index buffer size it makes sense to check i

Re: [Mesa-dev] Clarifications w.r.t MSAA

2012-06-12 Thread Jerome Glisse
On Tue, Jun 12, 2012 at 1:34 PM, Christoph Bumiller wrote: > On 06/12/2012 06:52 PM, Jerome Glisse wrote: >> On Tue, Jun 12, 2012 at 8:39 AM, Christoph Bumiller >> wrote: >>> On 06/12/2012 02:25 PM, Olivier Galibert wrote: On Tue, Jun 12, 2012 at 01:50:08PM +0200, Christoph Bumiller wrote: >

Re: [Mesa-dev] Clarifications w.r.t MSAA

2012-06-12 Thread Christoph Bumiller
On 06/12/2012 06:52 PM, Jerome Glisse wrote: > On Tue, Jun 12, 2012 at 8:39 AM, Christoph Bumiller > wrote: >> On 06/12/2012 02:25 PM, Olivier Galibert wrote: >>> On Tue, Jun 12, 2012 at 01:50:08PM +0200, Christoph Bumiller wrote: > First question: how many depths should be computed, and for w

Re: [Mesa-dev] Clarifications w.r.t MSAA

2012-06-12 Thread Jerome Glisse
On Tue, Jun 12, 2012 at 8:39 AM, Christoph Bumiller wrote: > On 06/12/2012 02:25 PM, Olivier Galibert wrote: >> On Tue, Jun 12, 2012 at 01:50:08PM +0200, Christoph Bumiller wrote: First question: how many depths should be computed, and for which coordinates? Which of these values is asso

[Mesa-dev] [Bug 50976] Fails to build with error: git_sha1.h: No such file or directory

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50976 Darxus changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #2 from Darxus 2012-06-12

Re: [Mesa-dev] [PATCH] i965: enable ARB_instanced_arrays extension

2012-06-12 Thread Eric Anholt
On Fri, 8 Jun 2012 14:16:47 -0700, Jordan Justen wrote: > On Mon, Jun 4, 2012 at 1:31 PM, Eric Anholt wrote: > > On Sun, 27 May 2012 21:08:07 -0700, Jordan Justen > > wrote: > >> Set the step_rate value when drawing to implement > >> ARB_instanced_arrays for gen >= 4. > > > >> @@ -504,7 +513,7

Re: [Mesa-dev] Mesa (master): automake: Add a prefix variable for libglsl sources.

2012-06-12 Thread Dan Nicholson
On 6/11/12, Eric Anholt wrote: > On Mon, 11 Jun 2012 10:02:34 -0700 (PDT), Jose Fonseca > wrote: >> This breaks the SCons build, which parses src/glsl/Makefile.sources, >> and can't understand "$(GLSL_SRCDIR)/" as it only supports a simple >> subset of Make syntax. >> >> Is there some other way t

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50317 --- Comment #1 from Laurent carlier 2012-06-12 08:23:59 PDT --- Amnesia game also hit that error with llvm OpenGL renderer string: Gallium 0.4 on AMD RV770 OpenGL version string: 2.1 Mesa 8.1-devel (git-529476b) R6000_LLVM=0 workaround the pro

Re: [Mesa-dev] [PATCH 1/3] glsl: Check for zero vectors in ir_binop_dot

2012-06-12 Thread Kenneth Graunke
On 06/05/2012 11:52 AM, Matt Turner wrote: > --- > src/glsl/opt_algebraic.cpp |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp > index cade961..1567ecd 100644 > --- a/src/glsl/opt_algebraic.cpp > +++ b/src/

[Mesa-dev] [Bug 50976] Fails to build with error: git_sha1.h: No such file or directory

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50976 Eric Anholt changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 50996] gnome-shell, video playing fail to work properly

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50996 --- Comment #1 from kaliko 2012-06-12 07:09:07 PDT --- Here is what I got in the gnome-shell log (~/.xsession-errors): -8< gnome-session-is-accelerated: No hardware 3D support. gnome-se

[Mesa-dev] [Bug 50976] Fails to build with error: git_sha1.h: No such file or directory

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50976 Michael Lange changed: What|Removed |Added CC||micha...@gmx.org -- Configure bugmail:

Re: [Mesa-dev] Clarifications w.r.t MSAA

2012-06-12 Thread Christoph Bumiller
On 06/12/2012 02:25 PM, Olivier Galibert wrote: > On Tue, Jun 12, 2012 at 01:50:08PM +0200, Christoph Bumiller wrote: >>> First question: how many depths should be computed, and for which >>> coordinates? Which of these values is associated with which sample? >> >> One for each sample point. The de

Re: [Mesa-dev] Clarifications w.r.t MSAA

2012-06-12 Thread Olivier Galibert
On Tue, Jun 12, 2012 at 01:50:08PM +0200, Christoph Bumiller wrote: > > First question: how many depths should be computed, and for which > > coordinates? Which of these values is associated with which sample? > > One for each sample point. The depth buffer will be multisampled as well. > Coverage

Re: [Mesa-dev] Clarifications w.r.t MSAA

2012-06-12 Thread Christoph Bumiller
On 06/12/2012 12:27 PM, Olivier Galibert wrote: > Hi all, > > I'm getting a little lost in all the interactions between the > different parts of the GL standards and what I understand of the > expectations when it comes to MSAA. It would be nice if I could have > some clarifications. > > I'll

[Mesa-dev] Clarifications w.r.t MSAA

2012-06-12 Thread Olivier Galibert
Hi all, I'm getting a little lost in all the interactions between the different parts of the GL standards and what I understand of the expectations when it comes to MSAA. It would be nice if I could have some clarifications. I'll start with what I think I understand (and please correct me when

[Mesa-dev] [Bug 50996] gnome-shell, video playing fail to work properly

2012-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50996 kaliko changed: What|Removed |Added AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop. |

Re: [Mesa-dev] [PATCH 00/11] docs: html cleanup

2012-06-12 Thread Kenneth Graunke
On 06/11/2012 11:18 AM, Andreas Boll wrote: > 2012/6/11 Brian Paul : >> On 06/10/2012 04:57 AM, Andreas Boll wrote: >>> >>> Hi, >>> >>> the following patch series is the first part of cleaning up docs/. >>> >>> Please review and commit. >> > > Please commit/push. I don't have commit access. > >>

Re: [Mesa-dev] [PATCH] add test for wayland drm, XRGB/YUYV is supported

2012-06-12 Thread Zhao, Halley
Hi Kristian: update the test case to src/egl/wayland/wayland-drm: From f2ab9c439ba7158b6e978a9d214a9b9e80ec8c6e Mon Sep 17 00:00:00 2001 From: Zhao Halley Date: Tue, 5 Jun 2012 14:59:56 +0800 Subject: [PATCH 9/9] test: test case drm-test-client in src/egl/wayland/wayland-drm - it shows how wa

Re: [Mesa-dev] [PATCH 00/11] docs: html cleanup

2012-06-12 Thread Andreas Boll
Cc: Ian 2012/6/11 Andreas Boll : > 2012/6/11 Brian Paul : >> On 06/10/2012 04:57 AM, Andreas Boll wrote: >>> >>> Hi, >>> >>> the following patch series is the first part of cleaning up docs/. >>> >>> Please review and commit. >> > > Please commit/push. I don't have commit access. > >> >> I'm not a