Re: [Mesa-dev] [PATCH 4/4] mesa: remove MALLOC, CALLOC, FREE macros

2012-08-31 Thread Matt Turner
On Thu, Aug 30, 2012 at 7:17 PM, Brian Paul brian.e.p...@gmail.com wrote: From: Brian Paul bri...@vmware.com These macros go way back to the early days of Mesa before there was valgrind, etc. for debugging memory errors. I used to use the macros to plug in my own debugging routines. We've

[Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Kenneth Graunke
Haswell moved the Cut Index Enable bit from the INDEX_BUFFER packet to a new 3DSTATE_VF packet, so we need to emit that. Also, it requires us to specify the cut index rather than assuming it's 0x. This adds a new Haswell-specific tracked state atom to gen7_atoms. Normally, we would

[Mesa-dev] [PATCH] i965/fs: Don't use brw-fragment_program in calculate_urb_setup().

2012-08-31 Thread Kenneth Graunke
Reading brw-fragment_program is nonsensical in compiler code: it contains the currently active program (if any), not the one currently being compiled. Attempting to access it may either lead to crashes (null pointer dereference if no program is active) or wrong results. Fixes piglit regressions

Re: [Mesa-dev] radeonsi: first successful piglit run

2012-08-31 Thread Christian König
On 30.08.2012 22:31, Tom Stellard wrote: On Thu, Aug 30, 2012 at 07:00:44PM +0200, Christian König wrote: Hi everybody, with the following patchset the radeonsi driver finally completes a run of nearly all tests in Piglits quick-driver profile without an GPU hang or X server crash. Which

Re: [Mesa-dev] [PATCH 6/6] winsys/radeon: create only one winsys for each fd

2012-08-31 Thread Christian König
On 30.08.2012 20:06, Marek Olšák wrote: Reviewed-by: Marek Olšák mar...@gmail.com Shouldn't accesses to fd_tab be guarded by a mutex? Yes probably, but I'm still not sure if this solution to the problem is a good idea or not. That both GLAMOR and GLX end up creating a separate winsys with

[Mesa-dev] [PATCH] r600g: adjust QUANT_MODE for higher precision

2012-08-31 Thread Vadim Girlin
Use 1/256 for R6xx/7xx, 1/4096 for evergreen, instead of default 1/16. Helps to pass some piglit tests (fbo, multisample). Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/evergreen_state.c | 3 ++- src/gallium/drivers/r600/evergreend.h | 11 +++

Re: [Mesa-dev] radeonsi: first successful piglit run

2012-08-31 Thread Christian König
On 31.08.2012 06:55, Michel Dänzer wrote: On Don, 2012-08-30 at 13:30 -0400, Alex Deucher wrote: On Thu, Aug 30, 2012 at 1:14 PM, Tom Stellard t...@stellard.net wrote: On Thu, Aug 30, 2012 at 07:00:44PM +0200, Christian König wrote: Hi everybody, with the following patchset the radeonsi

[Mesa-dev] [Bug 39846] can't compile mesa ‘__u64’problem.

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39846 --- Comment #5 from Jerome St-Louis jerstlo...@gmail.com 2012-08-31 11:03:55 UTC --- I've ran accross the same issue, and commenting out the: // #if defined(__GNUC__) !defined(__STRICT_ANSI__) line around __u64 definition in

Re: [Mesa-dev] [PATCH] radeon/llvm: Convert to Automake

2012-08-31 Thread Tom Stellard
On Thu, Aug 30, 2012 at 02:11:22PM -0700, Matt Turner wrote: On Thu, Aug 30, 2012 at 1:19 PM, Tom Stellard t...@stellard.net wrote: On Thu, Aug 30, 2012 at 10:47:55AM -0700, Matt Turner wrote: On Thu, Aug 30, 2012 at 9:55 AM, tstel...@gmail.com wrote: From: Tom Stellard

Re: [Mesa-dev] [PATCH 1/4] mesa: s/MALLOC/malloc/

2012-08-31 Thread Brian Paul
On 08/31/2012 01:44 AM, Kenneth Graunke wrote: For the series: Reviewed-by: Kenneth Graunkekenn...@whitecape.org Thanks (and Matt). But I found some more instances of this macro down in the src/mesa/dri/common/ code that I missed before (by grepping with 'MALLOC(' while the code reads

[Mesa-dev] [PATCH 1/3] mesa: s/MALLOC/malloc/

2012-08-31 Thread Brian Paul
From: Brian Paul bri...@vmware.com v2: replace instances in dri/common/ dirs --- src/gallium/state_trackers/glx/xlib/glx_usefont.c |2 +- src/gallium/state_trackers/glx/xlib/xm_api.c |4 ++-- src/mesa/drivers/dri/common/xmlconfig.c | 14 +++---

[Mesa-dev] [PATCH 2/3] mesa: s/CALLOC/calloc/

2012-08-31 Thread Brian Paul
From: Brian Paul bri...@vmware.com v2: replace instances in dri/common/ dirs --- src/mesa/drivers/dri/intel/intel_screen.c | 10 +- src/mesa/drivers/dri/r200/r200_context.c|2 +- src/mesa/drivers/dri/r200/r200_state_init.c |4 ++--

[Mesa-dev] [PATCH 3/3] mesa: s/FREE/free/

2012-08-31 Thread Brian Paul
From: Brian Paul bri...@vmware.com v2: replace instances in dri/common/ dirs --- .../state_trackers/dri/common/dri_context.c|6 +- src/gallium/state_trackers/dri/common/dri_screen.c | 10 ++-- src/gallium/state_trackers/glx/xlib/glx_usefont.c |2 +-

[Mesa-dev] [Bug 54325] New: Account request

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54325 Bug #: 54325 Summary: Account request Classification: Unclassified Product: Mesa Version: unspecified Platform: Other OS/Version: All Status: NEW Severity:

[Mesa-dev] [Bug 54325] Account request

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54325 --- Comment #1 from Andreas Boll andreas.boll@gmail.com 2012-08-31 14:22:13 UTC --- Created attachment 66407 -- https://bugs.freedesktop.org/attachment.cgi?id=66407 ssh public key -- Configure bugmail:

[Mesa-dev] [Bug 54325] Account request

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54325 --- Comment #2 from Andreas Boll andreas.boll@gmail.com 2012-08-31 14:23:36 UTC --- Created attachment 66408 -- https://bugs.freedesktop.org/attachment.cgi?id=66408 gpg public key -- Configure bugmail:

[Mesa-dev] [Bug 54293] Undefined symbol sqrt firt referenced in file build/sunos-debug/glsl/libglsl.a(so_pp.os)

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54293 Brian Paul brian.e.p...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 54325] Account request

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54325 Brian Paul brian.e.p...@gmail.com changed: What|Removed |Added AssignedTo|mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 54326] New: When building 32 bit on 64 bit, build ends saying it can't find 32 bit libkms.so

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54326 Bug #: 54326 Summary: When building 32 bit on 64 bit, build ends saying it can't find 32 bit libkms.so Classification: Unclassified Product: Mesa Version: unspecified

[Mesa-dev] [PATCH] mesa: also bump version in Makefile.am and configure.ac to 9.0

2012-08-31 Thread Andreas Boll
--- Makefile.am |2 +- configure.ac |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index e8c7b59..36bcf1f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -52,7 +52,7 @@ distclean-local: # Rules for making release tarballs

Re: [Mesa-dev] [PATCH 2/2] intel: Support new dri image interface v2

2012-08-31 Thread Pekka Paalanen
On Fri, 31 Aug 2012 15:22:04 +0200 Jakob Bornecrantz ja...@vmware.com wrote: Follow up to the previous patch, kept seperate for easier viewing, will be merged with previous patch before commiting. v2: Should fix YUV pitch/stride == 0. Signed-off-by: Jakob Bornecrantz ja...@vmware.com ---

[Mesa-dev] [PATCH] docs: update relnotes-9.0

2012-08-31 Thread Andreas Boll
--- docs/relnotes-9.0.html | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/docs/relnotes-9.0.html b/docs/relnotes-9.0.html index 164c8e9..1e3a11b 100644 --- a/docs/relnotes-9.0.html +++ b/docs/relnotes-9.0.html @@ -37,10 +37,14 @@ Note: some of the new

[Mesa-dev] [Bug 52996] Read out of bounds in swizzle_for_size() (MesaLib/src/mesa/program/ir_to_mesa.cpp)

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52996 --- Comment #3 from Alexander Potapenko gli...@google.com 2012-08-31 15:03:18 UTC --- I've managed to reproduce this locally. Inserting fprintf() calls into third_party/mesa/MesaLib/src/mesa/program/ir_to_mesa.cpp shows that swizzle_for_size(0)

Re: [Mesa-dev] [PATCH] mesa: also bump version in Makefile.am and configure.ac to 9.0

2012-08-31 Thread Brian Paul
On 08/31/2012 08:43 AM, Andreas Boll wrote: --- Makefile.am |2 +- configure.ac |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index e8c7b59..36bcf1f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -52,7 +52,7 @@ distclean-local: #

Re: [Mesa-dev] [PATCH 2/2] intel: Support new dri image interface v2

2012-08-31 Thread Kristian Høgsberg
On Fri, Aug 31, 2012 at 9:22 AM, Jakob Bornecrantz ja...@vmware.com wrote: Follow up to the previous patch, kept seperate for easier viewing, will be merged with previous patch before commiting. v2: Should fix YUV pitch/stride == 0. Signed-off-by: Jakob Bornecrantz ja...@vmware.com Works

[Mesa-dev] r600: performance reading from staging texture

2012-08-31 Thread Vic Lee
Hi, In my application, I need to read pixels back to system memory for every rendered frame. My approach is to create a chain of textures with PIPE_USAGE_STAGING flag, and copy the render target to the staging textures before reading them to avoid pipeline stall. Now I found out as in the

Re: [Mesa-dev] [PATCH 2/2] intel: Support new dri image interface v2

2012-08-31 Thread Scott Moreau
On Fri, Aug 31, 2012 at 10:39 AM, Kristian Høgsberg k...@bitplanet.netwrote: On Fri, Aug 31, 2012 at 9:22 AM, Jakob Bornecrantz ja...@vmware.com wrote: Follow up to the previous patch, kept seperate for easier viewing, will be merged with previous patch before commiting. v2: Should fix

Re: [Mesa-dev] [PATCH] i965/fs: Disable write masking when setting up texturing m0.

2012-08-31 Thread Paul Berry
On 30 August 2012 11:07, Eric Anholt e...@anholt.net wrote: I don't know of any hangs/rendering failures that this fixes, but it sure looks necessary. Good catch! This definitely seems like the kind of thing that could lead to rare/unpredictable problems. It looks like there is similar code

[Mesa-dev] [PATCH 2/8] dri: Reuse dri_test.c for stub glapi symbols for unit testing.

2012-08-31 Thread Eric Anholt
This file was previously used to provide stubs for the link test. Now that the link test wasn't used any more, there's no more purpose for this file. However, these will be nice for linking unit tests against the whole contents of a dri driver. --- src/mesa/drivers/dri/common/Makefile.am |8

[Mesa-dev] [PATCH 3/8] i965: Make a linkable library for the contents of i965_dri.so.

2012-08-31 Thread Eric Anholt
To do unit testing of i965, we want to be able to link against the driver's symbols and prod them. If we don't have a separate lib from our loadable module, libtool gets super whiny. --- src/mesa/drivers/dri/i965/.gitignore |1 + src/mesa/drivers/dri/i965/Makefile.am | 17

[Mesa-dev] [PATCH 1/8] i965: Clear brw_compile on setup.

2012-08-31 Thread Eric Anholt
I noticed in valgrind that p-single_program_flow was used while uninitialized. Everything else zeroed out brw_compile, but this is better API. --- src/mesa/drivers/dri/i965/brw_eu.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_eu.c

[Mesa-dev] [PATCH 5/8] i965: Prepare the uip/jip setting for compacted instructions in the program.

2012-08-31 Thread Eric Anholt
The first cut at instruction compaction won't compact things that would change control flow jump distances, but we do need to still be able to walk the instruction stream, which involves jumping by 8 or 16 bytes between instructions. --- src/mesa/drivers/dri/i965/brw_eu_emit.c | 57

[Mesa-dev] [PATCH 8/8] i965: Add support for instruction compression on Gen7.

2012-08-31 Thread Eric Anholt
From: Kenneth Graunke kenn...@whitecape.org Reduces l4d2 program size from 1195kb to 919kb. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_eu.c |2 + src/mesa/drivers/dri/i965/brw_eu.h |1 +

[Mesa-dev] [PATCH 7/8] i965: Support instruction compaction between control flow.

2012-08-31 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_eu_compact.c | 111 ++-- 1 file changed, 87 insertions(+), 24 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index 2c15c85..dd661f5 100644 ---

[Mesa-dev] [PATCH 6/8] i965: Add support for instruction compaction.

2012-08-31 Thread Eric Anholt
This reduces program size by using some smaller encodings for common bit patterns in the Gen ISA, with the hope of making programs fit in the instruction cache better. Unfortunately, we don't have any evidence for any particular program being measurably helped. ---

[Mesa-dev] [PATCH 1/2] mesa: add context version routines

2012-08-31 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Based on the discussion July 26-27 in the thread [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor. src/mesa/main/version.h | 54 +++ 1 file changed, 54

[Mesa-dev] [PATCH 2/2] mesa: utilize context version routines

2012-08-31 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/nouveau/nouveau_context.c |2 +- src/mesa/main/context.h|3 ++- src/mesa/main/enable.c |4 ++-- src/mesa/main/fbobject.c | 28

Re: [Mesa-dev] [PATCH 1/2] mesa: add context version routines

2012-08-31 Thread Jordan Justen
On Fri, Aug 31, 2012 at 11:52 AM, Jordan Justen jordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Based on the discussion July 26-27 in the thread [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor.

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Paul Berry
On 31 August 2012 00:22, Kenneth Graunke kenn...@whitecape.org wrote: Haswell moved the Cut Index Enable bit from the INDEX_BUFFER packet to a new 3DSTATE_VF packet, so we need to emit that. Also, it requires us to specify the cut index rather than assuming it's 0x. This adds a new

[Mesa-dev] [PATCH] i965: Stop putting 8 NOPs after each prorgam.

2012-08-31 Thread Eric Anholt
As far as I can see, the intention of the requirement that we do so is to prevent instruction prefetch from wandering out into either unmapped memory or memory with a different caching type, and hanging the chip. The kernel makes sure that the page after your BO has a valid page of the same

Re: [Mesa-dev] [PATCH] i965/fs: Don't use brw-fragment_program in calculate_urb_setup().

2012-08-31 Thread Paul Berry
On 31 August 2012 01:00, Kenneth Graunke kenn...@whitecape.org wrote: Reading brw-fragment_program is nonsensical in compiler code: it contains the currently active program (if any), not the one currently being compiled. Attempting to access it may either lead to crashes (null pointer

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Jordan Justen
On Fri, Aug 31, 2012 at 12:08 PM, Paul Berry stereotype...@gmail.com wrote: On 31 August 2012 00:22, Kenneth Graunke kenn...@whitecape.org wrote: Haswell moved the Cut Index Enable bit from the INDEX_BUFFER packet to a new 3DSTATE_VF packet, so we need to emit that. Also, it requires us to

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Jordan Justen
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com 2 minor questions below... On Fri, Aug 31, 2012 at 12:22 AM, Kenneth Graunke kenn...@whitecape.org wrote: Haswell moved the Cut Index Enable bit from the INDEX_BUFFER packet to a new 3DSTATE_VF packet, so we need to emit that. Also, it

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Paul Berry
On 31 August 2012 12:52, Jordan Justen jljus...@gmail.com wrote: On Fri, Aug 31, 2012 at 12:08 PM, Paul Berry stereotype...@gmail.com wrote: On 31 August 2012 00:22, Kenneth Graunke kenn...@whitecape.org wrote: Haswell moved the Cut Index Enable bit from the INDEX_BUFFER packet to a new

Re: [Mesa-dev] [PATCH 2/2] mesa: utilize context version routines

2012-08-31 Thread Matt Turner
On Fri, Aug 31, 2012 at 11:52 AM, Jordan Justen jordan.l.jus...@intel.com wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index b713f5f..00852ad 100644 --- a/src/mesa/main/enable.c +++ b/src/mesa/main/enable.c @@

Re: [Mesa-dev] [PATCH] radeon/llvm: Convert to Automake

2012-08-31 Thread Matt Turner
On Fri, Aug 31, 2012 at 6:04 AM, Tom Stellard t...@stellard.net wrote: On Thu, Aug 30, 2012 at 02:11:22PM -0700, Matt Turner wrote: On Thu, Aug 30, 2012 at 1:19 PM, Tom Stellard t...@stellard.net wrote: On Thu, Aug 30, 2012 at 10:47:55AM -0700, Matt Turner wrote: On Thu, Aug 30, 2012 at 9:55

[Mesa-dev] [PATCH] mesa: don't wait in _mesa_ClientWaitSync if timeout is 0

2012-08-31 Thread Vadim Girlin
From ARB_sync spec: If the value of timeout is zero, then ClientWaitSync does not block, but simply tests the current state of sync. TIMEOUT_EXPIRED will be returned in this case if sync is not signaled, even though no actual wait was performed. Fixes random fails of the

Re: [Mesa-dev] [PATCH] radeon/llvm: Convert to Automake

2012-08-31 Thread Tom Stellard
On Fri, Aug 31, 2012 at 01:26:33PM -0700, Matt Turner wrote: On Fri, Aug 31, 2012 at 6:04 AM, Tom Stellard t...@stellard.net wrote: On Thu, Aug 30, 2012 at 02:11:22PM -0700, Matt Turner wrote: On Thu, Aug 30, 2012 at 1:19 PM, Tom Stellard t...@stellard.net wrote: On Thu, Aug 30, 2012 at

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Paul Berry
On 31 August 2012 13:16, Paul Berry stereotype...@gmail.com wrote: Yeah, good point. I'd be ok with that. Keeping in mind, of course, that after this patch lands, the bug will be in two places rather than one :) Scratch that. Ken's patch implements my suggestion #1 for Haswell, so the bug

Re: [Mesa-dev] [PATCH] i965/fs: Don't use brw-fragment_program in calculate_urb_setup().

2012-08-31 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: Reading brw-fragment_program is nonsensical in compiler code: it contains the currently active program (if any), not the one currently being compiled. Attempting to access it may either lead to crashes (null pointer dereference if no program is

Re: [Mesa-dev] [PATCH] mesa: don't wait in _mesa_ClientWaitSync if timeout is 0

2012-08-31 Thread Eric Anholt
Vadim Girlin vadimgir...@gmail.com writes: From ARB_sync spec: If the value of timeout is zero, then ClientWaitSync does not block, but simply tests the current state of sync. TIMEOUT_EXPIRED will be returned in this case if sync is not signaled, even though no actual wait

Re: [Mesa-dev] [PATCH] mesa: don't wait in _mesa_ClientWaitSync if timeout is 0

2012-08-31 Thread Brian Paul
On 08/31/2012 02:53 PM, Eric Anholt wrote: Vadim Girlinvadimgir...@gmail.com writes: From ARB_sync spec: If the value oftimeout is zero, then ClientWaitSync does not block, but simply tests the current state ofsync. TIMEOUT_EXPIRED will be returned in this case ifsync is

Re: [Mesa-dev] [PATCH 1/2] mesa: add context version routines

2012-08-31 Thread Brian Paul
On 08/31/2012 12:52 PM, Jordan Justen wrote: Signed-off-by: Jordan Justenjordan.l.jus...@intel.com --- Based on the discussion July 26-27 in the thread [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor. src/mesa/main/version.h | 54

[Mesa-dev] [PATCH] i965: Don't leave dangling pointer to brw context on failure

2012-08-31 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Otherwise intelDestroyContext would try to dereference the pointer to freed memory. NOTE: This is a candidate for the 9.0 branch. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54301 ---

[Mesa-dev] [PATCH 3/4] i965: Make the param pointer arrays for the WM dynamically sized.

2012-08-31 Thread Eric Anholt
Saves 26.5MB of wasted memory allocation in the l4d2 demo. v2: Rebase on compare func change, fix comments. Reviewed-by: Ian Romanick ian.d.roman...@intel.com (v1) --- src/mesa/drivers/dri/i965/brw_context.h |7 -- src/mesa/drivers/dri/i965/brw_fs.cpp|2 --

[Mesa-dev] [PATCH 4/4] i965: Make the param pointer arrays for the VS dynamically sized.

2012-08-31 Thread Eric Anholt
Saves 96MB of wasted memory in the l4d2 demo. v2: Rebase on compare func change, change brace style. Reviewed-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h |4 ++--

[Mesa-dev] [PATCH 1/4] glsl: Count builtin uniforms against uniform component limits.

2012-08-31 Thread Eric Anholt
We don't fully process the builtin uniforms, but at least num_uniform_components reflects reality now. Reviewed-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/link_uniforms.cpp |5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 2/4] i965: Add functions for comparing two brw_wm/vs_prog_data structs.

2012-08-31 Thread Eric Anholt
Currently, this just avoids comparing all unused parts of param[] and pull_param[], but it's a step toward getting rid of those giant statically sized arrays. --- src/mesa/drivers/dri/i965/brw_context.h | 29 ++- src/mesa/drivers/dri/i965/brw_state_cache.c | 10

[Mesa-dev] [PATCH] meta: Don't save and restore fog state when there is no fog state

2012-08-31 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com I wonder if the better solution is to have _mesa_meta_GenerateMipmap not use MESA_META_ALL for the GLSL path. Even on compatibility profiles there is no reason to save and restore fog on this path. NOTE: This is a candidate for the 9.0 branch.

Re: [Mesa-dev] [PATCH] meta: Don't save and restore fog state when there is no fog state

2012-08-31 Thread Brian Paul
On 08/31/2012 04:31 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com I wonder if the better solution is to have _mesa_meta_GenerateMipmap not use MESA_META_ALL for the GLSL path. Even on compatibility profiles there is no reason to save and restore fog on this path. NOTE:

Re: [Mesa-dev] [PATCH] mesa: don't wait in _mesa_ClientWaitSync if timeout is 0

2012-08-31 Thread Vadim Girlin
On Fri, 2012-08-31 at 15:50 -0600, Brian Paul wrote: On 08/31/2012 02:53 PM, Eric Anholt wrote: Vadim Girlinvadimgir...@gmail.com writes: From ARB_sync spec: If the value oftimeout is zero, then ClientWaitSync does not block, but simply tests the current state ofsync.

[Mesa-dev] [PATCH] glsl: Generate compile errors for explicit blend indices 0 or 1.

2012-08-31 Thread Kenneth Graunke
According to the GLSL 4.30 specification, this is a compile time error. Earlier specifications don't specify a behavior, but since 0 and 1 are the only valid indices for dual source blending, it makes sense to generate the error. Fixes (the fixed version of) piglit's layout-12.frag. NOTE: This

Re: [Mesa-dev] [PATCH] mesa: don't wait in _mesa_ClientWaitSync if timeout is 0

2012-08-31 Thread Kenneth Graunke
On 08/31/2012 01:37 PM, Vadim Girlin wrote: From ARB_sync spec: If the value of timeout is zero, then ClientWaitSync does not block, but simply tests the current state of sync. TIMEOUT_EXPIRED will be returned in this case if sync is not signaled, even though no actual wait

Re: [Mesa-dev] [PATCH 2/4] i965: Add functions for comparing two brw_wm/vs_prog_data structs.

2012-08-31 Thread Kenneth Graunke
On 08/31/2012 03:05 PM, Eric Anholt wrote: Currently, this just avoids comparing all unused parts of param[] and pull_param[], but it's a step toward getting rid of those giant statically sized arrays. --- src/mesa/drivers/dri/i965/brw_context.h | 29 ++-

[Mesa-dev] [Bug 54326] When building 32 bit on 64 bit, build ends saying it can't find 32 bit libkms.so

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54326 --- Comment #1 from Alexandre Demers alexandre.f.dem...@gmail.com 2012-09-01 04:08:24 UTC --- Making all in gbm make[2]: Entering directory `/home/dema1701/projects/display/mesa/src/gbm' CCLD libgbm.la /usr/bin/ld: skipping incompatible

[Mesa-dev] [Bug 54326] When building 32 bit on 64 bit, build ends saying it can't find 32 bit libkms.so

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54326 --- Comment #2 from Alexandre Demers alexandre.f.dem...@gmail.com 2012-09-01 04:11:50 UTC --- Pretty sure the culprit commit is a669a5055eadae85ffa000cea19a2241d0699348: gbm: Use libkms to replace DRI cursor images Author Jakob

Re: [Mesa-dev] [PATCH 4/4] i965: Make the param pointer arrays for the VS dynamically sized.

2012-08-31 Thread Kenneth Graunke
On 08/31/2012 03:05 PM, Eric Anholt wrote: Saves 96MB of wasted memory in the l4d2 demo. v2: Rebase on compare func change, change brace style. Reviewed-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Ian Romanick ian.d.roman...@intel.com ---

[Mesa-dev] [Bug 54326] When building 32 bit on 64 bit, build ends at libgbm saying it can't find 32 bit libkms.so

2012-08-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54326 Alexandre Demers alexandre.f.dem...@gmail.com changed: What|Removed |Added Summary|When building 32 bit on 64 |When

Re: [Mesa-dev] [PATCH] i965: Don't leave dangling pointer to brw context on failure

2012-08-31 Thread Kenneth Graunke
On 08/31/2012 03:03 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Otherwise intelDestroyContext would try to dereference the pointer to freed memory. NOTE: This is a candidate for the 9.0 branch. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla:

Re: [Mesa-dev] [PATCH 2/2] mesa: utilize context version routines

2012-08-31 Thread Kenneth Graunke
I'm really ambivalent about these patches. 1. I'm not a huge fan of the name have_version...it sounds like it would return whether a driver supports a given version, not whether the current context's version is a certain value. 2. Personally I think ctx-Version = XY is clearer than

Re: [Mesa-dev] [PATCH] i965: Stop putting 8 NOPs after each prorgam.

2012-08-31 Thread Kenneth Graunke
On 08/31/2012 12:19 PM, Eric Anholt wrote: As far as I can see, the intention of the requirement that we do so is to prevent instruction prefetch from wandering out into either unmapped memory or memory with a different caching type, and hanging the chip. The kernel makes sure that the page

Re: [Mesa-dev] [PATCH 1/2] mesa: add context version routines

2012-08-31 Thread Kenneth Graunke
On 08/31/2012 11:52 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Based on the discussion July 26-27 in the thread [PATCH 1/4] mesa: Add a Version field to the context with VersionMajor*10+VersionMinor. src/mesa/main/version.h | 54

[Mesa-dev] [PATCH] i965: Don't use brw-fragment_program in the old brw_wm_pass2.c.

2012-08-31 Thread Kenneth Graunke
Reading brw-fragment_program is nonsensical in compiler code: it contains the currently active program (if any), not the one currently being compiled. Attempting to access it may either lead to crashes (null pointer dereference if no program is active) or wrong results. Not known to fix