Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Matt Turner
On Mon, Sep 3, 2012 at 12:15 PM, Matt Turner wrote: > On Mon, Sep 3, 2012 at 7:13 AM, Brian Paul wrote: >> From: Brian Paul >> >> Since free(NULL) is fine. > > I think if we want to do this, then we should do it all the way with a > Coccinelle semantic patch. > > I'll send a patch. Oh, I see yo

[Mesa-dev] [Bug 52347] mklib: Error: no object files specified for d3d1x state tracker

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52347 --- Comment #5 from Phr33d0m 2012-09-03 23:17:02 UTC --- These are some bad news I would have preferd not to hear with my morning coffee... -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving thi

Re: [Mesa-dev] [PATCH 2/4] i965: Add functions for comparing two brw_wm/vs_prog_data structs.

2012-09-03 Thread Eric Anholt
Kenneth Graunke writes: > On 08/31/2012 03:05 PM, Eric Anholt wrote: >> Currently, this just avoids comparing all unused parts of param[] and >> pull_param[], but it's a step toward getting rid of those giant statically >> sized arrays. >> --- >> src/mesa/drivers/dri/i965/brw_context.h | 2

Re: [Mesa-dev] [PATCH 2/2] mesa: utilize context version routines

2012-09-03 Thread Eric Anholt
Kenneth Graunke writes: > I'm really ambivalent about these patches. > > 1. I'm not a huge fan of the name "have_version"...it sounds like it > would return whether a driver supports a given version, not whether the > current context's version is a certain value. > > 2. Personally I think ctx->Ve

[Mesa-dev] [Bug 54431] [build errors] (.text+0x324): undefined reference to `dlopen'

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54431 --- Comment #1 from Matt Turner 2012-09-03 20:35:15 UTC --- > The errors go away if I also add --with-gallium-drivers= but I supposes it should not be needed since I already specified --disable-dri. No, the Gallium drivers can be built without D

Re: [Mesa-dev] Cherry-pick trinity support

2012-09-03 Thread Andreas Boll
2012/9/3 Alex Deucher : > On Mon, Sep 3, 2012 at 2:09 PM, Andreas Boll > wrote: >> Hi list, >> >> I've read some critical news [0] about mesa and I want to fix the issue asap. >> >> I wanted to cherry pick the following commit to the stable branch 8.0: >> >> >> commit b4082f492b4b55df4c636445e47b

Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Matt Turner
On Mon, Sep 3, 2012 at 7:13 AM, Brian Paul wrote: > From: Brian Paul > > Since free(NULL) is fine. I think if we want to do this, then we should do it all the way with a Coccinelle semantic patch. I'll send a patch. ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] Cherry-pick trinity support

2012-09-03 Thread Alex Deucher
On Mon, Sep 3, 2012 at 2:09 PM, Andreas Boll wrote: > Hi list, > > I've read some critical news [0] about mesa and I want to fix the issue asap. > > I wanted to cherry pick the following commit to the stable branch 8.0: > > > commit b4082f492b4b55df4c636445e47b97d1f1e4b5b2 > Author: Alex Deucher

Re: [Mesa-dev] [PATCH] i965: Don't leave dangling pointer to brw context on failure

2012-09-03 Thread Ian Romanick
On Fri, Aug 31, 2012 at 09:54:40PM -0700, Kenneth Graunke wrote: > On 08/31/2012 03:03 PM, Ian Romanick wrote: > > From: Ian Romanick > > > > Otherwise intelDestroyContext would try to dereference the pointer to > > freed memory. > > > > NOTE: This is a candidate for the 9.0 branch. > > > > Sig

[Mesa-dev] Cherry-pick trinity support

2012-09-03 Thread Andreas Boll
Hi list, I've read some critical news [0] about mesa and I want to fix the issue asap. I wanted to cherry pick the following commit to the stable branch 8.0: commit b4082f492b4b55df4c636445e47b97d1f1e4b5b2 Author: Alex Deucher Date: Tue Mar 20 19:43:59 2012 -0400 r600g: add support for

[Mesa-dev] [PATCH] build: Disable building of d3d1x

2012-09-03 Thread Matt Turner
It's broken and unmaintained, and I'm tired of seeing bug reports about it. --- configure.ac | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 82fe225..5ea0752 100644 --- a/configure.ac +++ b/configure.ac @@ -563,11 +563,12 @@ AC_A

Re: [Mesa-dev] [PATCH] mesa: remove SQRTF, use sqrtf. Convert INV_SQRT() to inline function.

2012-09-03 Thread Matt Turner
On Mon, Sep 3, 2012 at 7:12 AM, Brian Paul wrote: > From: Brian Paul > > We were already defining sqrtf where we don't have the C99 version. > --- I almost did the same thing recently. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists

Re: [Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Kenneth Graunke
On 09/03/2012 07:13 AM, Brian Paul wrote: > From: Brian Paul > > Since free(NULL) is fine. I vaguely recall something about free(NULL) not being OK with MSVC. I hope I'm wrong about that, though. Assuming there's no problem there, these look good! For the series: Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 3/3] mesa: add missing return statements after recording errors

2012-09-03 Thread Kenneth Graunke
On 09/03/2012 07:13 AM, Brian Paul wrote: > From: Brian Paul > > --- > src/mesa/main/eval.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/main/eval.c b/src/mesa/main/eval.c > index 7709217..487c4ce 100644 > --- a/src/mesa/main/eval.c > +++ b/src/mesa/ma

Re: [Mesa-dev] [PATCH] mesa: remove SQRTF, use sqrtf. Convert INV_SQRT() to inline function.

2012-09-03 Thread Kenneth Graunke
On 09/03/2012 07:12 AM, Brian Paul wrote: > From: Brian Paul > > We were already defining sqrtf where we don't have the C99 version. Reviewed-by: Kenneth Graunke ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/ma

[Mesa-dev] [Bug 52347] mklib: Error: no object files specified for d3d1x state tracker

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52347 --- Comment #4 from Kenneth Graunke 2012-09-03 17:12:31 UTC --- Especially since the Wine guys seemed opposed to it, if anything. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail be

[Mesa-dev] [Bug 44912] [bisected] WebGL conformance/textures/texture-mips tests fails

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44912 Michel Dänzer changed: What|Removed |Added Component|Mesa core |Other --- Comment #17 from Michel Dänzer

Re: [Mesa-dev] [PATCH 1/4] radeon/llvm: fix SelectADDR8BitOffset

2012-09-03 Thread Michel Dänzer
For the series: Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 4/4] winsys/radeon: create only one winsys for each fd

2012-09-03 Thread Christian König
Fixing problems with GLAMOR. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 38 +++-- src/gallium/winsys/radeon/drm/radeon_winsys.h |5 +++ 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/radeon/

[Mesa-dev] [PATCH 3/4] radeonsi: stop big offsets from hanging the GPU v2

2012-09-03 Thread Christian König
v2: rebased of radeon/llvm fix. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c ind

[Mesa-dev] [PATCH 2/4] radeonsi: adjust PIPE_SHADER_CAP_MAX_CONSTS

2012-09-03 Thread Christian König
So it matches what we really can do. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_pipe.c |4 ++-- src/gallium/drivers/radeonsi/radeonsi_pipe.h |3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pipe.c

[Mesa-dev] [PATCH 1/4] radeon/llvm: fix SelectADDR8BitOffset

2012-09-03 Thread Christian König
The offset is unsigned, not signed. Signed-off-by: Christian König --- src/gallium/drivers/radeon/AMDILISelDAGToDAG.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/AMDILISelDAGToDAG.cpp b/src/gallium/drivers/radeon/AMDILISelDAGToDAG.cpp inde

[Mesa-dev] [PATCH 3/3] mesa: add missing return statements after recording errors

2012-09-03 Thread Brian Paul
From: Brian Paul --- src/mesa/main/eval.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/eval.c b/src/mesa/main/eval.c index 7709217..487c4ce 100644 --- a/src/mesa/main/eval.c +++ b/src/mesa/main/eval.c @@ -384,6 +384,7 @@ map1(GLenum target, GLfloat u1,

[Mesa-dev] [PATCH 2/3] mesa: remove more null pointer checks before free() calls

2012-09-03 Thread Brian Paul
From: Brian Paul --- src/mesa/main/texcompress_fxt1.c |6 ++ src/mesa/main/texcompress_rgtc.c | 16 src/mesa/main/texcompress_s3tc.c | 12 3 files changed, 14 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/texcompress_fxt1.c b/src/mesa/main/t

[Mesa-dev] [PATCH 1/3] mesa: remove null pointer checks before free() calls

2012-09-03 Thread Brian Paul
From: Brian Paul Since free(NULL) is fine. --- src/mesa/main/eval.c | 68 + 1 files changed, 24 insertions(+), 44 deletions(-) diff --git a/src/mesa/main/eval.c b/src/mesa/main/eval.c index 0ae349f..7709217 100644 --- a/src/mesa/main/eval.c +++

Re: [Mesa-dev] [PATCH] r600g: adjust QUANT_MODE for higher precision

2012-09-03 Thread Alex Deucher
On Fri, Aug 31, 2012 at 4:57 AM, Vadim Girlin wrote: > Use 1/256 for R6xx/7xx, 1/4096 for evergreen, instead of default 1/16. > > Helps to pass some piglit tests (fbo, multisample). > > Signed-off-by: Vadim Girlin Reviewed-by: Alex Deucher > --- > src/gallium/drivers/r600/evergreen_state.c |

[Mesa-dev] [PATCH] mesa: remove SQRTF, use sqrtf. Convert INV_SQRT() to inline function.

2012-09-03 Thread Brian Paul
From: Brian Paul We were already defining sqrtf where we don't have the C99 version. --- src/mesa/main/imports.h| 22 ++ src/mesa/main/light.c |2 +- src/mesa/main/macros.h |4 ++-- src/mesa/math/m_matrix.c |2 +- src/mesa/swrast/s

Re: [Mesa-dev] [PATCH] util: Add cpuid for Solaris Studio.

2012-09-03 Thread Brian Paul
On Sat, Sep 1, 2012 at 11:41 PM, Vinson Lee wrote: > Signed-off-by: Vinson Lee > --- > src/gallium/auxiliary/util/u_cpu_detect.c |4 ++-- > src/gallium/include/pipe/p_config.h |4 > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_

[Mesa-dev] [Bug 54424] [build problem] libdricore9.0.0.so.1 => not found on classic drivers

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54424 --- Comment #3 from Fabio Pedretti 2012-09-03 11:46:29 UTC --- (In reply to comment #1) > The build log shows upstream installing it in /usr/lib/i386-linux-gnu, where > it > should be found. Looks like a downstream packaging bug. OK, thanks.

[Mesa-dev] [Bug 54431] New: [build errors] (.text+0x324): undefined reference to `dlopen'

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54431 Bug #: 54431 Summary: [build errors] (.text+0x324): undefined reference to `dlopen' Classification: Unclassified Product: Mesa Version: git Platform: Other OS/

[Mesa-dev] [Bug 54424] [build problem] libdricore9.0.0.so.1 => not found on classic drivers

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54424 --- Comment #2 from sergio.calleg...@gmail.com 2012-09-03 11:00:25 UTC --- I confirm that soft linking libdricore9.0.0.so.1 in /usr/lib/x86_64-linux-gnu fixes the issue for me. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab

[Mesa-dev] [Bug 43871] shader with uniform array/record and if clauses is not translated correctly into TGSI IR

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43871 Andreas Boll changed: What|Removed |Added AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 54369] Make fails on Debian Squeeze 644

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54369 --- Comment #2 from Michel Dänzer 2012-09-03 10:16:14 UTC --- Also, where is your /usr/lib/libxcb.a from, and (why) is there no corresponding /usr/lib/libxcb.so? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --

[Mesa-dev] [Bug 54369] Make fails on Debian Squeeze 644

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54369 --- Comment #1 from Michel Dänzer 2012-09-03 10:11:24 UTC --- (In reply to comment #1) > /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../../lib/libxcb.a(xcb_conn.o): > relocation R_X86_64_32 against `.rodata' can not be used when making a shared > ob

[Mesa-dev] [Bug 54424] [build problem] libdricore9.0.0.so.1 => not found on classic drivers

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54424 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 54402] st_glsl_to_tgsi.cpp:4006:dst_register: Assertion `index < VERT_RESULT_MAX' failed

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54402 Michel Dänzer changed: What|Removed |Added AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 54424] New: [build problem] libdricore9.0.0.so.1 => not found on classic drivers

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54424 Bug #: 54424 Summary: [build problem] libdricore9.0.0.so.1 => not found on classic drivers Classification: Unclassified Product: Mesa Version: git Platform: All

[Mesa-dev] [Bug 52347] mklib: Error: no object files specified for d3d1x state tracker

2012-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52347 --- Comment #3 from Matt Turner 2012-09-03 08:20:10 UTC --- No one is maintaining d3d1x. I think we should disable its build flag. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail be