Re: [Mesa-dev] Mesa 9.1.2? (was Re: Mesa (9.1): 21 new commits)

2013-04-05 Thread Jordan Justen
On Fri, Apr 5, 2013 at 7:03 PM, Ian Romanick wrote: > I just cherry picked (almost) all of the marked patches from master that > have been out for two weeks or more. There are a couple that I did not > pick. > With all that out of the way... how does a Mesa 9.1.2 release next Friday > sound? 43

[Mesa-dev] Mesa 9.1.2? (was Re: Mesa (9.1): 21 new commits)

2013-04-05 Thread Ian Romanick
I just cherry picked (almost) all of the marked patches from master that have been out for two weeks or more. There are a couple that I did not pick. c07c180 wayland: fix segfault when using software rendering 49c1fc7 r600g: don't emit SQ_DYN_GPR_RESOURCE_LIMIT_1 on cayman I couldn't get thes

Re: [Mesa-dev] [PATCH] intel: Allocate hiz in intel_renderbuffer_move_to_temp()

2013-04-05 Thread Paul Berry
On 5 April 2013 15:28, Chad Versace wrote: > When moving the renderbuffer to a new miptree, we neglected to allocate > the hiz buffer for the new miptree. Oops. > > Fixes all Piglit depthstencil-render-miplevels tests from crash to pass on > Sandybridge. > > CC: Paul Berry > CC: Eric Anholt > S

Re: [Mesa-dev] [PATCH] intel: Allocate hiz in intel_renderbuffer_move_to_temp()

2013-04-05 Thread Eric Anholt
Chad Versace writes: > When moving the renderbuffer to a new miptree, we neglected to allocate > the hiz buffer for the new miptree. Oops. > > Fixes all Piglit depthstencil-render-miplevels tests from crash to pass on > Sandybridge. Reviewed-by: Eric Anholt pgpq3PU8F4uF6.pgp Description: PGP

Re: [Mesa-dev] [PATCH] intel: Do temporary CPU maps of textures that are too big to GTT map.

2013-04-05 Thread Daniel Vetter
On Fri, Apr 05, 2013 at 01:17:43PM -0700, Eric Anholt wrote: > This still fails, since 8192*4bpp == 32768, which is too big to use the > blitter on. > > v2: Be more conservative about the size of the GTT -- I'd forgotten some > of the horror of older hardware. Agreed on your other comments, w

Re: [Mesa-dev] [PATCH 00/12] RFC: add support of ARB_separate_shader_object extensions

2013-04-05 Thread Ian Romanick
On 04/05/2013 02:25 PM, gregory wrote: Hello, Please find an implementation of the ARB_separate_shader_objects extensions. I concentrate mostly on the state part of the extensions aka the pipeline object. I think GLSL already compiled program separately anyway. I test my implementation on the

[Mesa-dev] [PATCH 2/2] radeonsi: add support for compressed texture

2013-04-05 Thread j . glisse
From: Jerome Glisse Most test pass, issue are with border color and swizzle. Based on ircnick patch. Signed-off-by: Jerome Glisse --- src/gallium/drivers/radeonsi/si_state.c | 165 +--- src/gallium/drivers/radeonsi/sid.h | 7 ++ 2 files changed, 96 insertion

[Mesa-dev] [PATCH 1/2] radeonsi: add 2d tiling support for texture v2

2013-04-05 Thread j . glisse
From: Jerome Glisse v2: Remove left over code Signed-off-by: Jerome Glisse --- src/gallium/drivers/radeonsi/r600_texture.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/r600_texture.c b/src/gallium/drivers/radeonsi/r600_texture.c

[Mesa-dev] radeonsi: tiling and compressed texture

2013-04-05 Thread j . glisse
Rebase on top of lastest libdrm patch. With small modification to ddx you can also have tiled front buffer rendering. But again we need to wait next mesa release before changing ddx to assume by default it is installed with a recent enough mesa. No regression, just new test that pass. Cheers, J

Re: [Mesa-dev] [PATCH] Fix glXChooseFBConfig with GLX_DRAWABLE_TYPE GLX_DONT_CARE

2013-04-05 Thread Ian Romanick
On 04/05/2013 01:51 PM, Alexander Monakov wrote: On Thu, Apr 4, 2013 at 1:02 AM, Ian Romanick wrote: Reveiwed-by: Ian Romanick Please add the following lines to the commit message: NOTE: This is a candidate for stable branches. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47478 Bu

[Mesa-dev] [PATCH 12/12] sso: Finally enable the extension on Gallium

2013-04-05 Thread gregory
Note: it probably work on others drivers. --- src/mesa/state_tracker/st_extensions.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 11db9d3..4af46f3 100644 --- a/src/mesa/state_tracker/st_extensions.c ++

[Mesa-dev] [PATCH 11/12] sso: implement ValidateProgramPipeline and GetProgramPipelineInfoLog

2013-04-05 Thread gregory
Implementation note: I don't use context for ralloc (don't know how). The check on PROGRAM_SEPARABLE flags is also done when the pipeline isn't bound. It doesn't make any sense in a DSA style API. Maybe we could replace _mesa_validate_program_pipeline by _mesa_validate_program_pipeline. For exa

[Mesa-dev] [PATCH 10/12] sso: update glGet: GL_PROGRAM_PIPELINE_BINDING

2013-04-05 Thread gregory
--- src/mesa/main/get.c |9 + src/mesa/main/get_hash_params.py |3 +++ 2 files changed, 12 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 7ce2df1..f6311a5 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -356,6 +356,7 @@ EXTRA_

[Mesa-dev] [PATCH 09/12] sso: implement BindProgramPipeline

2013-04-05 Thread gregory
Test become green in piglit: The updated ext_transform_feedback-api-errors:useprogstage_noactive useprogstage_active bind_pipeline arb_separate_shader_object-GetProgramPipelineiv arb_separate_shader_object-IsProgramPipeline For the moment I reuse Driver.UseProgram but I guess it will be better to

[Mesa-dev] [PATCH 08/12] sso:Implement _mesa_UseProgramStages

2013-04-05 Thread gregory
Implement _mesa_UseProgramStages => arb_separate_shader_object-GetProgramPipelineiv is now pass :) Extend use_shader_program to support a different target. Allow to reuse the function to update the pipeline state. Note I bypass the flush when target isn't current. Maybe it would be better to cr

[Mesa-dev] [PATCH 07/12] sso: update meta state

2013-04-05 Thread gregory
save and restore _Shader/Pipeline binding point. Rational we don't want any conflict when the program will be unattached. --- src/mesa/drivers/common/meta.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/d

[Mesa-dev] [PATCH 06/12] sso: rename Shader to the pointer _Shader

2013-04-05 Thread gregory
Basically a sed but shaderapi.c and get.c. get.c => GL_CURRENT_PROGAM always refer to the "old" UseProgram behavior shaderapi.c => the old api stil update the Shader object directly --- src/mesa/drivers/common/meta.c | 10 ++-- src/mesa/drivers/dri/i965/brw_gs.c |

[Mesa-dev] [PATCH 05/12] sso: replace Shader binding point with _Shader

2013-04-05 Thread gregory
To avoid NULL pointer check a default pipeline object is installed in _Shader when no program is current The spec say that UseProgram/UseShaderProgramEXT/ActiveProgramEXT got an higher priority over the pipeline object. When default program is uninstall, the pipeline is used if any was bound. N

[Mesa-dev] [PATCH 04/12] sso: implement ActiveShaderProgram & GetProgramPipelineiv

2013-04-05 Thread gregory
--- src/mesa/main/pipelineobj.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c index e50416c..7a56c67 100644 --- a/src/mesa/main/pipelineobj.c +++ b/src/mesa/main/pipelineobj.c @@ -233,6 +

[Mesa-dev] [PATCH 03/12] sso: add support of GL_PROGRAM_SEPARABLE and CreateShaderProgramv

2013-04-05 Thread gregory
CreateShaderProgramv is similar as CreateShaderProgramEXT. The 2 differences are 1/ it an array of strings 2/ it support the GL_PROGRAM_SEPARABLE (aka SeparateShader) flag --- src/mesa/main/mtypes.h|5 +++ src/mesa/main/shaderapi.c | 90 +++-- 2 fi

[Mesa-dev] [PATCH 02/12] sso: Add pipeline container/state

2013-04-05 Thread gregory
* Extend gl_shader_state as pipeline object state * Add a new container gl_pipeline_shader_state that contains binding point of the previous object * Update mesa init/free shader state due to the extension of the attibute * Add an init/free pipeline function for the context * Implement GenProgr

[Mesa-dev] [PATCH 01/12] sso: Create extensions entry points

2013-04-05 Thread gregory
Nothings implemented yet but glProgramUniform* which are mostly a copy/paste of the older function glUniform* I create dedicated pipelineobj.[ch] file that will contains function related to the "new" pipeline container object. --- src/mapi/glapi/gen/ARB_separate_shader_objects.xml | 392

[Mesa-dev] [PATCH 00/12] RFC: add support of ARB_separate_shader_object extensions

2013-04-05 Thread gregory
Hello, Please find an implementation of the ARB_separate_shader_objects extensions. I concentrate mostly on the state part of the extensions aka the pipeline object. I think GLSL already compiled program separately anyway. I test my implementation on the test that I send yesterday ago on pigli

[Mesa-dev] [PATCH] clover: Use a non-NULL value to represent the platform_id v3

2013-04-05 Thread Tom Stellard
From: Tom Stellard Using a NULL value for the platform_id is legal according to the spec, however, passing a NULL value as the platform parameter to clGetPlatformInfo() results in implementation defined behavior. In order to avoid implementation defined behavior some apps require that the platfr

Re: [Mesa-dev] [PATCH 2/5] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-04-05 Thread Ian Romanick
On 04/05/2013 05:29 AM, Christoph Bumiller wrote: v2: Removed some stray extern qualifiers. Documented use of Draw*IndirectCommand sizes. Removed separate extension enable flag for ARB_multi_draw_indirect since this can always be supported by looping. Kept generation of GL_INVALID_OPERATION in

[Mesa-dev] [PATCH] clover: Use a non-NULL value to represent the platform_id v2

2013-04-05 Thread Tom Stellard
From: Tom Stellard Using a NULL value for the platform_id is legal according to the spec, however, passing a NULL value as the platform parameter to clGetPlatformInfo() results in implementation defined behavior. In order to avoid implementation defined behavior some apps require that the platfr

Re: [Mesa-dev] [PATCH] Fix glXChooseFBConfig with GLX_DRAWABLE_TYPE GLX_DONT_CARE

2013-04-05 Thread Alexander Monakov
On Thu, Apr 4, 2013 at 1:02 AM, Ian Romanick wrote: > Reveiwed-by: Ian Romanick > > Please add the following lines to the commit message: > > NOTE: This is a candidate for stable branches. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=47478 > Bugzilla: https://bugs.freedesktop.org/sh

[Mesa-dev] [PATCH] clover: Use a non-NULL value to represent the platform_id

2013-04-05 Thread Tom Stellard
From: Tom Stellard Using a NULL value for the platform_id is legal according to the spec, however, passing a NULL value as the platform parameter to clGetPlatformInfo() results in implementation defined behavior. In order to avoid implementation defined behavior some apps require that the platfr

[Mesa-dev] [PATCH] intel: Do temporary CPU maps of textures that are too big to GTT map.

2013-04-05 Thread Eric Anholt
This still fails, since 8192*4bpp == 32768, which is too big to use the blitter on. v2: Be more conservative about the size of the GTT -- I'd forgotten some of the horror of older hardware. --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 23 +++ 1 file changed, 23 i

Re: [Mesa-dev] [PATCH 2/2] i965/vs: Use GRFs for pull constant offsets on gen7.

2013-04-05 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/3] R600: Emit ELF formatted code rather than raw ISA.

2013-04-05 Thread Tom Stellard
From: Tom Stellard --- lib/Target/R600/MCTargetDesc/AMDGPUAsmBackend.cpp | 29 ++-- .../R600/MCTargetDesc/AMDGPUELFObjectWriter.cpp| 39 ++ .../R600/MCTargetDesc/AMDGPUMCTargetDesc.cpp | 2 +- lib/Target/R600/MCTargetDesc/AMDGPUMCTargetDesc.h | 4 +++

[Mesa-dev] [PATCH 3/3] R600/SI: Emit config values in register value pairs.

2013-04-05 Thread Tom Stellard
From: Tom Stellard Instead of emitting config values in a predefined order, the code emitter will now emit a 32-bit register index followed by the 32-bit config value. --- lib/Target/R600/AMDGPUAsmPrinter.cpp | 19 --- lib/Target/R600/SIDefines.h | 22 +++

[Mesa-dev] [PATCH 2/3] R600/SI: Emit configuration value in the .AMDGPU.config ELF section

2013-04-05 Thread Tom Stellard
From: Tom Stellard --- lib/Target/R600/AMDGPUAsmPrinter.cpp | 10 +- test/CodeGen/R600/elf.ll | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/AMDGPUAsmPrinter.cpp b/lib/Target/R600/AMDGPUAsmPrinter.cpp index f600144..011c602 100644 ---

[Mesa-dev] [PATCH 3/4] radeonsi: Read config values from the .AMDGPU.config ELF section

2013-04-05 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c index 218997f..0aeecc2 100644 --- a/src/galliu

[Mesa-dev] [PATCH 2/4] radeon/llvm: Handle ELF formatted binary output from the LLVM backend

2013-04-05 Thread Tom Stellard
From: Tom Stellard --- configure.ac| 2 ++ src/gallium/drivers/radeon/Makefile.am | 3 +- src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 38 ++--- 3 files changed, 38 insertions(+), 5 deletions(-) diff --git a/configure.ac b/

[Mesa-dev] [PATCH 1/4] radeon/llvm: Use a struct for storing compiled code

2013-04-05 Thread Tom Stellard
From: Tom Stellard --- src/gallium/drivers/r600/r600_llvm.c| 8 +-- src/gallium/drivers/radeon/radeon_llvm_emit.cpp | 12 +- src/gallium/drivers/radeon/radeon_llvm_emit.h | 11 +++-- src/gallium/drivers/radeonsi/radeonsi_shader.c | 31 + 4

[Mesa-dev] [PATCH 4/4] radeonsi: Handle new format for configuration values emitted by the LLVM backend

2013-04-05 Thread Tom Stellard
From: Tom Stellard Instead of emitting configuration values (e.g. number of gprs used) in a predefined order, the LLVM backend now emits these values in register/value pairs. The first dword contains the register address and the second dword contians the value to write. --- src/gallium/drivers/

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Add ETC as compressed format

2013-04-05 Thread Wladimir
Hello Brian, Reviewed-by: Brian Paul > > Do you need someone to commit this for you? > Yes, I'm new here, Regards, Wladimir ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] intel: Do temporary CPU maps of textures that are too big to GTT map.

2013-04-05 Thread Eric Anholt
Daniel Vetter writes: > On Tue, Apr 02, 2013 at 06:46:32PM -0700, Eric Anholt wrote: >> This still fails, since 8192*4bpp == 32768, which is too big to use the >> blitter on. > > Meh, I should take coffee first before doing reviews ... > > Iirc on gen4+ for tiled src/dst the blt stride limit is 1

Re: [Mesa-dev] [PATCH 2/3] intel: Do temporary CPU maps of textures that are too big to GTT map.

2013-04-05 Thread Eric Anholt
Daniel Vetter writes: > On Tue, Apr 02, 2013 at 06:46:32PM -0700, Eric Anholt wrote: >> This still fails, since 8192*4bpp == 32768, which is too big to use the >> blitter on. >> >> Reviewed-by: Kenneth Graunke >> --- >> src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 21

[Mesa-dev] [Bug 56542] [bisected] Piglit gl_select tests crash on exit

2013-04-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56542 Jerome Glisse changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 63078] EGL X11 Regression: Maximum swap interval is 0 (worked with 9.0)

2013-04-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63078 Chad Versace changed: What|Removed |Added CC||chad.vers...@linux.intel.co

Re: [Mesa-dev] [PATCH] gallium/u_blitter: fix is_blit_generic_supported() stencil checking

2013-04-05 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Apr 5, 2013 at 7:27 PM, Brian Paul wrote: > Don't check if there's sampler support for stencil if we're not > going to actually blit/copy stencil values. Fixes the case where > we mistakenly said we can't support a blit of depth values from > S8Z24 to X

[Mesa-dev] [PATCH 2/2] i965/vs: Use GRFs for pull constant offsets on gen7.

2013-04-05 Thread Eric Anholt
This allows the computation of the offset to get written directly into the message source. shader-db results: total instructions in shared programs: 3308390 -> 3283025 (-0.77%) instructions in affected programs: 442998 -> 417633 (-5.73%) No difference in GLB2.7 low res (n=9). --- src/mesa/dr

[Mesa-dev] [PATCH 1/2] i965/vs: When asked to make a dst_reg for a src.xxxx, just write to src.x.

2013-04-05 Thread Eric Anholt
We have several places in our pull constant handling where we make a temporary src_reg for an int, and then turn it into a dst. In doing so, we were writing to the dst.xyzw, so we never register coalesced it with a later mov from dst.x to real_dst.x. These extra channels written would be removed

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Add ETC as compressed format

2013-04-05 Thread Brian Paul
On 04/05/2013 11:49 AM, Wladimir wrote: From 1b3d69d7749e3b82f529d2a41b80f5cd64447d92 Mon Sep 17 00:00:00 2001 From: "Wladimir J. van der Laan" mailto:laa...@gmail.com>> Date: Fri, 5 Apr 2013 18:58:32 +0200 Subject: [PATCH] gallium/auxiliary: Add ETC as compressed format Add UTIL_FORMAT_LAYOUT_

[Mesa-dev] [Bug 47607] [advocacy] Make Anomaly Warzone Earth work with Mesa

2013-04-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47607 --- Comment #11 from Jordan Justen --- I wanted to add one note. The game now works for me with Mesa 9.0.3 via Steam, but it is crashing for me with Mesa 9.1.1 after the intro movie. I'll work with the game developer on this... -- You are recei

[Mesa-dev] [PATCH] gallium/auxiliary: Add ETC as compressed format

2013-04-05 Thread Wladimir
>From 1b3d69d7749e3b82f529d2a41b80f5cd64447d92 Mon Sep 17 00:00:00 2001 From: "Wladimir J. van der Laan" Date: Fri, 5 Apr 2013 18:58:32 +0200 Subject: [PATCH] gallium/auxiliary: Add ETC as compressed format Add UTIL_FORMAT_LAYOUT_ETC to util_format_is_compressed. It was missing. Signed-off-by: W

Re: [Mesa-dev] [PATCH] gallium/u_blitter: fix is_blit_generic_supported() stencil checking

2013-04-05 Thread Brian Paul
On 04/05/2013 11:32 AM, Jose Fonseca wrote: - Original Message - Don't check if there's sampler support for stencil if we're not going to actually blit/copy stencil values. Fixes the case where we mistakenly said we can't support a blit of depth values from S8Z24 to X8Z24. Also, rena

Re: [Mesa-dev] [PATCH] gallium/u_blitter: fix is_blit_generic_supported() stencil checking

2013-04-05 Thread Jose Fonseca
- Original Message - > Don't check if there's sampler support for stencil if we're not > going to actually blit/copy stencil values. Fixes the case where > we mistakenly said we can't support a blit of depth values from > S8Z24 to X8Z24. > > Also, rename the is_stencil variable to dst_h

[Mesa-dev] [PATCH] gallium/u_blitter: fix is_blit_generic_supported() stencil checking

2013-04-05 Thread Brian Paul
Don't check if there's sampler support for stencil if we're not going to actually blit/copy stencil values. Fixes the case where we mistakenly said we can't support a blit of depth values from S8Z24 to X8Z24. Also, rename the is_stencil variable to dst_has_stencil to improve readability. NOTE: T

[Mesa-dev] [PATCH] mesa: add indirect drawing buffer parameter to draw functions v3

2013-04-05 Thread Christoph Bumiller
Split from patch implementing ARB_draw_indirect. v2: Const-qualify the struct gl_buffer_object *indirect argument. v3: Fix up some more draw calls for new argument. Sorry, it's getting a bit spammy I guess. --- src/mesa/drivers/dri/i965/brw_draw.c |3 ++- src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH] mesa/draw_indirect: fix index bounds

2013-04-05 Thread Christoph Bumiller
(Will be merged into the original patches.) Calculating the actual limits is impossible, and softpipe drops vertices that lie outside the specified range. --- src/gallium/auxiliary/util/u_draw.c |4 src/mesa/state_tracker/st_draw.c|3 +++ src/mesa/vbo/vbo_exec_array.c |

[Mesa-dev] [PATCH] st/mesa: add support for indirect drawing v2

2013-04-05 Thread Christoph Bumiller
v2: Fix for constness of indirect buffer argument. Remove separate extension enable for multi_draw_indirect. --- src/mesa/state_tracker/st_cb_bufferobjects.c |3 +++ src/mesa/state_tracker/st_cb_bufferobjects.h |6 ++ src/mesa/state_tracker/st_draw.c | 11 ++- src

[Mesa-dev] [PATCH 4/5] gallium: add facilities for indirect drawing

2013-04-05 Thread Christoph Bumiller
v2: Added comments to util_draw_indirect, clarified and fixed map size. Removed unlikely(). --- src/gallium/auxiliary/util/u_draw.c | 43 ++ src/gallium/auxiliary/util/u_draw.h |8 src/gallium/auxiliary/util/u_dump_state.c|3 ++

[Mesa-dev] [PATCH 2/5] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-04-05 Thread Christoph Bumiller
v2: Removed some stray extern qualifiers. Documented use of Draw*IndirectCommand sizes. Removed separate extension enable flag for ARB_multi_draw_indirect since this can always be supported by looping. Kept generation of GL_INVALID_OPERATION in display list compile. The spec doesn't say anything

[Mesa-dev] [PATCH 5/5] st/mesa: add support for indirect drawing

2013-04-05 Thread Christoph Bumiller
--- src/mesa/state_tracker/st_cb_bufferobjects.c |3 +++ src/mesa/state_tracker/st_draw.c | 11 ++- src/mesa/state_tracker/st_extensions.c |3 ++- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c b/src

[Mesa-dev] [PATCH 1/5] mesa: add indirect drawing buffer parameter to draw functions

2013-04-05 Thread Christoph Bumiller
Split from patch implementing ARB_draw_indirect. v2: Const-qualify the struct gl_buffer_object *indirect argument. --- src/mesa/drivers/dri/i965/brw_draw.c |3 ++- src/mesa/drivers/dri/i965/brw_draw.h |3 ++- src/mesa/drivers/dri/nouveau/nouveau_vbo_t.c |9 ++--- s

[Mesa-dev] [PATCH 3/5] gallium: add PIPE_BIND_COMMAND_ARGS_BUFFER

2013-04-05 Thread Christoph Bumiller
Intended for use with GL_ARB_draw_indirect's DRAW_INDIRECT_BUFFER target or for D3D11_RESOURCE_MISC_DRAWINDIRECT_ARGS. --- src/gallium/docs/source/screen.rst |3 +++ src/gallium/include/pipe/p_defines.h |1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/gallium/docs

Re: [Mesa-dev] [PATCH 2/4] gallium: add PIPE_BIND_COMMAND_BUFFER

2013-04-05 Thread Jose Fonseca
I don't feel strongly about it anyway. Can always change it later. Jose - Original Message - > On 04.04.2013 21:53, Christoph Bumiller wrote: > > On 04.04.2013 21:44, Jose Fonseca wrote: > >> I think that PIPE_BIND_INDIRECT_BUFFER would be more self-descriptive. > > Marek suggested PIPE_

Re: [Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-04-05 Thread Christoph Bumiller
On 05.04.2013 13:32, Christoph Bumiller wrote: > On 04.04.2013 21:17, Brian Paul wrote: >> I just did a quick skim and found a few minor things. >> >> First, the subject might be "mesa: implement GL_ARB_draw_indirect and >> GL_ARB_multi_draw_indirect" >> >> This is a big patch and I think it could

Re: [Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-04-05 Thread Christoph Bumiller
On 04.04.2013 21:17, Brian Paul wrote: > I just did a quick skim and found a few minor things. > > First, the subject might be "mesa: implement GL_ARB_draw_indirect and > GL_ARB_multi_draw_indirect" > > This is a big patch and I think it could have been broken down into > smaller pieces, but I know

Re: [Mesa-dev] [PATCH] gallivm: fix breakc

2013-04-05 Thread Jose Fonseca
- Original Message - > we break when the mask values are 0 not, 1, plus it's bit comparison > not a floating point comparison. This fixes both. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 26 > --- > 1 file changed, 14 in

Re: [Mesa-dev] [PATCH 2/4] gallium: add PIPE_BIND_COMMAND_BUFFER

2013-04-05 Thread Christoph Bumiller
On 04.04.2013 21:53, Christoph Bumiller wrote: > On 04.04.2013 21:44, Jose Fonseca wrote: >> I think that PIPE_BIND_INDIRECT_BUFFER would be more self-descriptive. Marek suggested PIPE_BIND_DRAW_INDIRECT_BUFFER, but I think that's too specific because there's also a DISPATCH_INDIRECT buffer for co