[Mesa-dev] [PATCH] radeonsi: cleanup disabling tiling for UVD v2

2013-04-24 Thread Christian König
From: Christian König Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=63702 v2: add a comment that this is just a workaround Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_uvd.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sr

Re: [Mesa-dev] [PATCH] radeonsi: cleanup disabling tiling for UVD v2

2013-04-24 Thread Michel Dänzer
On Mit, 2013-04-24 at 10:09 +0200, Christian König wrote: > From: Christian König > > Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=63702 > > v2: add a comment that this is just a workaround > > Signed-off-by: Christian König > --- > src/gallium/drivers/radeonsi/radeonsi_uvd.c |

[Mesa-dev] [PATCH] winsys/sw/xlib: Prevent shared memory segment leakage.

2013-04-24 Thread jfonseca
From: José Fonseca Running piglit with was causing all sort of weird stuff happening to my desktop (Chromium webpages become blank, Qt Creator flickered, etc). I tracked this down to shared memory segment leakage when GL is not shutdown properly. The segments can be seen running `ipcs` and looki

Re: [Mesa-dev] [PATCH] winsys/sw/xlib: Prevent shared memory segment leakage.

2013-04-24 Thread Chris Wilson
On Wed, Apr 24, 2013 at 10:23:38AM +0100, jfons...@vmware.com wrote: > From: José Fonseca > > Running piglit with was causing all sort of weird stuff happening to my > desktop (Chromium webpages become blank, Qt Creator flickered, etc). I > tracked this down to shared memory segment leakage when

Re: [Mesa-dev] [PATCH] winsys/sw/xlib: Prevent shared memory segment leakage.

2013-04-24 Thread Jose Fonseca
- Original Message - > On Wed, Apr 24, 2013 at 10:23:38AM +0100, jfons...@vmware.com wrote: > > From: José Fonseca > > > > Running piglit with was causing all sort of weird stuff happening to my > > desktop (Chromium webpages become blank, Qt Creator flickered, etc). I > > tracked this d

Re: [Mesa-dev] [PATCH] winsys/sw/xlib: Prevent shared memory segment leakage.

2013-04-24 Thread Ian Romanick
On 04/24/2013 11:23 AM, jfons...@vmware.com wrote: From: José Fonseca Running piglit with was causing all sort of weird stuff happening to my desktop (Chromium webpages become blank, Qt Creator flickered, etc). I tracked this down to shared memory segment leakage when GL is not shutdown proper

[Mesa-dev] [PATCH] winsys/sw/xlib: Prevent shared memory segment leakage.

2013-04-24 Thread jfonseca
From: José Fonseca Running piglit with this was causing all sort of weird stuff happening to my desktop (Chromium webpages become blank, Qt Creator flickered, etc). I tracked this down to shared memory segment leakage when GL is not shutdown properly. The segments can be seen running `ipcs` and

[Mesa-dev] [PATCH] [r200] fix building regression introduces with 9a32203e1618486e87c7baf494134e05f0e38cf3

2013-04-24 Thread Laurent Carlier
Signed-off-by: Laurent Carlier --- src/mesa/drivers/dri/r200/r200_vertprog.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/r200/r200_vertprog.c b/src/mesa/drivers/dri/r200/r200_vertprog.c index ee867c2..461b7cb 100644 --- a/src/mesa/drivers/dri/r200/r200_vertprog.c +++

Re: [Mesa-dev] [PATCH 3/5] r600g: Add evergreen_emit_cs_constant_buffers()

2013-04-24 Thread Marek Olšák
You should also bump R600_NUM_ATOMS whenever you add a new atom with r600_init_atom. BTW, what does LS stand for? Marek On Tue, Apr 23, 2013 at 5:24 AM, Tom Stellard wrote: > From: Tom Stellard > > --- > src/gallium/drivers/r600/evergreen_state.c | 34 > +- > src/g

Re: [Mesa-dev] [PATCH 4/5] r600g/compute: Use a constant buffer to store kernel parameters

2013-04-24 Thread Marek Olšák
On Tue, Apr 23, 2013 at 5:24 AM, Tom Stellard wrote: > From: Tom Stellard > > --- > src/gallium/drivers/r600/evergreen_compute.c | 47 > +++--- > .../drivers/r600/evergreen_compute_internal.h | 2 +- > 2 files changed, 33 insertions(+), 16 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 3/5] r600g: Add evergreen_emit_cs_constant_buffers()

2013-04-24 Thread Alex Deucher
On Wed, Apr 24, 2013 at 7:38 AM, Marek Olšák wrote: > You should also bump R600_NUM_ATOMS whenever you add a new atom with > r600_init_atom. BTW, what does LS stand for? LS = Local Shader It's part of the hw pipeline for DX11/GL4 LS and CS (compute shader) resource are shared on evergreen asics.

Re: [Mesa-dev] [PATCH] mesa: Allow custom text to be inserted in version string at buildtime

2013-04-24 Thread Paul Berry
On 23 April 2013 21:22, Chad Versace wrote: > On 04/23/2013 09:19 PM, Eric Anholt wrote: > >> Chad Versace writes: >> >> On 04/23/2013 06:19 AM, Ian Romanick wrote: >>> On 04/23/2013 03:28 AM, Chad Versace wrote: > This allows maintainers/packagers/testers to tag the build with >>

Re: [Mesa-dev] [PATCH] winsys/sw/xlib: Prevent shared memory segment leakage.

2013-04-24 Thread Brian Paul
On 04/24/2013 03:54 AM, jfons...@vmware.com wrote: From: José Fonseca Running piglit with this was causing all sort of weird stuff happening to my desktop (Chromium webpages become blank, Qt Creator flickered, etc). I tracked this down to shared memory segment leakage when GL is not shutdown pr

Re: [Mesa-dev] [PATCH] mesa: Allow custom text to be inserted in version string at buildtime

2013-04-24 Thread Ian Romanick
On 04/24/2013 04:11 PM, Paul Berry wrote: On 23 April 2013 21:22, Chad Versace mailto:chad.vers...@linux.intel.com>> wrote: On 04/23/2013 09:19 PM, Eric Anholt wrote: Chad Versace mailto:chad.vers...@linux.intel.com>> writes: On 04/23/2013 06:19 AM, Ian Romanick wrote:

Re: [Mesa-dev] [PATCH] i965: Avoid recompiles for fragment clamping on non-clamping APIs.

2013-04-24 Thread Marek Olšák
Not only was the fragment and vertex color clamping deprecated, it was also *removed* from the core API, but if you expose ARB_color_buffer_float, you add all the removed functionality back. If you want to avoid recompiles entirely, set: ctx->Extensions.ARB_color_buffer_float = ctx->API == API_OP

Re: [Mesa-dev] [PATCH] [r200] fix building regression introduces with 9a32203e1618486e87c7baf494134e05f0e38cf3

2013-04-24 Thread Marek Olšák
Pushed, thanks. Marek On Wed, Apr 24, 2013 at 12:47 PM, Laurent Carlier wrote: > Signed-off-by: Laurent Carlier > --- > src/mesa/drivers/dri/r200/r200_vertprog.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/r200/r200_vertprog.c > b/src/mesa/drivers/dri/r200/r20

Re: [Mesa-dev] [PATCH] vbo: fix possible use-after-free segfault after a VAO is deleted

2013-04-24 Thread Brian Paul
On 04/23/2013 06:21 PM, Marek Olšák wrote: This like the fifth attempt to fix the issue. Also with the new "validating" flag, we can set recalculate_inputs to FALSE earlier in vbo_bind_arrays, because _mesa_update_state won't change it. NOTE: This is a candidate for the stable branches. --- s

Re: [Mesa-dev] [PATCH] mesa/st: Don't copy propagate from swizzles.

2013-04-24 Thread Brian Paul
On 04/20/2013 11:40 AM, Fabian Bieler wrote: Do not propagate a copy if source and destination are identical. Otherwise code like MOV TEMP[0].xyzw, TEMP[0].wzyx mov TEMP[1].xyzw, TEMP[0].xyzw is changed to MOV TEMP[0].xyzw, TEMP[0].wzyx mov TEMP[1].xyzw, TEMP[0].wzyx --- src/mesa/state_trac

Re: [Mesa-dev] [PATCH] mesa: Allow custom text to be inserted in version string at buildtime

2013-04-24 Thread Eric Anholt
Chad Versace writes: > On 04/23/2013 09:19 PM, Eric Anholt wrote: >> Chad Versace writes: >> >>> On 04/23/2013 06:19 AM, Ian Romanick wrote: On 04/23/2013 03:28 AM, Chad Versace wrote: > This allows maintainers/packagers/testers to tag the build with > information that will be repor

Re: [Mesa-dev] [PATCH] mesa/st: Don't copy propagate from swizzles.

2013-04-24 Thread Fabian Bieler
On 2013-04-24 17:54, Brian Paul wrote: > On 04/20/2013 11:40 AM, Fabian Bieler wrote: >> Do not propagate a copy if source and destination are identical. >> >> Otherwise code like >> >> MOV TEMP[0].xyzw, TEMP[0].wzyx >> mov TEMP[1].xyzw, TEMP[0].xyzw >> >> is changed to >> >> MOV TEMP[0].xyzw, TEMP

[Mesa-dev] [PATCH] r600g: use CP DMA for buffer clears on evergreen+

2013-04-24 Thread alexdeucher
From: Alex Deucher Lighter weight then using streamout. Only evergreen and newer asics support embedded data as src with CP DMA. Signed-off-by: Alex Deucher --- src/gallium/drivers/r600/evergreen_hw_context.c | 66 +++ src/gallium/drivers/r600/evergreend.h |

[Mesa-dev] [PATCH 1/2] winsys/radeon: consolidate tracing into winsys v2

2013-04-24 Thread j . glisse
From: Jerome Glisse This move the tracing timeout and printing into winsys and add an debug environement variable for it (R600_DEBUG=trace_cs). Lot of file touched because of winsys API changes. v2: Do not write lockup file if ib uniq id does not match last one Signed-off-by: Jerome Glisse --

Re: [Mesa-dev] [PATCH] r600g: use CP DMA for buffer clears on evergreen+

2013-04-24 Thread Jerome Glisse
On Wed, Apr 24, 2013 at 3:15 PM, wrote: > From: Alex Deucher > > Lighter weight then using streamout. Only evergreen > and newer asics support embedded data as src with > CP DMA. > > Signed-off-by: Alex Deucher Reviewed-by: Jerome Glisse > --- > src/gallium/drivers/r600/evergreen_hw_contex

Re: [Mesa-dev] [PATCH] radeon/llvm: Use LLVM C API for compiling LLVM IR to ISA.

2013-04-24 Thread Mathias Fröhlich
Hi Tom, On Tuesday, April 23, 2013 20:47:24 Tom Stellard wrote: > First of all, thanks for investigating this. The information you've > provided has helped me a lot. Good to hear that it helps. > I took a shot at implementing it this way with private static copies of > llvm. I've pushed the in

Re: [Mesa-dev] [PATCH 04/16] glsl: Add support for new bit built-ins in ARB_gpu_shader5.

2013-04-24 Thread Matt Turner
On Mon, Apr 22, 2013 at 6:33 PM, Chris Forbes wrote: > In the last hunk: > > + case ir_binop_bfm: > + case ir_triop_bfi: > > These look like leftovers? > > -- Chris Yes, good call. I've moved them to later in the series where they're actually added (glsl: Add a pass to lower bitfield-insert i

Re: [Mesa-dev] [PATCH 06/16] glsl: Add a pass to lower bitfield-insert into bfm+bfi.

2013-04-24 Thread Matt Turner
On Tue, Apr 23, 2013 at 2:23 AM, Chris Forbes wrote: > + /* Save op0 */ > + ir_variable *temp = new(ir) ir_variable(ir->operands[0]-> > type, "bfi_base", > + ir_var_temporary); > + this->base_ir->insert_before(temp); > + this->base_ir->insert_befor

[Mesa-dev] [PATCH 1/3] scons: Remove redundant code.

2013-04-24 Thread jfonseca
From: José Fonseca -fvisibility=hidden is already elsewhere for the whole tree. --- src/gallium/drivers/svga/SConscript |3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/svga/SConscript b/src/gallium/drivers/svga/SConscript index 8ffeed5..94c35ed 100644 --- a/src/gall

[Mesa-dev] [PATCH 2/3] util/u_sse: Fix _mm_shuffle_epi8 prototype for clang.

2013-04-24 Thread jfonseca
From: José Fonseca Clang does not support __artificial__. Instead match precisely what's in the clang headers. --- src/gallium/auxiliary/util/u_sse.h |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_sse.h b/src/gallium/auxiliary/util/u_ss

[Mesa-dev] [PATCH 3/3] scons: Support clang.

2013-04-24 Thread jfonseca
From: José Fonseca clang is supports most gcc options / extensions, with a some exceptions. The biggest advantage of using clang is that compilation times are much short. One can tell scons to use clang when building by invoking it as CC=clang CXX=clang++ scons libgl-xlib --- scons/gallium

Re: [Mesa-dev] [PATCH] radeon/llvm: Use LLVM C API for compiling LLVM IR to ISA.

2013-04-24 Thread Tom Stellard
On Wed, Apr 24, 2013 at 09:40:44PM +0200, Mathias Fröhlich wrote: > > Hi Tom, > > On Tuesday, April 23, 2013 20:47:24 Tom Stellard wrote: > > First of all, thanks for investigating this. The information you've > > provided has helped me a lot. > Good to hear that it helps. > > > I took a shot a

Re: [Mesa-dev] [PATCH] r600g: use CP DMA for buffer clears on evergreen+

2013-04-24 Thread Marek Olšák
Reviewed-by: Marek Olšák I assume you have tested this (e.g. with the test code at the end of r600_pipe.c). Marek On Wed, Apr 24, 2013 at 9:15 PM, wrote: > From: Alex Deucher > > Lighter weight then using streamout. Only evergreen > and newer asics support embedded data as src with > CP DMA

Re: [Mesa-dev] [PATCH] r600g: use CP DMA for buffer clears on evergreen+

2013-04-24 Thread Alex Deucher
On Wed, Apr 24, 2013 at 6:52 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > I assume you have tested this (e.g. with the test code at the end of > r600_pipe.c). No piglit regressions and the test in r600_pipe.c passes. Alex > > Marek > > On Wed, Apr 24, 2013 at 9:15 PM, wrote: >> From

Re: [Mesa-dev] [PATCH] mesa/st: Don't copy propagate from swizzles.

2013-04-24 Thread Bryan Cain
On 04/20/2013 12:40 PM, Fabian Bieler wrote: > Do not propagate a copy if source and destination are identical. > > Otherwise code like > > MOV TEMP[0].xyzw, TEMP[0].wzyx > mov TEMP[1].xyzw, TEMP[0].xyzw > > is changed to > > MOV TEMP[0].xyzw, TEMP[0].wzyx > mov TEMP[1].xyzw, TEMP[0].wzyx > --- >

[Mesa-dev] [PATCH 01/14] mesa: fix save_ShadeModel() logic and add new comments

2013-04-24 Thread Brian Paul
This removes the test for _mesa_inside_dlist_begin_end(). If ctx->Driver.CurrentSavePrimitive==PRIM_UNKNOWN (the initial value), _mesa_inside_dlist_begin_end() will, confusingly, return TRUE. So we didn't set the ctx->ListState.Current.ShadeModel value and it remained in its indeterminate state. T

[Mesa-dev] [PATCH 02/14] mesa: adjust PRIM_x constants for geometry shaders

2013-04-24 Thread Brian Paul
These values pertain to display lists, and the new types of geometry shader primitives can be used in display lists. And add new PRIM_MAX constant for follow-on changes. --- src/mesa/main/mtypes.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/mtypes.

[Mesa-dev] [PATCH 03/14] mesa: fix CurrentSavePrimitive <= GL_POLYGON tests

2013-04-24 Thread Brian Paul
Use the new PRIM_MAX value instead so that new geometry shader primitive types are accounted for. --- src/mesa/main/dlist.c |4 ++-- src/mesa/vbo/vbo_save_api.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 3

[Mesa-dev] [PATCH 04/14] mesa: refactor _mesa_valid_prim_mode()

2013-04-24 Thread Brian Paul
...in terms of new _mesa_is_valid_prim_mode(). We need a mode validater function that doesn't depend on current state for the display list code. --- src/mesa/main/api_validate.c | 31 +++ src/mesa/main/api_validate.h |3 +++ 2 files changed, 22 insertions(+), 12

[Mesa-dev] [PATCH 05/14] mesa: simplify save_Begin() error checking

2013-04-24 Thread Brian Paul
The old code was hard to understand and not entirely correct. Note that PRIM_INSIDE_UNKNOWN_PRIM is no longer set anywhere so we'll be able to remove that next. --- src/mesa/main/dlist.c | 33 + 1 files changed, 13 insertions(+), 20 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 06/14] mesa: remove unused PRIM_INSIDE_UNKNOWN_PRIM constant

2013-04-24 Thread Brian Paul
--- src/mapi/glapi/gen/gl_enums.py |1 - src/mesa/main/dd.h |7 +++ src/mesa/main/dlist.c |6 ++ src/mesa/main/mtypes.h |3 +-- src/mesa/vbo/vbo_save_api.c|3 +-- 5 files changed, 7 insertions(+), 13 deletions(-) diff --git a/src/mapi/g

[Mesa-dev] [PATCH 07/14] mesa: add missing error check in _mesa_EndList()

2013-04-24 Thread Brian Paul
If we're in GL_COMPILE_AND_EXECUTE mode and inside glBegin, calling glEndList() should generate an error. Fixes a failure in piglit's gl-1.0-beginend-coverage test. --- src/mesa/main/dlist.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/

[Mesa-dev] [PATCH 08/14] vbo: fix parameter validation for saving dlist glDraw* functions

2013-04-24 Thread Brian Paul
The _save_OBE_DrawArrays/Elements/RangeElements() functions are called when building a display list and we know we're outside glBegin/End. We shouldn't call the normal _mesa_validate_DrawArrays/Elements() functions here because those functions only work properly in immediate mode or during dlist e

[Mesa-dev] [PATCH 09/14] mesa: don't install glDraw* functions into the BeginEnd dispatch table

2013-04-24 Thread Brian Paul
Functions like glDrawArrays, glDrawElements, etc. are illegal between glBegin/glEnd and should generate GL_INVALID_OPERATION. Fixes several piglit gl-1.0-beginend-coverage failures. --- src/mesa/main/vtxfmt.c | 73 --- 1 files changed, 43 insertions(+

[Mesa-dev] [PATCH 10/14] vbo: remove redundant vfmt->Begin = _save_Begin assignment

2013-04-24 Thread Brian Paul
The same assignment appears later in the function. --- src/mesa/vbo/vbo_save_api.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index 1b080f4..a47ee7b 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/v

[Mesa-dev] [PATCH 11/14] mesa: comments, formatting fixes in dlist code

2013-04-24 Thread Brian Paul
--- src/mesa/main/dlist.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 882163e..73d35fe 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -1354,7 +1354,14 @@ save_DrawElementsInstancedBaseV

[Mesa-dev] [PATCH 12/14] vbo: fix error detection in vbo_save_playback_vertex_list()

2013-04-24 Thread Brian Paul
The old code didn't make sense. The clause in question did the same thing as the next else-if clause. If we're already executing a glBegin/End pair and we're starting a new primitive, that's an error. Fixes more failures in piglit gl-1.0-beginend-coverage test. --- src/mesa/vbo/vbo_save_draw.c

[Mesa-dev] [PATCH 13/14] vbo: fix initial value of ctx->Driver.CurrentSavePrimitive

2013-04-24 Thread Brian Paul
This is set during context creation/initialization. We know we're not inside glBegin/glEnd at this point so use PRIM_OUTSIDE_BEGIN_END. --- src/mesa/vbo/vbo_save.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/vbo/vbo_save.c b/src/mesa/vbo/vbo_save.c index 1b4

[Mesa-dev] [PATCH 14/14] mesa: add names of geometry shader prims in gl_enums.py

2013-04-24 Thread Brian Paul
--- src/mapi/glapi/gen/gl_enums.py |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py index 497..806d384 100644 --- a/src/mapi/glapi/gen/gl_enums.py +++ b/src/mapi/glapi/gen/gl_enums.py @@ -114,7 +114,7

Re: [Mesa-dev] [PATCH] radeon/llvm: Use LLVM C API for compiling LLVM IR to ISA.

2013-04-24 Thread Jose Fonseca
- Original Message - > On Wed, Apr 24, 2013 at 09:40:44PM +0200, Mathias Fröhlich wrote: > > > > Hi Tom, > > > > On Tuesday, April 23, 2013 20:47:24 Tom Stellard wrote: > > > First of all, thanks for investigating this. The information you've > > > provided has helped me a lot. > > Good

Re: [Mesa-dev] [PATCH] radeon/llvm: Use LLVM C API for compiling LLVM IR to ISA.

2013-04-24 Thread Mathias Fröhlich
Hi, On Wednesday, April 24, 2013 14:15:06 Tom Stellard wrote: > I've thought about this some more, and I think that the best solution > might be to move all LLVM API calls into gallivm and build it as a > shared object with it's own private copy of LLVM statically linked. This > way we would sti

Re: [Mesa-dev] [PATCH] radeon/llvm: Use LLVM C API for compiling LLVM IR to ISA.

2013-04-24 Thread Mathias Fröhlich
Hi, On Wednesday, April 24, 2013 21:54:02 Jose Fonseca wrote: > I don't see how this would work -- llvmpipe/draw has LLVMBuildXxxx calls > too. So to prevent symbol collision with apps that use them, we'd need to > expose all LLVM calls we need under nome unique prefix. > > Also note that galli

Re: [Mesa-dev] [PATCH 04/14] mesa: refactor _mesa_valid_prim_mode()

2013-04-24 Thread Ian Romanick
On 04/25/2013 02:32 AM, Brian Paul wrote: ...in terms of new _mesa_is_valid_prim_mode(). We need a mode validater function that doesn't depend on current state for the display list code. --- src/mesa/main/api_validate.c | 31 +++ src/mesa/main/api_validate.h |

Re: [Mesa-dev] [PATCH 07/14] mesa: add missing error check in _mesa_EndList()

2013-04-24 Thread Ian Romanick
On 04/25/2013 02:32 AM, Brian Paul wrote: If we're in GL_COMPILE_AND_EXECUTE mode and inside glBegin, calling glEndList() should generate an error. I wasn't aware that was an error. Is there some spec language that could be quoted in the code for that? Fixes a failure in piglit's gl-1.0-be