Re: [Mesa-dev] [v2 09/10] egl: dri2: support for creating images out of dma buffers

2013-04-29 Thread Pohjolainen, Topi
On Mon, Apr 29, 2013 at 11:48:28PM +0200, Daniel Vetter wrote: > On Mon, Apr 29, 2013 at 02:08:03PM +0300, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > Shouldn't we close the imported dma_buf fds somewhere after the call to > createImageFromFds? Or have I missed something? You

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Jose Fonseca
- Original Message - > Technically it's legal for geometry shader to not emit any > vertices. It's silly, but perfectly legal, so lets make draw > stop crashing if it happens. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c |9 >

Re: [Mesa-dev] [PATCH] u_upload_mgr: use unsync flag on both buffer mappings for consistency

2013-04-29 Thread Jose Fonseca
- Original Message - > From: Dave Airlie > > Not sure if this makes a difference or not, but either its inconsistent > for some undocumented reason or its just a bug. PIPE_TRANSFER_UNSYNCHRONIZED only makes sense when one maps for the 2nd time (or after). It really makes no sense to s

Re: [Mesa-dev] [PATCH] intel: Be more conservative in disabling tiling to save memory.

2013-04-29 Thread Kenneth Graunke
On 04/29/2013 10:24 AM, Eric Anholt wrote: Daniel Vetter writes: On Thu, Apr 25, 2013 at 03:41:01PM -0700, Eric Anholt wrote: Improves GLB2.7 trex performance 1.01985% +/- 0.721366% on my IVB (n=10) and by 3.38771% +/- 0.584241% (n=15) on my HSW, due to a 32x32 ARGB cubemap going from unt

Re: [Mesa-dev] [PATCH 2/2] i965/vs: Add instruction scheduling.

2013-04-29 Thread Kenneth Graunke
On 04/29/2013 06:20 PM, Eric Anholt wrote: Kenneth Graunke writes: On 04/23/2013 04:56 PM, Eric Anholt wrote: While this doesn't have the detail that the FS scheduler does, and is ignorant of dependency control, it's still good for a 0.60% +/- 0.15% performance improvement on GLBenchmark 2.7

Re: [Mesa-dev] R600 Patchset: Optimizations for bfgminer

2013-04-29 Thread Aaron Watry
Hi Tom, I'm not too qualified to review the llvm code changes, but the changes looked sane. I did want to point out a few piglit changes/regressions as a result of this set of patches. For my HD6850, running latest llvm from git: gegl-rgb-gamma-u8-to-ragabaf: pass -> fail v3i32-stack: pass -> fai

[Mesa-dev] [PATCH] u_upload_mgr: use unsync flag on both buffer mappings for consistency

2013-04-29 Thread Dave Airlie
From: Dave Airlie Not sure if this makes a difference or not, but either its inconsistent for some undocumented reason or its just a bug. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/util/u_upload_mgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/a

Re: [Mesa-dev] [PATCH 2/2] i965/vs: Add instruction scheduling.

2013-04-29 Thread Eric Anholt
Kenneth Graunke writes: > On 04/23/2013 04:56 PM, Eric Anholt wrote: >> While this doesn't have the detail that the FS scheduler does, and is >> ignorant of dependency control, it's still good for a 0.60% +/- 0.15% >> performance improvement on GLBenchmark 2.7 (n=45/47, outliers removed) >> --- >

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Roland Scheidegger
Am 27.04.2013 14:57, schrieb Zack Rusin: > Technically it's legal for geometry shader to not emit any > vertices. It's silly, but perfectly legal, so lets make draw > stop crashing if it happens. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c

[Mesa-dev] [PATCH 3/3] Gallium: Use mmap on Haiku for executable memory vs malloc

2013-04-29 Thread Alexander von Gluck IV
* Haiku now has DEP enabled by default. --- src/gallium/auxiliary/rtasm/rtasm_execmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/rtasm/rtasm_execmem.c b/src/gallium/auxiliary/rtasm/rtasm_execmem.c index fbdb974..8f7cc20 100644 --- a/src/gallium/aux

[Mesa-dev] [PATCH 2/3] Mapi: Use mmap on Haiku for executable memory vs malloc

2013-04-29 Thread Alexander von Gluck IV
* Haiku now has DEP enabled by default. --- src/mapi/u_execmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/u_execmem.c b/src/mapi/u_execmem.c index f268028..b6751ed 100644 --- a/src/mapi/u_execmem.c +++ b/src/mapi/u_execmem.c @@ -47,7 +47,7 @@ static unsigned int

[Mesa-dev] [PATCH 1/3] Mesa: Use mmap on Haiku for executable memory vs malloc

2013-04-29 Thread Alexander von Gluck IV
* Haiku now has DEP enabled by default. --- src/mesa/main/execmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/execmem.c b/src/mesa/main/execmem.c index bb9c70a..5f31966 100644 --- a/src/mesa/main/execmem.c +++ b/src/mesa/main/execmem.c @@ -37,7 +37,7 @@

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Chris Forbes
It's only silly if the GS *never* emits any verts... On Sun, Apr 28, 2013 at 12:57 AM, Zack Rusin wrote: > Technically it's legal for geometry shader to not emit any > vertices. It's silly, but perfectly legal, so lets make draw > stop crashing if it happens. > > Signed-off-by: Zack Rusin > ---

[Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Zack Rusin
Technically it's legal for geometry shader to not emit any vertices. It's silly, but perfectly legal, so lets make draw stop crashing if it happens. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c |9 + .../auxiliary/draw/draw_pt_fetch_shad

Re: [Mesa-dev] [v2 09/10] egl: dri2: support for creating images out of dma buffers

2013-04-29 Thread Daniel Vetter
On Mon, Apr 29, 2013 at 02:08:03PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen Shouldn't we close the imported dma_buf fds somewhere after the call to createImageFromFds? Or have I missed something? The wayland platform code seems to do that in create_wl_buffer. -Daniel > -

Re: [Mesa-dev] [PATCH 01/12] glsl: Add ir_binop_vector_extract

2013-04-29 Thread Ian Romanick
On 04/27/2013 08:43 AM, Kenneth Graunke wrote: On 04/08/2013 03:24 PM, Ian Romanick wrote: From: Ian Romanick The new opcode is used to get a single field from a vector. The field index may not be constant. This will eventually replace ir_dereference_array of vectors. This is similar to the

[Mesa-dev] R600 Patchset: Optimizations for bfgminer

2013-04-29 Thread Tom Stellard
Hi, The attached patchset implements a few optimizations for the bfgminer bitcoin mining program. Please Review. -Tom >From 661e832408a8bafc03a7c4c600c4a140b03054b4 Mon Sep 17 00:00:00 2001 From: Dmitry Cherkassov Date: Thu, 7 Mar 2013 20:17:59 +0400 Subject: [PATCH 1/3] R600: Add 64-bit load/s

[Mesa-dev] [PATCH] r600g/llvm: Update radeon family mappings for LLVM backend

2013-04-29 Thread Tom Stellard
From: Tom Stellard New processors were added to the backend to distinguish between GPUs with and without vtx caches. --- src/gallium/drivers/r600/r600_pipe.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers

[Mesa-dev] [PATCH 2/2] R600: Clean up comments in Processors.td

2013-04-29 Thread Tom Stellard
From: Tom Stellard --- lib/Target/R600/Processors.td | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/Target/R600/Processors.td b/lib/Target/R600/Processors.td index c2cc63a..730335d 100644 --- a/lib/Target/R600/Processors.td +++ b/lib/Target/R600/Processors.td @@ -1,

[Mesa-dev] [PATCH 1/2] R600: Add some new processor variants

2013-04-29 Thread Tom Stellard
From: Tom Stellard --- lib/Target/R600/AMDILDeviceInfo.cpp | 2 +- lib/Target/R600/Processors.td | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/AMDILDeviceInfo.cpp b/lib/Target/R600/AMDILDeviceInfo.cpp index 19792b7..1787959 100644 --- a/lib/Target/R

Re: [Mesa-dev] [PATCH 06/14] glsl: Add a pass to lower bitfield-insert into bfm+bfi.

2013-04-29 Thread Eric Anholt
Matt Turner writes: > i965/Gen7+ and Radeon/Evergreen+ have bfm/bfi instructions to implement > bitfieldInsert() from ARB_gpu_shader5. > > v2: Add ir_binop_bfm and ir_triop_bfi to st_glsl_to_tgsi.cpp. > Remove spurious temporary assignment and dereference. > +void > +lower_instructions_visi

Re: [Mesa-dev] [PATCH] intel: Be more conservative in disabling tiling to save memory.

2013-04-29 Thread Eric Anholt
Daniel Vetter writes: > On Thu, Apr 25, 2013 at 03:41:01PM -0700, Eric Anholt wrote: >> Improves GLB2.7 trex performance 1.01985% +/- 0.721366% on my IVB (n=10) >> and by 3.38771% +/- 0.584241% (n=15) on my HSW, due to a 32x32 ARGB >> cubemap going from untiled to tiled. >> --- >> src/mesa/d

Re: [Mesa-dev] visual leak?

2013-04-29 Thread Andy Skinner
Thanks. I realized today that newer Mesa registers the display with that callback for choosing FBConfig, but our older version only does it for Visual. So it isn't getting freed when we close the display. Do you think the register_with_display() call can be put into Fake_glXChooseFBConfig() o

Re: [Mesa-dev] [PATCH] mesa: fix the compressed TexSubImage size checking code

2013-04-29 Thread Eric Anholt
Brian Paul writes: > Before, we'd incorrectly generate an error if we we tried to > replace a non-4x4 block near the edge of a NPOT compressed texture. > For example, if the dest image was 15 texels wide and xoffset=12 > and width=3 we'd incorrectly generate GL_INVALID_OPERATION. > > Verified wit

Re: [Mesa-dev] [PATCH v2] egl/wayland: Implement EGL_EXT_swap_buffers_with_damage

2013-04-29 Thread Kristian Høgsberg
On Thu, Apr 25, 2013 at 6:18 PM, Robert Bragg wrote: > I've updated this patch to handle the case where 0 rectangles have been given > and updated the eglSwapBuffers shim to rely on that. Thanks to Eric for > noticing this. The entire series looks good to me: Reviewed-by: Kristian Høgsberg > -

Re: [Mesa-dev] [PATCH] i965: Move is_math/is_tex/is_control_flow() to backend_instruction.

2013-04-29 Thread Eric Anholt
Kenneth Graunke writes: > These are entirely based on the opcode, which is available in > backend_instruction. It makes sense to only implement them in one > place. > > This changes the VS implementation of is_tex() slightly, which now > accepts FS_OPCODE_TXB and SHADER_OPCODE_LOD. However, sin

Re: [Mesa-dev] [PATCH mesa] wayland: Disable prime support on buggy kernels

2013-04-29 Thread Kristian Høgsberg
On Tue, Apr 23, 2013 at 9:54 AM, Ander Conselvan de Oliveira wrote: > Linux kernel 3.8 shipped with a bug in the prime fd passing code that > makes it unreliable. As of this writing, it seems unlikely that 3.9 > will contain the fix for the issue. > > This patch disable prime support when running

[Mesa-dev] [PATCH] draw/so: fix overflow calculation

2013-04-29 Thread Zack Rusin
only report overflow for missing targets if they're actually being used. if the targets are missing but are not being used by any slot in the stream output declaration we should correctly just ignore them. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_pt_so_emit.c | 26

Re: [Mesa-dev] visual leak?

2013-04-29 Thread Brian Paul
On 04/26/2013 03:23 PM, Andy Skinner wrote: Hi. We are seeing a leak of things created in XMesaCreateVisual, as called from fakeglx.c. I don’t see anywhere that XMesaDestroyVisual is called. I see a free() in destroy_visuals_on_display, but I don’t know how often that is called. Are these visuals

[Mesa-dev] [PATCH] r600/llvm: use killgt info from llvm

2013-04-29 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_llvm.c | 2 ++ src/gallium/drivers/r600/r600_llvm.h | 1 + src/gallium/drivers/r600/r600_shader.c | 8 ++-- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index 20

Re: [Mesa-dev] [PATCH] st/mesa: fix segfault in BufferData if size is 0 and buffer is NULL

2013-04-29 Thread Jose Fonseca
- Original Message - > I seem to recall adding a bunch of null pointer checks to the > st_cb_bufferobjects.c code in the past to avoid crashing in some > out-of-memory situations.  I think we should check for null pointers > wherever possible. FWIW, the fix that I suggested privately to Ma

Re: [Mesa-dev] recursive raytracing demo

2013-04-29 Thread Brian Paul
On 04/28/2013 06:54 AM, kristof.ralov...@gmail.com wrote: Dear All, please review and merge this demo. In patch 2: * Let's pass the GS input/output info as parameters to the function and rename it to something like LinkShadersWithGeometryInfo(). Then we can re-use the function in some of t

Re: [Mesa-dev] [PATCH 0/4] Implement glFramebufferTexture

2013-04-29 Thread Brian Paul
On 04/27/2013 05:37 PM, Jordan Justen wrote: This series adds support for the glFramebufferTexture function, which is required for GL 3.2 / ARB_geometry_shader4. These patches are available within the amd_vertex_shader_layer branch of git://people.freedesktop.org/~jljusten/mesa. Jordan Justen (

[Mesa-dev] [Bug 64045] New: Can't run egl applications under a software rendered weston/wayland

2013-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64045 Priority: medium Bug ID: 64045 Assignee: mesa-dev@lists.freedesktop.org Summary: Can't run egl applications under a software rendered weston/wayland Severity: normal Clas

[Mesa-dev] [v2 10/10] intel: enable EXT_image_dma_buf_import

2013-04-29 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c index 1aea7e9..46b5689 100755 --- a/src/mesa/drivers/dri/intel/intel

[Mesa-dev] [v2 09/10] egl: dri2: support for creating images out of dma buffers

2013-04-29 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/egl/drivers/dri2/egl_dri2.c | 238 1 file changed, 238 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 10fdcef..2a8c614 100644 --- a/src/egl/drivers/dri2/egl_dri2.c

[Mesa-dev] [v2 08/10] egl: definitions for EXT_image_dma_buf_import

2013-04-29 Thread Topi Pohjolainen
As specified in: http://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_image_dma_buf_import.txt Checking for the valid fourcc values is left for drivers avoiding dependency to drm header files here. v2: - enforce EGL_NO_CONTEXT Signed-off-by: Topi Pohjolainen --- include/EGL/eglext.h

[Mesa-dev] [v2 07/10] dri: propagate extra dma_buf import attributes to the drivers

2013-04-29 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- include/GL/internal/dri_interface.h| 23 +++ src/egl/drivers/dri2/egl_dri2.c| 1 + src/mesa/drivers/dri/intel/intel_regions.h | 7 +++ src/mesa/drivers/dri/intel/intel_screen.c | 9 + 4 files changed, 40 i

[Mesa-dev] [v2 06/10] intel: prepare for dri images having more than plane

2013-04-29 Thread Topi Pohjolainen
v2 (as advised by Eric): - use ARRAY_SIZE - re-use 'image_destroy' for cleaning up after failure - check directly the region pointer instead of the buffer object when determining if a region exists Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 103

[Mesa-dev] [v2 05/10] intel: set dri image dimensions even when creating out of primes

2013-04-29 Thread Topi Pohjolainen
Otherwise 'intel_set_texture_image_region()' won't have enough details to work with. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_s

[Mesa-dev] [v2 04/10] intel: refactor planar format lookup

2013-04-29 Thread Topi Pohjolainen
v2: - refactor both occurences, not just one Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/in

[Mesa-dev] [v2 03/10] intel: replace single region with a vector of regions

2013-04-29 Thread Topi Pohjolainen
No functional change in preparation for supporting multiple planes per image each having its own region. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_fbo.c | 6 +-- src/mesa/drivers/dri/intel/intel_regions.h | 7 ++- src/mesa/drivers/dri/intel/intel_screen.c

[Mesa-dev] [v2 02/10] intel: do not create renderbuffers out of planar images

2013-04-29 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_fbo.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c index d22de68..296ae00 100644 --- a/src/mesa/drivers/dri/intel/intel_fbo.c +++ b/src/

[Mesa-dev] [v2 01/10] intel: allow packed prime buffers to be treated normally

2013-04-29 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/intel/intel_screen.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_screen.c index 3745179..4c5cc995 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [v2] EXT_image_dma_buf_import for intel

2013-04-29 Thread Topi Pohjolainen
The set introduces new target for 'eglCreateImageKHR()' allowing one to create EGL images out of externally allocated buffers. Especially one can combine up to three separate buffers into one single logical entity. Low level native buffers may not support planar formats and hence EGL layer will ins

[Mesa-dev] [Bug 64041] Mesalib Installation

2013-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64041 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 64041] New: Mesalib Installation

2013-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64041 Priority: medium Bug ID: 64041 Assignee: mesa-dev@lists.freedesktop.org Summary: Mesalib Installation Severity: normal Classification: Unclassified OS: All Reporter

Re: [Mesa-dev] vbo code and flush explicit mapping

2013-04-29 Thread Dave Airlie
On Mon, Apr 29, 2013 at 2:52 PM, Dave Airlie wrote: > I've been playing with a gallium driver, and started looking at some > wierd gears behaviour, > > The vbo code maps the buffer with GL_MAP_FLUSH_EXPLICIT_BIT which to > me requires that at some point > we call ctx->Driver.FlushMappedBufferRange