[Mesa-dev] [PATCH 5/5] radeonsi: Fix user clip planes

2013-05-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 4 more little piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_state_draw.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] radeonsi: Handle TGSI_SEMANTIC_CLIPVERTEX

2013-05-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com 17 more little piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_pipe.h | 1 - src/gallium/drivers/radeonsi/radeonsi_shader.c | 62

[Mesa-dev] [PATCH 2/5] radeonsi: Fix handling of TGSI_SEMANTIC_PSIZE

2013-05-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Two more little piglits. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/radeonsi_pipe.h | 1 - src/gallium/drivers/radeonsi/radeonsi_shader.c | 4 +++-

[Mesa-dev] [PATCH 3/5] radeonsi: Initial support for multiple constant buffers

2013-05-17 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Just enough to support an additional internal constant buffer for the user clip planes. NOTE: This is a candidate for the 9.1 branch. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/r600_buffer.c | 30 ---

[Mesa-dev] [PATCH 1/5] radeonsi: increase array size for shader inputs and outputs

2013-05-17 Thread Michel Dänzer
From: Marek Olšák mar...@gmail.com and add assertions to prevent buffer overflow. This fixes corruption of the si_shader struct. NOTE: This is a candidate for the 9.1 branch. [ Cherry-pick of r600g commit da33f9b919039442e9ab51f9b1d1c83a73607133 ] Signed-off-by: Michel Dänzer

[Mesa-dev] [Bug 64649] Anomaly 2 (Steam) exits with GLX_EXT_swap_control not supported, unable to set vertical sync

2013-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64649 --- Comment #4 from bartosz.brzos...@11bitstudios.com --- The swap control extension is not required by the game to function. The exit must be caused by something else. What exactly happens? Does it look like graceful exit or a segfault? What

[Mesa-dev] [Bug 64668] Clipping is performed incorrectly when using shaders with intel/nouveau/radeon drivers.

2013-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64668 --- Comment #13 from edg...@yandex.ru --- As far as I've been able to tell from experimenting with the nVidia proprietary driver, its behaviour in this corner case is to not clip at all. You're absolutely correct, it doesn't clip. I see that

[Mesa-dev] [PATCH] scons: Don't force stabs debug format for Mingw.

2013-05-17 Thread jfonseca
From: José Fonseca jfons...@vmware.com - recent gdb handles DWARF fine (tested both with version 7.1.90.20100730 from mingw-w64 project, and 7.5-1 from mingw project) - http://people.freedesktop.org/~jrfonseca/bfdhelp/ was updated to handle DWARF - it requires ugly hacks to prevent

Re: [Mesa-dev] R600/SI Patches: A few cleanups for compute

2013-05-17 Thread Michel Dänzer
On Mit, 2013-05-15 at 14:26 -0700, Tom Stellard wrote: The attached patches add some new patterns and instructions for SI and are a prerequisite for more invasive compute shader changes that I'm working on. Please Review. The SI changes are Reviewed-by: Michel Dänzer

Re: [Mesa-dev] [PATCH] llvmpipe: Remove x/y from cmd_bin

2013-05-17 Thread Jose Fonseca
- Original Message - Am 16.05.2013 21:44, schrieb Adam Jackson: These were mostly just a waste of memory and cache pressure, and were really only used for debugging. This change reduces instruction count (as measured by callgrind's Ir event) of gnome-shell-perf-tool on

Re: [Mesa-dev] [PATCH] scons: Use LLVM shared library if found.

2013-05-17 Thread Jose Fonseca
Vinson, Why is this necessary? (I'd prefer that LLVM is statically linked by default. ) Jose - Original Message - This patch fixes SCons builds on Fedora 18. Signed-off-by: Vinson Lee v...@freedesktop.org --- scons/llvm.py | 10 +- 1 file changed, 9 insertions(+), 1

Re: [Mesa-dev] [PATCH] st/mesa: Remove unused variable 'texImage'.

2013-05-17 Thread Jose Fonseca
_mesa_get_attachment_teximage has no side effects so looks good to me. Jose - Original Message - All uses of 'texImage' were removed in commit 77a405dba7f70f8a47655e90774a5ecf5c88a6ed. Fixes Unused pointer value defect reported by Coverity. Signed-off-by: Vinson Lee

Re: [Mesa-dev] [PATCH 1/5] radeonsi: increase array size for shader inputs and outputs

2013-05-17 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Fri, May 17, 2013 at 11:27 AM, Michel Dänzer mic...@daenzer.net wrote: From: Marek Olšák mar...@gmail.com and add assertions to prevent buffer overflow. This fixes corruption of the si_shader struct. NOTE: This is a candidate for the 9.1

Re: [Mesa-dev] [PATCH 03/13] gallium: Introduce 32-bit bytewise format names

2013-05-17 Thread Jose Fonseca
- Original Message - From: Richard Sandiford r.sandif...@uk.ibm.com RGBA has R at byte 0 and A at byte 3, regardless of platform endianness. Maybe I'm missing something, but this naming convention seems to me the exact opposite of what was decided [1], which is: - R at byte 0,

Re: [Mesa-dev] [PATCH] llvmpipe: get rid of unused tiled/linear logic

2013-05-17 Thread Jose Fonseca
Thanks for doing this Roland. - Original Message - From: Roland Scheidegger srol...@vmware.com We do rendering to linear color buffers for quite some time, and since switching to linear depth buffers all the tiled/linear logic was unused. So get rid of (most) of it - there's still

[Mesa-dev] [PATCH 1/2] gallivm: Add and use lp_build_lerp_3d.

2013-05-17 Thread jfonseca
From: José Fonseca jfons...@vmware.com --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 20 src/gallium/auxiliary/gallivm/lp_bld_arit.h | 15 ++ src/gallium/auxiliary/gallivm/lp_bld_sample_aos.c | 51 ++--- 3 files changed, 60 insertions(+), 26

[Mesa-dev] [PATCH 2/2] gallivm: Eliminate 8.8 fixed point intermediates from AoS sampling path.

2013-05-17 Thread jfonseca
From: José Fonseca jfons...@vmware.com This change was meant as a stepping stone to use PMADDUBSW SSSE3 instruction, but actually this refactoring by itself yields a 10% speedup on texture intensive shaders (e.g, Google Earth's ocean water w/o S3TC on a Ivy Bridge machine), while giving yielding

[Mesa-dev] Gen6+ hardware contexts query object improvements

2013-05-17 Thread Kenneth Graunke
Hello! This patch series bumps the kernel requirement to 3.6 for Gen6+, meaning that we actually get to rely on hardware context support. That's a little painful, but even Debian ships 3.8 now, and this isn't going to make it into an actual release for several more months. It then splits our

[Mesa-dev] [PATCH 01/10] i965: Bump kernel requirement to 3.3 on Ivybridge.

2013-05-17 Thread Kenneth Graunke
Kernel 3.3 introduced the SOL reset execbuf parameter, needed for GL 3.0 on Ivybridge. Bumping the requirement will give an obvious error message rather than simply reporting GL 2.1. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/intel/intel_extensions.c | 5

[Mesa-dev] [PATCH 02/10] i965: Require hardware contexts (and thus Kernel 3.6) on Gen6+.

2013-05-17 Thread Kenneth Graunke
Hardware contexts are necessary to reasonably support OpenGL 3.2. In particular, we currently maintain software counters for transform feedback buffer offsets and counters, which relies on knowing the number of primitives generated. Geometry shaders violate that assumption. At the time of

[Mesa-dev] [PATCH 04/10] i965: Disable pixel statistics in BLORP.

2013-05-17 Thread Kenneth Graunke
BLORP is used for operations like glClear, glCopyTexImage, and glBlitFramebuffer which aren't supposed to contribute fragments toward occlusion queries. This prevents Piglit tests from breaking in the next commit. Cc: Eric Anholt e...@anholt.net Cc: Paul Berry stereotype...@gmail.com

[Mesa-dev] [PATCH 05/10] i965: Rely on hardware contexts for query objects on Gen6+.

2013-05-17 Thread Kenneth Graunke
Hardware contexts greatly simplify the query object code. The pipeline statistics counters get saved and restored with the context, which means that we don't need to worry about other workloads polluting them. This means that we can simply write a single pair of values (one at BeginQuery and one

[Mesa-dev] [PATCH 06/10] i965: Add #defines for the pipeline statistics counter registers.

2013-05-17 Thread Kenneth Graunke
These come from the Ivybridge PRM, Volume 1, Part 3. Cc: Eric Anholt e...@anholt.net Cc: Paul Berry stereotype...@gmail.com Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/intel/intel_reg.h | 13 + 1 file changed, 13 insertions(+) diff --git

[Mesa-dev] [PATCH 07/10] i965: Disable clipper statistics when meta operations are in progress.

2013-05-17 Thread Kenneth Graunke
We don't currently use the clipper statistics, but we'll soon use CL_INVOCATIONS_COUNT to implement the GL_PRIMITIVES_GENERATED query. The number of primitives generated is not supposed to be altered during operations such as glGenerateMipmap. Prevents spec/EXT_transform_feedback/generatemipmap

[Mesa-dev] [PATCH 08/10] i965: Handle rasterizer discard in the clipper rather than SOL on Gen7.

2013-05-17 Thread Kenneth Graunke
In order to implement the GL_PRIMITIVES_GENERATED query in a sane fashion on our hardware, we can't discard primitives until the clipper. The patch after next explains the rationale. By setting the clipper to REJECT_ALL mode, all primitives get thrown away, so rendering is still appropriately

[Mesa-dev] [PATCH 09/10] i965: Handle rasterizer discard in the clipper rather than GS on Gen6.

2013-05-17 Thread Kenneth Graunke
This has more of a negative impact than the previous patch, as on Gen6 passing primitives through to the clipper means we actually have to make the GS thread write them to the URB. I don't see another good solution though, and rasterizer discard is not the most common of cases, so hopefully it

[Mesa-dev] [PATCH 10/10] i965: Implement transform feedback query support in hardware on Gen6+.

2013-05-17 Thread Kenneth Graunke
Now that we have hardware contexts and can use MI_STORE_REGISTER_MEM, we can use the GPU's pipeline statistics counters rather than going out of our way to count primitives in software. Aside from being simpler, this also paves the way for Geometry Shaders, which can output an arbitrary number of

[Mesa-dev] [PATCH] mesa: declare UniformBufferBindings as an array with a static size

2013-05-17 Thread Marek Olšák
Some Gallium drivers were crashing, because the array was not large enough. v2: clamp the per-shader maximum in st/mesa, then sum them all up NOTE: This is a candidate for the stable branches. --- src/mesa/main/bufferobj.c | 10 ++ src/mesa/main/config.h |

[Mesa-dev] [PATCH 2/2] i965: Add cases for ir_triop_vector_insert that assert.

2013-05-17 Thread Kenneth Graunke
brw_link_shader() unconditionally calls lower_vector_insert() with true as the second parameter. This means that both constant and variable indexed expressions will get lowered, so we should never see this in the backend. Cc: Ian Romanick i...@freedesktop.org Cc: Paul Berry

[Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Kenneth Graunke
do_vec_index_to_swizzle() should remove any vector extract operations with a constant index. It's unconditionally called from do_common_optimization(). do_vec_index_to_cond_assign() should remove the rest, and it is unconditionally called from brw_link_shader(). This means that we should never

Re: [Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Matt Turner
On Fri, May 17, 2013 at 10:43 AM, Kenneth Graunke kenn...@whitecape.org wrote: do_vec_index_to_swizzle() should remove any vector extract operations with a constant index. It's unconditionally called from do_common_optimization(). do_vec_index_to_cond_assign() should remove the rest, and it

Re: [Mesa-dev] A simple GLES2 shader application performance slower with h/w renderer

2013-05-17 Thread Eric Anholt
Divick Kishore divick.kish...@gmail.com writes: By default we sync to vblank, which for you is 60. The software rasterizer lacks this feature. I meant that even with h/w rasterizer I get fps = 60 with vblank=0 set. The weird thing is that he said he ran it with vblank_mode=0. Makes me

Re: [Mesa-dev] [PATCH] scons: Use LLVM shared library if found.

2013-05-17 Thread Vinson Lee
On Fri, May 17, 2013 at 7:44 AM, Jose Fonseca jfons...@vmware.com wrote: Vinson, Why is this necessary? (I'd prefer that LLVM is statically linked by default. ) Jose The SCons build fails on systems that only provide a LLVM shared library. 'llvm-config --libs' always enumerates the

Re: [Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: do_vec_index_to_swizzle() should remove any vector extract operations with a constant index. It's unconditionally called from do_common_optimization(). do_vec_index_to_cond_assign() should remove the rest, and it is unconditionally called from

Re: [Mesa-dev] A simple GLES2 shader application performance slower with h/w renderer

2013-05-17 Thread Divick Kishore
vblank_mode was broken for a long time in EGL, but current 9.0 and 9.1 have it fixed. Not sure what version you're on. I am using version 8.0.5. I have been unable to build the 9.1 for softpipe renderer using the same options that I was using for building 8.0.5. I have posted separately on the

Re: [Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Eric Anholt
Eric Anholt e...@anholt.net writes: Kenneth Graunke kenn...@whitecape.org writes: do_vec_index_to_swizzle() should remove any vector extract operations with a constant index. It's unconditionally called from do_common_optimization(). do_vec_index_to_cond_assign() should remove the rest,

Re: [Mesa-dev] [PATCH 07/10] i965: Disable clipper statistics when meta operations are in progress.

2013-05-17 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: We don't currently use the clipper statistics, but we'll soon use CL_INVOCATIONS_COUNT to implement the GL_PRIMITIVES_GENERATED query. The number of primitives generated is not supposed to be altered during operations such as glGenerateMipmap.

Re: [Mesa-dev] [PATCH 03/10] i965: Delete Gen7+ check for Kernel 3.3 now that we require 3.6+.

2013-05-17 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: It's just not necessary. I'd squash this with the previous, and lower-case Kernel -- it seems to be the convention when it's not part of some other proper noun. pgpObc4KqS0OC.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH 08/10] i965: Handle rasterizer discard in the clipper rather than SOL on Gen7.

2013-05-17 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: In order to implement the GL_PRIMITIVES_GENERATED query in a sane fashion on our hardware, we can't discard primitives until the clipper. The patch after next explains the rationale. By setting the clipper to REJECT_ALL mode, all primitives get

Re: [Mesa-dev] Gen6+ hardware contexts query object improvements

2013-05-17 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: Hello! This patch series bumps the kernel requirement to 3.6 for Gen6+, meaning that we actually get to rely on hardware context support. That's a little painful, but even Debian ships 3.8 now, and this isn't going to make it into an actual

Re: [Mesa-dev] [PATCH] scons: Use LLVM shared library if found.

2013-05-17 Thread Aaron Watry
On Fri, May 17, 2013 at 2:31 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - On Fri, May 17, 2013 at 7:44 AM, Jose Fonseca jfons...@vmware.com wrote: Vinson, Why is this necessary? (I'd prefer that LLVM is statically linked by default. ) Jose The SCons

[Mesa-dev] [PATCH 1/2] r600g/compute: Use common transfer_{map, unmap} functions for kernel inputs

2013-05-17 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/evergreen_compute.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c index 5f67759..4d490c4

[Mesa-dev] [PATCH 2/2] r600g/compute: Use common transfer_{map, unmap} functions for global resources

2013-05-17 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/evergreen_compute.c | 68 ++-- 1 file changed, 24 insertions(+), 44 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c index

[Mesa-dev] [PATCH] llvmpipe: fix stencil issues

2013-05-17 Thread sroland
From: Roland Scheidegger srol...@vmware.com Two (somewhat related) issues: 1) We did mask checks between depth/stencil testing and depth/stencil write. This meant that if the depth/stencil test killed off all fragments we never actually wrote the new stencil value. This issue affected all

[Mesa-dev] [PATCH 0/5] Gen7 Layered Color Renderbuffer support

2013-05-17 Thread Jordan Justen
git://people.freedesktop.org/~jljusten/mesa ivb-layered-color-renderbuffer-v1 This series updates gen7 to allow layered color render buffers. With these changes we can support the AMD_vertex_shader_layer extension for color renderbuffers. Once depth is also supported, then we can actually

[Mesa-dev] [PATCH 1/5] intel: print image depth in debug message

2013-05-17 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/intel/intel_fbo.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c index 69f8629..a8a7ab3 100644 ---

[Mesa-dev] [PATCH 3/5] intel: add layered parameter to update_renderbuffer_surface

2013-05-17 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |6 +- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |3 +++ src/mesa/drivers/dri/intel/intel_context.h|1 + 3 files changed, 9 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 2/5] intel_fbo: set gl_renderbuffer Depth field

2013-05-17 Thread Jordan Justen
Set the renderbuffer's Depth field to match the texture's Depth when rendering to a texture. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/intel/intel_fbo.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] i965 gen7: add support for layered color renderbuffers

2013-05-17 Thread Jordan Justen
Rather than pointing the surface_state directly at a single sub-image of the texture for rendering, we now point the surface_state at the top level of the texture, and configure the surface_state as needed based on this. We now also need to stop setting the FORCE_ZERO_RTAINDEX bit in the clip

[Mesa-dev] [PATCH 4/5] mesa/texformat: add _mesa_tex_target_is_array function

2013-05-17 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/main/texformat.c | 13 + src/mesa/main/texformat.h |2 ++ 2 files changed, 15 insertions(+) diff --git a/src/mesa/main/texformat.c b/src/mesa/main/texformat.c index ed40b7e..a7df868 100644 ---

[Mesa-dev] [Bug 64649] Anomaly 2 (Steam) exits with GLX_EXT_swap_control not supported, unable to set vertical sync

2013-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64649 --- Comment #5 from romula...@gmail.com --- 01:00.0 VGA compatible controller: Advanced Micro Devices [AMD] nee ATI RV770 [Radeon HD 4870] -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 64649] Anomaly 2 (Steam) exits with GLX_EXT_swap_control not supported, unable to set vertical sync

2013-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64649 --- Comment #6 from romula...@gmail.com --- Created attachment 79488 -- https://bugs.freedesktop.org/attachment.cgi?id=79488action=edit full steam logfile -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 64649] Anomaly 2 (Steam) exits with GLX_EXT_swap_control not supported, unable to set vertical sync

2013-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64649 --- Comment #7 from romula...@gmail.com --- (In reply to comment #4) Does it look like agraceful exit or a segfault? No segfault so a graceful exit. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 64730] New: [llvmpipe] piglit array-texture regression

2013-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64730 Priority: medium Bug ID: 64730 Keywords: regression CC: jfons...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit array-texture regression

[Mesa-dev] [Bug 64730] [llvmpipe] piglit array-texture regression

2013-05-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64730 Roland Scheidegger srol...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 2/2] r600g/compute: Use common transfer_{map, unmap} functions for global resources

2013-05-17 Thread Marek Olšák
On Sat, May 18, 2013 at 2:17 AM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/evergreen_compute.c | 68 ++-- 1 file changed, 24 insertions(+), 44 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 5/5] i965 gen7: add support for layered color renderbuffers

2013-05-17 Thread Chia-I Wu
On Sat, May 18, 2013 at 10:11 AM, Jordan Justen jordan.l.jus...@intel.com wrote: Rather than pointing the surface_state directly at a single sub-image of the texture for rendering, we now point the surface_state at the top level of the texture, and configure the surface_state as needed based